Re: Consider changing CONFIG_ACPI default on ARM?

On 06.08.2025 06:30, Elliott Mitchell wrote: > On Tue, Jul 01, 2025 at 10:01:13PM +0200, Paul Leiber wrote: >> >> Unfortunately, I don't have a direct answer to the question (as is so often >> the case, due to my limited knowledge and experience). However, I am >> successfully running Xen on a RPi

Re: [PATCH v3] EFI/runtime: switch to xv[mz]alloc_array()

On 14.08.2025 02:29, Daniel P. Smith wrote: > On 8/12/25 02:12, Jan Beulich wrote: >> On 12.08.2025 02:19, Daniel P. Smith wrote: >>> On 7/23/25 09:39, Jan Beulich wrote: Use the more "modern" form, thus doing away with effectively open-coding xmalloc_array() at the same time. While there

Re: [PATCH v6 19/19] xen/cpufreq: Adapt SET/GET_CPUFREQ_CPPC xen_sysctl_pm_op for amd-cppc driver

On 14.08.2025 05:13, Penny, Zheng wrote: > [Public] > >> -Original Message- >> From: Jan Beulich >> Sent: Thursday, July 24, 2025 10:44 PM >> To: Penny, Zheng >> Cc: Huang, Ray ; Anthony PERARD >> ; Andrew Cooper ; >> Orzel, Michal ; Julien Grall ; Roger >> Pau >> Monné ; Stefano Stabel

Re: [PATCH] misra: add ASSERT_UNREACHABLE() in default clauses

On 13.08.2025 00:54, Julien Grall wrote: > Hi Jan, > > On 12/08/2025 08:32, Jan Beulich wrote: >> On 11.08.2025 23:21, Julien Grall wrote: >>> On 11/08/2025 21:30, Dmytro Prokopchuk1 wrote: --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -330,9 +330,12 @@ shared_ent

Re: [PATCH v4 2/8] emul/vuart: introduce framework for UART emulators

On Tue, Aug 12, 2025 at 08:52:18AM +0200, Jan Beulich wrote: > On 12.08.2025 01:55, dm...@proton.me wrote: > > On Mon, Aug 11, 2025 at 09:34:58AM +0200, Jan Beulich wrote: > >> On 09.08.2025 20:55, dm...@proton.me wrote: > >>> On Mon, Aug 04, 2025 at 12:11:03PM +0200, Jan Beulich wrote: > On 3

RE: [PATCH v6 19/19] xen/cpufreq: Adapt SET/GET_CPUFREQ_CPPC xen_sysctl_pm_op for amd-cppc driver

[Public] > -Original Message- > From: Jan Beulich > Sent: Thursday, July 24, 2025 10:44 PM > To: Penny, Zheng > Cc: Huang, Ray ; Anthony PERARD > ; Andrew Cooper ; > Orzel, Michal ; Julien Grall ; Roger Pau > Monné ; Stefano Stabellini ; > xen- > de...@lists.xenproject.org > Subject: Re

[PATCH v5 0/3] kern/xen: Add Xen command line parsing

From: Aaron Rainbolt The purpose of this patch is to allow the Xen hypervisor to pass extra data to GRUB in the form of a kernel command line, allowing the host to customize the boot process of the guest. The command line from Xen is parsed, and any variables within that start with the string `xe

[PATCH v5 2/3] include/xen: Add warning comment for cmd_line

From: Aaron Rainbolt The cmd_line field of the start_info struct is not guaranteed to be NUL-terminated, even though it is intended to contain a NUL-terminated string. Add a warning about this in a comment so future consumers of this field know to check it for a NUL terminator before using it. S

[PATCH v5 3/3] kern/xen: Add Xen command line parsing

From: Aaron Rainbolt Xen traditionally allows customizing guest behavior by passing arguments to the VM kernel via the kernel command line. This is no longer possible when using GRUB with Xen, as the kernel command line is decided by the GRUB configuration file within the guest, not data passed t

[PATCH v5 1/3] include/xen: Rename MAX_GUEST_CMDLINE to GRUB_XEN_MAX_GUEST_CMDLINE

From: Aaron Rainbolt The xen.h header was using an overly generic name to refer to the maximum length of the command line passed from Xen to a guest. Rename it to avoid confusion or conflicts in the future. Signed-off-by: Aaron Rainbolt --- include/xen/xen.h | 4 ++-- 1 file changed, 2 inserti

Re: [PATCH] misra: address Rule 11.1 violation in cmpxchgptr()

Hello, Le 13/08/2025 à 20:07, Dmytro Prokopchuk1 a écrit : > Misra Rule 11.1 states: "Conversions shall not be performed between a > pointer to a function and any other type." > > The violation occurs in the macro: > __typeof__(**(ptr)) *const o_ = (o);\ >

Re: [RFC PATCH] misra: allow conversion from unsigned long to function pointer

Hello, Le 13/08/2025 à 20:30, Dmytro Prokopchuk1 a écrit : > ... > > from `vaddr_t' (that is `unsigned long') to `switch_ttbr_fn*' (that is > `void(*)(unsigned long)') > > Signed-off-by: Dmytro Prokopchuk > --- > This is just a RFC patch. > The commit message is not important at this stage. > >

Re: [PATCH v3] EFI/runtime: switch to xv[mz]alloc_array()

On 8/12/25 02:12, Jan Beulich wrote: On 12.08.2025 02:19, Daniel P. Smith wrote: On 7/23/25 09:39, Jan Beulich wrote: Use the more "modern" form, thus doing away with effectively open-coding xmalloc_array() at the same time. While there is a difference in generated code, as xmalloc_bytes() forc

[PATCH] x86/cpu-policy: Drop workaround for pre-GCC-5 PIC issue

GCC 5.1 is the minimum supported toolchain version now. Drop the workaround for the PIC hard register in earlier versions. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Nicola Vetrini Noticed when reviewing the other GCC cleanup. --- xen/inc

Re: [XEN PATCH 3/3] xen/efi: efibind: Drop alternative define for old GCC versions

On 13/08/2025 8:12 pm, nicola.vetr...@gmail.com wrote: > From: Nicola Vetrini > > Since the toolchain baseline for GCC is 5.1, there is no need for > this case. > > Signed-off-by: Nicola Vetrini > --- > Mentioned in https://gitlab.com/xen-project/xen/-/issues/201 I personally am in favour of thi

Re: [XEN PATCH 2/3] xen/macros: Drop alternative definition of BUILD_BUG_ON(_ZERO)? for old GCC

On 13/08/2025 8:12 pm, nicola.vetr...@gmail.com wrote: > From: Nicola Vetrini > > The toolchain baseline for GCC is 5.1, which supports _Static_assert > in c99 mode > > No functional change. > > Signed-off-by: Nicola Vetrini > --- > Mentioned in https://gitlab.com/xen-project/xen/-/issues/201 Re

Re: [XEN PATCH 1/3] xen/compiler: drop alternative unreachable() definition for older GCC

On 13/08/2025 8:12 pm, nicola.vetr...@gmail.com wrote: > From: Nicola Vetrini > > The GCC baseline version is 5.1, which supports __builtin_unreachable(), > therefore the alternative definition can be dropped > > Signed-off-by: Nicola Vetrini > --- > Mentioned in https://gitlab.com/xen-project/xe

Re: [PATCH v4 2/2] kern/xen: Add Xen command line parsing

On Wed, 13 Aug 2025 16:27:11 +0200 Daniel Kiper wrote: > On Tue, Aug 12, 2025 at 06:55:15PM -0500, Aaron Rainbolt wrote: > > On Tue, 12 Aug 2025 19:02:11 +0200 Daniel Kiper > > wrote: > > > On Mon, Aug 04, 2025 at 11:50:09PM -0500, Aaron Rainbolt wrote: > > > > Xen traditionally allows custo

Re: [PATCH] x86/pvh: update "Host ACPI" support status

On Wed, 13 Aug 2025, Roger Pau Monne wrote: > For x86 PVH dom0 makes uses of the host ACPI tables, and hence the status > of Host ACPI entry should have been updated to reflect that PVH dom0 is now > supported, and Host ACPI support is not one of the caveats. > > Fixes: ea1cb444c28c ('x86/pvh: dec

[XEN PATCH 3/3] xen/efi: efibind: Drop alternative define for old GCC versions

From: Nicola Vetrini Since the toolchain baseline for GCC is 5.1, there is no need for this case. Signed-off-by: Nicola Vetrini --- Mentioned in https://gitlab.com/xen-project/xen/-/issues/201 --- xen/arch/x86/include/asm/x86_64/efibind.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[XEN PATCH 1/3] xen/compiler: drop alternative unreachable() definition for older GCC

From: Nicola Vetrini The GCC baseline version is 5.1, which supports __builtin_unreachable(), therefore the alternative definition can be dropped Signed-off-by: Nicola Vetrini --- Mentioned in https://gitlab.com/xen-project/xen/-/issues/201 --- xen/include/xen/compiler.h | 4 1 file chang

[XEN PATCH 0/3] Drop alternative definitions for unsupported GCCs

From: Nicola Vetrini Similar to e4a042062787, drop alternative defines for older GCC versions Nicola Vetrini (3): xen/compiler: drop alternative unreachable() definition for older GCC xen/macros: Drop alternative definition of BUILD_BUG_ON(_ZERO)? for old GCC xen/efi: efibind: Drop alt

[XEN PATCH 2/3] xen/macros: Drop alternative definition of BUILD_BUG_ON(_ZERO)? for old GCC

From: Nicola Vetrini The toolchain baseline for GCC is 5.1, which supports _Static_assert in c99 mode No functional change. Signed-off-by: Nicola Vetrini --- Mentioned in https://gitlab.com/xen-project/xen/-/issues/201 --- xen/include/xen/macros.h | 8 1 file changed, 8 deletions(-)

[RFC PATCH] misra: allow conversion from unsigned long to function pointer

... from `vaddr_t' (that is `unsigned long') to `switch_ttbr_fn*' (that is `void(*)(unsigned long)') Signed-off-by: Dmytro Prokopchuk --- This is just a RFC patch. The commit message is not important at this stage. I am seeking comments regarding this case. Thanks. --- automation/eclair_anal

[PATCH] misra: address Rule 11.1 violation in cmpxchgptr()

Misra Rule 11.1 states: "Conversions shall not be performed between a pointer to a function and any other type." The violation occurs in the macro: __typeof__(**(ptr)) *const o_ = (o);\ __typeof__(**(ptr)) *n_ = (n); \

Re: [XEN PATCH 04/11] tools/configure: Introduce deps on json-c lib for libxl

On Mon, Aug 11, 2025 at 11:48:19AM +0100, Andrew Cooper wrote: > On 08/08/2025 3:55 pm, Anthony PERARD wrote: > > xl: $(XL_OBJS) > > - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) > > $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) -lyajl > > $(APPEND_LDFLAGS) > >

Re: [PATCH v1 16/16] nvme-pci: unmap MMIO pages with appropriate interface

On Thu, Aug 07, 2025 at 10:45:33AM -0300, Jason Gunthorpe wrote: > On Mon, Aug 04, 2025 at 03:42:50PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Block layer maps MMIO memory through dma_map_phys() interface > > with help of DMA_ATTR_MMIO attribute. There is a need to unmap >

Re: [PATCH 2/5] CI: Update ppc64 to use Debian Trixie

On Sat, Aug 09, 2025 at 11:12:03PM +0100, Andrew Cooper wrote: > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index ab5211f77e5e..3fe539dc5683 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -319,10 +319,10 @@ debian-12

Re: [PATCH v1 08/16] kmsan: convert kmsan_handle_dma to use physical addresses

On Thu, Aug 07, 2025 at 09:21:15AM -0300, Jason Gunthorpe wrote: > On Mon, Aug 04, 2025 at 03:42:42PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Convert the KMSAN DMA handling function from page-based to physical > > address-based interface. > > > > The refactoring renames k

Re: [PATCH] xen/events: Fix Global and Domain VIRQ tracking

On 2025-08-12 15:00, Jason Andryuk wrote: VIRQs come in 3 flavors, per-VPU, per-domain, and global. The existing tracking of VIRQs is handled by per-cpu variables virq_to_irq. The issue is that bind_virq_to_irq() sets the per_cpu virq_to_irq at registration time - typically CPU 0. Later, the i

Re: [PATCH v4 2/2] kern/xen: Add Xen command line parsing

On Tue, Aug 12, 2025 at 06:55:15PM -0500, Aaron Rainbolt wrote: > On Tue, 12 Aug 2025 19:02:11 +0200 Daniel Kiper wrote: > > On Mon, Aug 04, 2025 at 11:50:09PM -0500, Aaron Rainbolt wrote: > > > Xen traditionally allows customizing guest behavior by passing > > > arguments to the VM kernel via the

Re: [PATCH] pdx: cast PAGE_SIZE value ahead of shifting

On 13/08/2025 1:55 pm, Roger Pau Monne wrote: > Coverity complains that: > > 277ma_va_bottom_mask   = (PAGE_SIZE << bottom_shift) - 1; I'd perhaps drop this line from the commit message.  The sentence below is fine, and there's only a single hunk so it's obvious what is being referred to. >

[PATCH] pdx: cast PAGE_SIZE value ahead of shifting

Coverity complains that: 277ma_va_bottom_mask   = (PAGE_SIZE << bottom_shift) - 1; In expression 0x1000 << bottom_shift, left shifting by more than 31 bits has undefined behavior. The shift amount, bottom_shift, is as much as 63. Cast PAGE_SIZE to paddr_t so it has the right width. Reporte

Re: [XEN PATCH v2 3/3] CI: Workaround extra content in junit

On Sat, Aug 09, 2025 at 06:25:28PM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Jul 30, 2025 at 05:26:02PM +0200, Anthony PERARD wrote: > > From: Anthony PERARD > > > > Signed-off-by: Anthony PERARD > > Is it still an issue? AFAIR similar issue was fixed together with fixing > xml upload

[PATCH] libxl: Add virtio (virtio-vga) display support

Add "virtio" vga which uses the virtio-vga device provided by upstream QEMU. It is VGA compatible and can be enlightened with virtio-gpu drivers which are available since Linux 4.4 and as a part of KVM Windows drivers. Signed-off-by: Teddy Astie --- CHANGELOG.md | 1 + docs/m

Re: [Coverity complaint] Re: [PATCH v5] pdx: introduce a new compression algorithm based on region offsets

On Wed, Aug 13, 2025 at 12:47:37PM +0100, Andrew Cooper wrote: > On 12/08/2025 4:06 pm, Roger Pau Monne wrote: > > Signed-off-by: Roger Pau Monné > > Not this patch, but this is probably the best place to report it. > > https://scan5.scan.coverity.com/#/project-view/30554/10426?selectedIssue=166

Re: [XEN PATCH v2 1/3] CI: Rework run-tools-test exit path

On Sat, Aug 09, 2025 at 06:22:33PM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Jul 30, 2025 at 05:26:00PM +0200, Anthony PERARD wrote: > > From: Anthony PERARD > > > > The main script expect to find the string "$passed" or it just timeout > > and doesn't try to download the junit file in t

Re: [PATCH 13/22] x86: FRED enumerations

On 08/08/2025 9:23 pm, Andrew Cooper wrote: > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index a45ce106e210..90cbad13a7c7 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -57,6 +57,10 @@ config HAS_CC_CET_IBT > # Retpoline check to work around > https://g

Re: [PATCH 00/20] Add SMMUv3 Stage 1 Support for XEN guests

On 13/08/2025 11:04, Milan Djokic wrote: Hello Julien, Hi Milan, We have prepared a design document and it will be part of the updated patch series (added in docs/design). I'll also extend cover letter with details on implementation structure to make review easier. I would suggest to jus

Re: [PATCH 10/22] x86/traps: Move subarch_percpu_traps_init() into traps-setup.c

On 12/08/2025 10:52 am, Jan Beulich wrote: > On 11.08.2025 10:17, Andrew Cooper wrote: >> On 08/08/2025 9:23 pm, Andrew Cooper wrote: >>> ... along with the supporting functions. Switch to Xen coding style, and >>> make >>> static as there are no external callers. >>> >>> Rename to legacy_syscall

[Coverity complaint] Re: [PATCH v5] pdx: introduce a new compression algorithm based on region offsets

On 12/08/2025 4:06 pm, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné Not this patch, but this is probably the best place to report it. https://scan5.scan.coverity.com/#/project-view/30554/10426?selectedIssue=1662707 Something you did in the series made enough changes in pfn_pdx_compre

Re: [PATCH 09/22] x86/traps: Move load_system_tables() into traps-setup.c

On 12/08/2025 10:43 am, Nicola Vetrini wrote: > On 2025-08-08 22:23, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/traps-setup.c b/xen/arch/x86/traps-setup.c >> index 8ca379c9e4cb..13b8fcf0ba51 100644 >> --- a/xen/arch/x86/traps-setup.c >> +++ b/xen/arch/x86/traps-setup.c >> @@ -19,6 +20,124 @@

Re: [PATCH 09/22] x86/traps: Move load_system_tables() into traps-setup.c

On 12/08/2025 10:19 am, Jan Beulich wrote: > On 08.08.2025 22:23, Andrew Cooper wrote: >> Switch it to Xen coding style and fix MISRA violations. > That were all ul -> UL suffix transformations, afaics? Yes. > >> Make it static as >> there are no external caller now. >> >> Since commit a35816b5c

Re: [PATCH 08/22] x86/traps: Introduce ap_early_traps_init() and set up exception handling earlier

On 12/08/2025 9:41 am, Jan Beulich wrote: > On 08.08.2025 22:23, Andrew Cooper wrote: >> --- a/xen/arch/x86/acpi/wakeup_prot.S >> +++ b/xen/arch/x86/acpi/wakeup_prot.S >> @@ -63,6 +63,9 @@ LABEL(s3_resume) >> pushq %rax >> lretq >> 1: >> +/* Set up early exceptions and

Re: [PATCH 07/22] x86/spec-ctrl: Rework init_shadow_spec_ctrl_state() to take an info pointer

On 12/08/2025 9:27 am, Jan Beulich wrote: > On 08.08.2025 22:22, Andrew Cooper wrote: >> We're going to want to reuse it for a remote stack shortly. > Are we? From the titles of subsequent patches I can't judge where that would > be, so it's hard to peek ahead. And iirc earlier on it was a concious

Re: [PATCH 07/20] xen/arm: vIOMMU: Add cmdline boot option "viommu = "

Hello Jan, On 8/8/25 08:20, Jan Beulich wrote: On 07.08.2025 18:59, Milan Djokic wrote: --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2058,6 +2058,13 @@ This option can be specified more than once (up to 8 times at present). Flag to enable or disable

Re: [PATCH 00/20] Add SMMUv3 Stage 1 Support for XEN guests

On 8/7/25 19:58, Julien Grall wrote: Hi Milan, On Thu, 7 Aug 2025 at 17:55, Milan Djokic > wrote: This patch series represents a rebase of an older patch series implemented and sumbitted by Rahul Singh as an RFC: https://patchwork.kernel.org/ proje

Re: [PATCH 06/22] x86/traps: Introduce bsp_traps_reinit()

On 12/08/2025 9:19 am, Jan Beulich wrote: > On 08.08.2025 22:22, Andrew Cooper wrote: >> ... to abstract away updating the refereces to the old BSP stack. >> >> Signed-off-by: Andrew Cooper > If it helps later: > Acked-by: Jan Beulich > with .. > >> --- a/xen/arch/x86/traps-setup.c >> +++ b/xen/a

Re: [PATCH 04/22] x86/idt: Minor improvements to _update_gate_addr_lower()

On 12/08/2025 9:16 am, Jan Beulich wrote: > On 08.08.2025 22:22, Andrew Cooper wrote: >> After some experimentation, using .a/.b makes far better logic than using the >> named fields, as both Clang and GCC spill idte to the stack when named fields >> are used. >> >> GCC seems to do something very d

Re: [PATCH] misra: add ASSERT_UNREACHABLE() in default clauses

On 8/13/25 01:54, Julien Grall wrote: > Hi Jan, > > On 12/08/2025 08:32, Jan Beulich wrote: >> On 11.08.2025 23:21, Julien Grall wrote: >>> On 11/08/2025 21:30, Dmytro Prokopchuk1 wrote: --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -330,9 +330,12 @@ shared_entr

Re: [PATCH 03/22] x86/traps: Drop incorrect BUILD_BUG_ON() and comment in load_system_tables()

On 12/08/2025 9:11 am, Jan Beulich wrote: > On 08.08.2025 22:22, Andrew Cooper wrote: >> This was added erroneously by me. >> >> Hardware task switching does demand a TSS of at least 0x67 bytes, but that's >> not relevant in 64bit, and not relevant for Xen since commit >> 5d1181a5ea5e ("xen: Remove

[PATCH] x86/pvh: update "Host ACPI" support status

For x86 PVH dom0 makes uses of the host ACPI tables, and hence the status of Host ACPI entry should have been updated to reflect that PVH dom0 is now supported, and Host ACPI support is not one of the caveats. Fixes: ea1cb444c28c ('x86/pvh: declare PVH dom0 supported with caveats') Signed-off-by:

Re: [PATCH 01/22] x86/msr: Rename MSR_INTERRUPT_SSP_TABLE to MSR_ISST

On 12/08/2025 9:06 am, Jan Beulich wrote: > On 08.08.2025 22:22, Andrew Cooper wrote: >> The name AMD chose is rather more concise. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > I'm okay with the (much) shorter name, so: > Acked-by: Jan Beulich Thanks. > > But I can't make th

Re: [XEN PATCH 2/2] Address violation of MISRA C Rule 13.1 involving asm side effects.

On 2025-08-13 09:41, Dmytro Prokopchuk1 wrote: On 8/9/25 00:40, Nicola Vetrini wrote: The rule states: "Initializer lists shall not contain persistent side effects". The specific way in which the 'mrs' instruction is used does not lead to visible side effects for the surrounding code. Signed-

Re: [XEN PATCH 2/2] Address violation of MISRA C Rule 13.1 involving asm side effects.

On 8/9/25 00:40, Nicola Vetrini wrote: > The rule states: "Initializer lists shall not contain persistent side > effects". > The specific way in which the 'mrs' instruction is used does not lead to > visible side effects for the surrounding code. > > Signed-off-by: Nicola Vetrini > --- > Not y

Re: [PATCH for-4.21?] x86: drop detection of ld supporting SORT_BY_INIT_PRIORITY()

On 8/11/25 1:10 PM, Andrew Cooper wrote: On 11/08/2025 12:02 pm, Jan Beulich wrote: GNU ld 2.25 supports this, and we already assume all lld versions do. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- While past the submission deadline, this fits the toolchain baseline update we did

Re: S3 regression related to XSA-471 patches

On Wed, Aug 13, 2025 at 04:53:53AM +0200, Marek Marczykowski-Górecki wrote: > > > On August 11, 2025 3:16:46 PM GMT+02:00, Andrew Cooper > wrote: > >On 07/08/2025 6:29 pm, Marek Marczykowski-Górecki wrote: > >> On Wed, Aug 06, 2025 at 12:46:36PM +0200, Marek Marczykowski-Górecki wrote: > >>> On