Re: [PATCH v3 21/30] target/ppc: Introduce PowerPCCPUClass::has_work()

2021-09-02 Thread David Gibson
_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | > PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | > @@ -8275,6 +8278,7 @@ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) > pcc->lpcr_pm = LPCR_PDEE | LPCR_HDEE | LPCR_EEE | LPCR_DEE | LPCR_OEE; > pcc->mmu_model =

Re: [PATCH v3 20/30] target/ppc: Restrict has_work() handler to sysemu and TCG

2021-09-02 Thread David Gibson
On Thu, Sep 02, 2021 at 06:15:33PM +0200, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > target/ppc/cpu_init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value

2021-02-22 Thread David Gibson
{ > > > > > > No objection to this patch; but I'm wondering why some non-pseries > > > machines implement the kvm_type callback, when I see the kvm-type > > > property only for pseries? Am I holding my git grep wrong? > > > > Can it be wha

Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value

2021-02-22 Thread David Gibson
On Tue, Feb 23, 2021 at 10:33:55AM +1100, David Gibson wrote: > On Mon, Feb 22, 2021 at 06:50:44PM +0100, Cornelia Huck wrote: > > On Mon, 22 Feb 2021 18:41:07 +0100 > > Philippe Mathieu-Daudé wrote: > > > > > On 2/22/21 6:24 PM, Cornelia Huck wrote: > > &g

Re: [RFC PATCH v2 06/11] hw/ppc: Restrict KVM to various PPC machines

2021-02-21 Thread David Gibson
achine_init(MachineClass *mc) > mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("460exb"); > mc->default_ram_size = 512 * MiB; > mc->default_ram_id = "ppc4xx.sdram"; > +mc->valid_accelerators = valid_accels; > } > > DEFINE_MACHINE("sam460ex", sam

Re: [PATCH v2 3/7] device_tree: add qemu_fdt_setprop_string_array helper

2021-02-16 Thread David Gibson
trlen(array[i]) + 1; > +pstrcpy(p, len, array[i]); > +p += len; > +} > + > +ret = qemu_fdt_setprop(fdt, node_path, prop, str, total_len); > +g_free(str); > +return ret; > +} > + > const void *qemu_fdt_getprop(void *fdt, const char *nod

Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument

2021-01-11 Thread David Gibson
On Mon, Jan 11, 2021 at 04:20:20PM +0100, Philippe Mathieu-Daudé wrote: > The 'running' argument from VMChangeStateHandler does not require > other value than 0 / 1. Make it a plain boolean. > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > --- &g

Re: [PATCH 6/8] gitlab-ci: Add KVM PPC cross-build jobs

2020-12-06 Thread David Gibson
+++ > .gitlab-ci.yml | 1 + > MAINTAINERS | 1 + > 3 files changed, 7 insertions(+) > create mode 100644 .gitlab-ci.d/crossbuilds-kvm-ppc.yml Acked-by: David Gibson > diff --git a/.gitlab-ci.d/crossbuilds-kvm-ppc.yml > b/.gitlab-ci.d/

Re: [PATCH 5/5] hw: Use the PCI_DEVFN() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
config pointer */ > retval = (reg & (0xff - 7)) | (addr & 7); > -/* slot */ > -retval |= slot << 11; > -/* fn */ > -retval |= func << 8; > +/* slot, fn */ > +retval |= PCI_DEVFN(slot, func) << 8; >

Re: [PATCH 3/5] hw/pci-host/uninorth: Use the PCI_FUNC() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 02:45:04PM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We already have a generic PCI_FUNC() macro in "hw/pci/pci.h" to > extract the PCI function identifier, use it. > > Signed-off-by: Philippe Mathieu-Da

Re: [PATCH 2/5] hw/pci-host: Use the PCI_BUILD_BDF() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 02:45:03PM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We already have a generic PCI_BUILD_BDF() macro in "hw/pci/pci.h" > to pack these values, use it. > > Signed-off-by: Philippe Mathieu-Daudé pnv part Acked-by

Re: [PATCH 4/5] hw: Use the PCI_SLOT() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 02:45:05PM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We already have a generic PCI_SLOT() macro in "hw/pci/pci.h" > to extract the PCI slot identifier, use it. > > Signed-off-by: Philippe Mathieu-Daudé ppc

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-07 Thread David Gibson
by doing a `git diff -w` after the change. > > This could probably be turned into a pre-commit hook. > > Signed-off-by: Christophe de Dinechin ppc parts Acked-by: David Gibson > --- > block/iscsi.c | 2 +- > disas/cris.c

Re: [PATCH-for-5.1 1/3] target: Remove unnecessary CPU() cast

2020-04-13 Thread David Gibson
edef CPUState; > CPUState *s; > @@ > - CPU(s) > + s > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > target/ppc/mmu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/ppc/mmu_helper.c

Re: [PATCH-for-5.1 3/3] hw: Remove unnecessary DEVICE() cast

2020-04-13 Thread David Gibson
atch with this script: > > @@ > typedef DeviceState; > DeviceState *s; > @@ > - DEVICE(s) > + s > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > --- > hw/display/artist.c | 2 +- > hw/display/cg3.c| 2 +-

Re: [Xen-devel] [PATCH v3 19/20] Let cpu_[physical]_memory() calls pass a boolean 'is_write' argument

2020-02-20 Thread David Gibson
On Thu, Feb 20, 2020 at 02:05:47PM +0100, Philippe Mathieu-Daudé wrote: > Use an explicit boolean type. > > This commit was produced with the included Coccinelle script > scripts/coccinelle/exec_rw_const. > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acke

Re: [Xen-devel] [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE

2019-08-16 Thread David Gibson
. > > Then if a big endian target plan to use this device, it will require > more work and you might have introduced regressions... Uh.. only if they make the version of the device on a big endian target big endian. Which is a terrible idea - if you know a hardware designer planning to do this, p

Re: [Xen-devel] [PATCH v3 15/25] spapr-vty: Let vty_putchars() use size_t

2019-02-19 Thread David Gibson
On Wed, Feb 20, 2019 at 02:02:22AM +0100, Philippe Mathieu-Daudé wrote: > Both callers (h_put_term_char and rtas_display_character) use > an unsigned value. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > hw/char/spapr_vty.c| 2 +-

Re: [Xen-devel] [PATCH 1/3] spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro

2019-01-07 Thread David Gibson
On Mon, Jan 07, 2019 at 05:30:18PM -0200, Eduardo Habkost wrote: > The macro is only used in one place, where the purpose of the > value is obvious. Eliminate the macro so we don't need to rely > on stringify(). > > Signed-off-by: Eduardo Habkost Acked-by: David Gibson >

Re: [Xen-devel] [PATCH 2/2] avoid TABs in files that only contain a few

2018-12-13 Thread David Gibson
s/check_addc.c > tests/tcg/cris/check_addcm.c > tests/tcg/cris/check_addoq.c > tests/tcg/cris/check_bound.c > tests/tcg/cris/check_ftag.c > tests/tcg/cris/check_int64.c > tests/tcg/cris/check_lz.c > tests/tcg/cris/check_openpf5.c > tests/tcg/cris/c