Re: Virtio on Xen with Rust

2022-04-14 Thread Doug Goldstein
> On Apr 14, 2022, at 9:10 AM, Wei Liu wrote: > > On Thu, Apr 14, 2022 at 02:36:12PM +0100, Alex Bennée wrote: >> >> Wei Liu writes: >> >>> On Thu, Apr 14, 2022 at 12:07:10PM +, Andrew Cooper wrote: On 14/04/2022 12:45, Wei Liu wrote: > Hi Viresh > > This is very

Re: [PATCH for-4.15] automation: allow doing hypervisor only builds

2021-03-11 Thread Doug Goldstein
--- Acked-by: Doug Goldstein

Re: [PATCH] kconfig: ensure strndup() declaration is visible

2021-01-18 Thread Doug Goldstein
ls/kconfig/parser.y +++ b/xen/tools/kconfig/parser.y @@ -4,6 +4,7 @@ */ %{ +#define _GNU_SOURCE #include #include #include Ack-by: Doug Goldstein OpenPGP_0xE15EE761499A935E.asc Description: application/pgp-keys OpenPGP_signature Description: OpenPGP digital signature

Re: [PATCH] ci: drop building on CentOS 6

2020-11-18 Thread Doug Goldstein
On 11/18/20 10:39 AM, Andrew Cooper wrote: > On 18/11/2020 16:27, Doug Goldstein wrote: >> CentOS 6 is no longer supported by upstream so we cannot test against it >> for future Xen releases. >> >> Signed-off-by: Doug Goldstein >> --- >> CC: Andrew C

Re: [PATCH v1 2/4] automation/: add Ubuntu:focal container

2020-11-18 Thread Doug Goldstein
On 11/17/20 12:24 PM, Edwin Török wrote: > Signed-off-by: Edwin Török Looks good. Do you have permissions to push the container or do you need me to? Acked-by: Doug Goldstein

Re: [PATCH v1 1/4] automation/scripts/containerize: fix DOCKER_CMD=podman

2020-11-18 Thread Doug Goldstein
> > Signed-off-by: Edwin Török Looks reasonable. Acked-by: Doug Goldstein

[PATCH] ci: drop building on CentOS 6

2020-11-18 Thread Doug Goldstein
CentOS 6 is no longer supported by upstream so we cannot test against it for future Xen releases. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Julien Grall CC: Stefano Stabellini CC: Wei Liu --- automation/gitlab-ci/build.yaml

Re: [Xen-devel] [PATCH] automation: document vsyscall=emulate for old glibc

2020-03-03 Thread Doug Goldstein
On 2/25/20 6:10 AM, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Doug Goldstein Do I need to make this tweak on the current runners? pEpkey.asc Description: application/pgp-keys ___ Xen-devel mailing list Xen-devel@lists.xenproject.org ht

Re: [Xen-devel] [XEN PATCH 1/3] automation: Only build QEMU if Python >= 3.5

2020-01-24 Thread Doug Goldstein
On 1/20/20 5:50 AM, Anthony PERARD wrote: Recent version of QEMU will not build anymore if Python < 3.5. That is, QEMU 4.3 not released yet. That check would also prevent the GitLab CI from building QEMU if python3 binary isn't present. Signed-off-by: Anthony PERARD Acked-by: D

Re: [Xen-devel] [XEN PATCH 2/3] automation: updating container to have python3-config binary

2020-01-24 Thread Doug Goldstein
-arm64v8 haven't been changed. Signed-off-by: Anthony PERARD Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-12 Thread Doug Goldstein
On 1/11/20 3:02 AM, George Dunlap wrote: On Jan 11, 2020, at 4:02 AM, Doug Goldstein wrote: On 1/10/20 4:37 AM, Sergey Dyasli wrote: Hide the following information that can help identify the running Xen binary version: XENVER_extraversion, XENVER_compile_info, XENVER_changeset. Add

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-10 Thread Doug Goldstein
On 1/10/20 4:37 AM, Sergey Dyasli wrote: Hide the following information that can help identify the running Xen binary version: XENVER_extraversion, XENVER_compile_info, XENVER_changeset. Add explicit cases for XENVER_commandline and XENVER_build_id as well. Introduce xsm_filter_denied() to

Re: [Xen-devel] [PATCH v2] xsm: hide detailed Xen version from unprivileged guests

2020-01-10 Thread Doug Goldstein
On 1/10/20 9:28 AM, George Dunlap wrote: On 1/10/20 11:02 AM, Andrew Cooper wrote: On 10/01/2020 10:37, Sergey Dyasli wrote: Hide the following information that can help identify the running Xen binary version: XENVER_extraversion, XENVER_compile_info, XENVER_changeset. Add explicit cases

Re: [Xen-devel] [PATCH v2 0/2] x86: clank build check adjustments

2019-11-30 Thread Doug Goldstein
On 11/15/19 8:45 AM, Roger Pau Monné wrote: On Fri, Nov 15, 2019 at 11:43:21AM +0100, Jan Beulich wrote: 1: fix clang .macro retention check 2: clang: move and fix .skip check For both: Tested-by: Roger Pau Monné [On FreeBSD and Debian 9.5] Reviewed-by: Roger Pau Monné Note there's a typo

Re: [Xen-devel] [PATCH V2] kdd.c: Add support for initial handshake in KD protocol for Win 7, 8 and 10 (64 bit)

2019-11-29 Thread Doug Goldstein
On 11/13/19 10:55 PM, Julian Tuminaro wrote: From: Julian Tuminaro and Jenish Rakholiya Current implementation of find_os is based on the hard-coded values for different Windows version. It uses the value for get the address to start looking for DOS header in the given specified range.

[Xen-devel] current staging x86 hypervisor build fails with clang

2019-11-25 Thread Doug Goldstein
Hello, The following build failure happens when using clang to build the hypervisor. This is a default config. make -f /builds/xen-project/xen/xen/Rules.mk /builds/xen-project/xen/xen/.xen.efi.0r.o /builds/xen-project/xen/xen/.xen.efi.0s.o grep -v 'DEFINE_XEN_GUEST_HANDLE(long)' public/nmi.h

Re: [Xen-devel] Status of 4.13

2019-11-25 Thread Doug Goldstein
On 11/21/19 12:05 AM, Jürgen Groß wrote: Where do we stand with Xen 4.13 regarding blockers and related patches? 1. Currently the default "make install" fails with errors in tools/tests/x86_emulator if you don't have a new enough GCC. Causing failures on distros that are considered still

Re: [Xen-devel] tools/tests/x86_emulator causes build failures with older but supported compilers

2019-11-25 Thread Doug Goldstein
On 11/25/19 4:44 AM, Jan Beulich wrote: On 23.11.2019 19:00, Doug Goldstein wrote: Per README, GCC 4.1.2 should lead to a successful default "make install" per INSTALL. Currently this is failing due to tools/tests/x86_emulator being in the default path and requiring a compiler wit

[Xen-devel] tools/tests/x86_emulator causes build failures with older but supported compilers

2019-11-23 Thread Doug Goldstein
Hello, Per README, GCC 4.1.2 should lead to a successful default "make install" per INSTALL. Currently this is failing due to tools/tests/x86_emulator being in the default path and requiring a compiler with AVX. GCC 4.4.7 on CentOS 6 does not have this leading to a failure to build. 1265

Re: [Xen-devel] [PATCH 2/3] automation: add openSUSE Tumbleweed CI image

2019-08-03 Thread Doug Goldstein
., periodically), even if the docker file does not change. Signed-off-by: Dario Faggioli Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/3] automation: build in openSUSE Tumbleweed

2019-08-03 Thread Doug Goldstein
On 7/31/19 11:58 AM, Dario Faggioli wrote: Signed-off-by: Dario Faggioli Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/3] automation: try to keep openSUSE Leap image a little smaller

2019-08-03 Thread Doug Goldstein
`). Signed-off-by: Dario Faggioli Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] automation: add info about container pushes

2019-08-03 Thread Doug Goldstein
To be able to push a container, users must have access and have logged into the container registry. The docs did not explain this fully so this documents the steps better. Signed-off-by: Doug Goldstein --- automation/build/README.md | 6 +- 1 file changed, 5 insertions(+), 1 deletion

Re: [Xen-devel] [PATCH] ci: install C++ in opensuse-leap CI container

2019-08-03 Thread Doug Goldstein
On 8/2/19 9:37 AM, Dario Faggioli wrote: On Fri, 2019-08-02 at 13:11 +0100, Andrew Cooper wrote: On 02/08/2019 13:00, Dario Faggioli wrote: On Mon, 2019-07-29 at 12:18 -0500, Doug Goldstein wrote: Will you be pushing the rebuilt container or do you need me to do that? So, I guess someone

Re: [Xen-devel] [PATCH] ci: install C++ in opensuse-leap CI container

2019-07-29 Thread Doug Goldstein
On 7/26/19 5:03 AM, Dario Faggioli wrote: The openSUSE Leap container image, built after opensuse-leap.dockerfile was missing the gcc-c++, which is necessary, e.g., for building OVMF. Add it. Signed-off-by: Dario Faggioli --- Cc: Doug Goldstein --- Acked-by: Doug Goldstein Will you

Re: [Xen-devel] Criteria / validation proposal: drop Xen

2019-07-11 Thread Doug Goldstein
On 7/8/19 11:11 AM, Adam Williamson wrote: On Tue, 2019-05-21 at 11:14 -0700, Adam Williamson wrote: "The release must boot successfully as Xen DomU with releases providing a functional, supported Xen Dom0 and widely used cloud providers utilizing Xen." and change the 'milestone' for the test

[Xen-devel] XSA-300 Wording

2019-07-10 Thread Doug Goldstein
Could we look at updating the wording of XSA-300 to make things a bit more clear. I don't have exact wording suggestions but roughly some of the questions I've fielded are: 1. Impact should make it clear there are two issues here. So its really "and/or". Or a bulleted list. 2. Vulnerable

Re: [Xen-devel] [PATCH] xen/Kconfig: Fix -Wformat-security when compiling with Clang

2019-06-26 Thread Doug Goldstein
fig code base that we were bringing into the tree and some of the functionality that seemed less than necessary. The approach was taken to always backport from Linux to ease the maintenance burden for Xen but a backport like this seems like it achieves both goals. Acked-by: Doug Goldstein _

Re: [Xen-devel] [PATCH] automation: Fix CI with the fedora container

2019-06-11 Thread Doug Goldstein
ich is blocking all CI activity. > > Switch from latest to an explicit version, to avoid future breakage. > > Signed-off-by: Andrew Cooper Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://l

Re: [Xen-devel] [PATCH v4] automation: add clang and lld 8 tests to gitlab

2019-06-10 Thread Doug Goldstein
gt; > Also add some jobs to test building Xen with clang 8 and lld. > > Signed-off-by: Roger Pau Monné > Acked-by: Andrew Cooper Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproje

Re: [Xen-devel] [PATCH] gitlab-ci: allow specifying base and tip in build test

2019-05-14 Thread Doug Goldstein
. I apologize. Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] gitlab-ci: avoid deleting build-each-commit-gcc.log

2019-05-09 Thread Doug Goldstein
On Tue, May 07, 2019 at 05:11:01PM +0100, Wei Liu wrote: > 072a96c4901 used `git clean -ffdx` which caused the log to be deleted. > > Generate the log in the parent directory then move it back. > > Signed-off-by: Wei Liu Acked-by:

Re: [Xen-devel] Xen project CI systems and committer workflow

2019-04-18 Thread Doug Goldstein
On Thu, Apr 18, 2019 at 02:59:17PM +0100, Andrew Cooper wrote: > On 18/04/2019 13:31, Wei Liu wrote: > > Hi all > > > > We now have Gitlab CI as a complementary system to Osstest and have planned > > to > > add bots. It's high time we think about how we integrate them and how it may > > improve

Re: [Xen-devel] Xen project CI systems and committer workflow

2019-04-18 Thread Doug Goldstein
On Thu, Apr 18, 2019 at 02:21:44PM +0100, Ian Jackson wrote: > > > Gitlab CI doesn't have a self pushgate. If it is broken by accident Osstest > > will be blocked. > > Could we plan some kind of procedural or robotic workaround ? So my thoughts around this are on priority values. Admittedly it

Re: [Xen-devel] Xen project CI systems and committer workflow

2019-04-18 Thread Doug Goldstein
On Thu, Apr 18, 2019 at 01:32:52PM +0100, Wei Liu wrote: > Cc Anthony as well. Forgot to do that. Sorry. > > On Thu, Apr 18, 2019 at 01:31:59PM +0100, Wei Liu wrote: > > Hi all > > > > We now have Gitlab CI as a complementary system to Osstest and have planned > > to > > add bots. It's high

Re: [Xen-devel] [PATCH 3/3] gitlab-ci: add fedora gcc build jobs

2019-04-04 Thread Doug Goldstein
On Thu, Apr 04, 2019 at 12:23:02PM +0100, Wei Liu wrote: > Although the image comes with clang, clang builds don't work yet. > > Signed-off-by: Wei Liu Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.

Re: [Xen-devel] [PATCH v2] automation: Add Arch Linux container and build jobs

2019-04-03 Thread Doug Goldstein
> On Apr 3, 2019, at 12:33 PM, Anthony PERARD wrote: > > One particularity of Arch Linux, /usr/bin/python is python3. > > Signed-off-by: Anthony PERARD Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenpr

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2019-03-15 Thread Doug Goldstein
>>> On Mar 15, 2019, at 8:34 AM, Wei Liu wrote: >>> >>>> On Sat, Aug 25, 2018 at 10:01:38PM -0500, Doug Goldstein wrote: >>>>> On Fri, Aug 24, 2018 at 04:34:35PM +0100, Wei Liu wrote: >>>>> On Fri, Aug 24, 2018 at 10:32:24AM -0500, Do

Re: [Xen-devel] [PATCH] automation: skip test stage for some branches

2018-12-10 Thread Doug Goldstein
> On Dec 10, 2018, at 9:11 AM, Wei Liu wrote: > > We skipped build stage for those branches. We want to skip test state > for those branches too. > > Signed-off-by: Wei Liu Thanks for taking care of this. Acked-by: Doug Goldstein ___

Re: [Xen-devel] [PATCH 2/2] automation: break .gitlab-yaml into smaller files

2018-12-05 Thread Doug Goldstein
On Thu, Nov 22, 2018 at 03:49:03PM +, Wei Liu wrote: > Break out files for build jobs and test jobs. Keep the top level > .gitlab-ci.yaml small. > > Signed-off-by: Wei Liu Good idea with this split. Acked-by: Doug Goldstein _

Re: [Xen-devel] [PATCH 1/2] automation: add a qemu smoke test for clang build

2018-12-05 Thread Doug Goldstein
On Thu, Nov 22, 2018 at 03:49:02PM +, Wei Liu wrote: > Also rename the old test to have -gcc suffix. > > Signed-off-by: Wei Liu Acked-by: Doug Goldstein Nice addition. Sorry for the delay. ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH] automation: git clean between builds

2018-11-21 Thread Doug Goldstein
> On Nov 21, 2018, at 11:07 AM, Wei Liu wrote: > >> On Wed, Nov 21, 2018 at 10:51:55AM -0600, Doug Goldstein wrote: >> >>> On Nov 21, 2018, at 10:32 AM, Wei Liu wrote: >>> >>> Currently randconfig tests are more likely to fail than to succe

Re: [Xen-devel] [PATCH] automation: git clean between builds

2018-11-21 Thread Doug Goldstein
a fix for now to get us going. Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 4/4] automation: add qemu smoke test

2018-11-20 Thread Doug Goldstein
Do you want to capture this log in the artifacts below too? > + artifacts: > +paths: > + - smoke.serial > +when: always > + dependencies: > +- debian-stretch-gcc-debug > + tags: > +- x86_64 Just one quick question. If you do that can be fixed u

Re: [Xen-devel] [PATCH 3/4] automation: also specify xen binary as artifact on x86_64

2018-11-20 Thread Doug Goldstein
igned-off-by: Wei Liu Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 2/4] automation: stash default config file for artifact extraction

2018-11-20 Thread Doug Goldstein
ubleshooting when we notice a failure which makes sense. You could toss that into the commit message while committing it. Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/4] automation: introduce CONTAINER_NO_PULL for containerize

2018-11-20 Thread Doug Goldstein
O_PULL: If set to 1, the script will not pull from docker hub. > + This is useful when testing container locally. > + Good addition. Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] automation: fix debian-{stretch, unstable}-32-gcc-debug

2018-11-20 Thread Doug Goldstein
On Tue, Nov 20, 2018 at 02:10:02PM +, Wei Liu wrote: > They should have used .gcc-x86-32-build-debug in the first place. > > Signed-off-by: Wei Liu > --- > This patch is trivial so I intend to commit it as soon as possible to > fix Gitlab CI. Agreed. Acked-

Re: [Xen-devel] [PATCH 0/3] Assorted Gitlab CI improvements

2018-11-19 Thread Doug Goldstein
itlab-ci.yml | 309 > ++--- > 1 file changed, 162 insertions(+), 147 deletions(-) > > -- > 2.11.0 > Whole series looks great. I merged the changes to the Terraform configs as well. Acked-by: Doug Goldstein ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 0/2] automation: build in an openSUSE Leap container.

2018-11-16 Thread Doug Goldstein
> On Nov 16, 2018, at 3:41 PM, Dario Faggioli wrote: > >> On Fri, 2018-11-16 at 19:50 +0100, Dario Faggioli wrote: >>> On Fri, 2018-11-16 at 18:44 +, Wei Liu wrote: On Fri, Nov 16, 2018 at 07:30:55PM +0100, Dario Faggioli wrote: >>> I have been playing with the CI system today so

Re: [Xen-devel] [PATCH 0/3] automation: build Xen on Arm64

2018-11-13 Thread Doug Goldstein
> On Nov 7, 2018, at 6:31 AM, Wei Liu wrote: > > Hi all > > This is my first attempt to quickly get something useful for Arm in Gitlab CI > with a machine borrowed from Packet.NET Thanks for getting this done Wei! For the whole series: Acked-

Re: [Xen-devel] [PATCH 2/2] automation: build with Ubuntu 18.04

2018-11-08 Thread Doug Goldstein
> On Nov 8, 2018, at 12:09 PM, Wei Liu wrote: > >> On Mon, Oct 22, 2018 at 04:18:51PM +0100, Wei Liu wrote: >> Signed-off-by: Wei Liu > > I will commit these two patches without acks. They are a net benefit to > Xen -- I don't think that will be controversial. > > Wei. Sounds good to me.

Re: [Xen-devel] [PATCH] automation: build some customised configs

2018-11-05 Thread Doug Goldstein
configs we care about > +case ${XEN_TARGET_ARCH} in > +x86_64) arch=x86 ;; > +*) exit 0 ;; > +esac > + > +cfg_dir="automation/configs/${arch}" > +for cfg in `ls ${cfg_dir}`; do > +echo "Building $cfg" > +rm -f xen/.config >

Re: [Xen-devel] [PATCH 10/18] INSTALL: Mention kconfig

2018-10-08 Thread Doug Goldstein
On Mon, Oct 08, 2018 at 03:24:41PM +0100, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"): > > On 08.10.18 at 16:08, wrote: > > > Thanks, I'll take that as an ack. (Assuming you did indeed mean > > > `accepting' rather than `excepting'.) > > > > Well, no,

Re: [Xen-devel] [PATCH 17/17] automation: build Xen with CONFIG_PV and CONFIG_HVM explicitly set

2018-10-07 Thread Doug Goldstein
On Thu, Oct 04, 2018 at 04:43:36PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Looks good. Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 10/18] INSTALL: Mention kconfig

2018-10-07 Thread Doug Goldstein
On Fri, Oct 05, 2018 at 06:29:09PM +0100, Ian Jackson wrote: > Firstly, add a reference to the documentation for the kconfig system. > > Secondly, warn the user about the XEN_CONFIG_EXPERT problem. > > CC: Doug Goldstein > CC: Wei Liu > CC: Jan Beulich > CC: And

Re: [Xen-devel] [PATCH v2] automation: introduce a new variable to control container user

2018-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2018 at 03:19:31PM +0100, Wei Liu wrote: > Sometimes it is handy to create a container and play with its setup > manually as root. > > Signed-off-by: Wei Liu Acked-by: Doug Goldstein Thanks for the improvement! ___ Xen-d

Re: [Xen-devel] [PATCH] automation: introduce a new variable to control container user

2018-09-24 Thread Doug Goldstein
On Mon, Sep 24, 2018 at 05:18:29PM +0100, Wei Liu wrote: > Sometimes it is handy to create a container and play as root with its > setup manually. > > Signed-off-by: Wei Liu > --- > automation/scripts/containerize | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git

Re: [Xen-devel] [PATCH] automation: skip some branches in gitlab CI

2018-09-17 Thread Doug Goldstein
On Mon, Sep 17, 2018 at 09:33:41AM +0100, Wei Liu wrote: > Ignore branches which are always fast-forwarded to staging* branches. > List of filters taken from Travis CI setup. > > Signed-off-by: Wei Liu Acked-by: Doug Goldstein ___ Xen-d

Re: [Xen-devel] [PATCH] automation: specify -j$(nproc) in build script

2018-09-06 Thread Doug Goldstein
73..c463b060d4 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -30,4 +30,4 @@ fi > > ./configure "${cfgargs[@]}" > > -make dist > +make -j$(nproc) dist > -- > 2.11.0 > Acked-by: Doug Goldstein _

Re: [Xen-devel] [PATCH] build: remove tboot make targets

2018-08-27 Thread Doug Goldstein
On Mon, Aug 20, 2018 at 02:33:10AM -0600, Jan Beulich wrote: > >>> On 19.08.18 at 04:22, wrote: > > The tboot targets are woefully out of date. These should really be > > retired because setting up tboot is more complex than the build process > > for it. > >

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2018-08-25 Thread Doug Goldstein
On Fri, Aug 24, 2018 at 04:34:35PM +0100, Wei Liu wrote: > On Fri, Aug 24, 2018 at 10:32:24AM -0500, Doug Goldstein wrote: > > On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote: > > > Previously it is disabled because the embedded ipxe can't be built > > > with cl

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2018-08-24 Thread Doug Goldstein
On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote: > Previously it is disabled because the embedded ipxe can't be built > with clang. Now that ipxe is split out we can use --with-system-ipxe > to work around the issue. > > Signed-off-by: Wei Liu > --- > +# iPXE cannot be built with

Re: [Xen-devel] [PATCH] rombios: work around clang's -Waddress-of-packed-member

2018-08-24 Thread Doug Goldstein
f-packed-member] > ®s->u.r32.edx); >^~~ > > Work around that by using an intermediate variable. > > Signed-off-by: Wei Liu Reviewed-by: Doug Goldstein _

Re: [Xen-devel] [PATCH] tools: fix uninstall: tests/x86_emulator, Linux hotplug

2018-08-20 Thread Doug Goldstein
ug uninstall returns success but doesn't actually remove what > it installed. The Makefile variables are obfuscating incorrect logic, so > strip them out and match existing code for xen-watchdog which does work. > > Signed-off-by: Christopher Clark Reviewed-by: Doug Goldstein ___

[Xen-devel] [PATCH] build: remove tboot make targets

2018-08-18 Thread Doug Goldstein
The tboot targets are woefully out of date. These should really be retired because setting up tboot is more complex than the build process for it. Signed-off-by: Doug Goldstein --- Everyone knows my feeling about the Xen build system being a meta-distro builder. This just removes something

[Xen-devel] [PATCH v2 3/4] automation: remove dead code from containerize

2018-08-03 Thread Doug Goldstein
This is more dead code. Signed-off-by: Doug Goldstein Reviewed-by: Wei Liu --- automation/scripts/containerize | 5 - 1 file changed, 5 deletions(-) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 7f0eb0a..7bdfc21 100755 --- a/automation/scripts

[Xen-devel] [PATCH v2 0/4] This series improves the containerize script to hopefully make it more

2018-08-03 Thread Doug Goldstein
friendly for folks to use to locally do build tests under different distros. change from v1: - first patch switch to -z as it makes more sense Doug Goldstein (4): automation: standardize containerize env names automation: drop container name from containerize automation: remove dead code

[Xen-devel] [PATCH v2 2/4] automation: drop container name from containerize

2018-08-03 Thread Doug Goldstein
. Signed-off-by: Doug Goldstein Reviewed-by: Wei Liu --- automation/build/README.md | 5 - automation/scripts/containerize | 7 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index 987533a..bf11317 100644

[Xen-devel] [PATCH v2 1/4] automation: standardize containerize env names

2018-08-03 Thread Doug Goldstein
Standardized all the environment variable names that the containerize script uses to start with CONTAINER_ Signed-off-by: Doug Goldstein --- automation/build/README.md | 10 +- automation/scripts/containerize | 10 -- 2 files changed, 9 insertions(+), 11 deletions(-) diff

[Xen-devel] [PATCH v2 4/4] automation: ensure created are not owned as root

2018-08-03 Thread Doug Goldstein
outside of the container so files are not owned by root. Signed-off-by: Doug Goldstein Reviewed-by: Wei Liu --- automation/scripts/containerize | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 7bdfc21..bf9af58 100755

[Xen-devel] [PATCH 0/4] This series improves the containerize script to hopefully make it more

2018-07-30 Thread Doug Goldstein
friendly for folks to use to locally do build tests under different distros. Doug Goldstein (4): automation: standardize containerize env names automation: drop container name from containerize automation: remove dead code from containerize automation: ensure created are not owned as root

[Xen-devel] [PATCH 0/2] automation: CentOS 7.x container

2018-07-30 Thread Doug Goldstein
Add a CentOS 7.x container that tracks the latest CentOS 7 release along with the GitLab CI changes to build with it. A test run is available here: https://gitlab.com/cardoe/xen/pipelines/26695770 Doug Goldstein (2): automation: add CentOS 7.x image ci: enable builds with CentOS 7.x .gitlab

[Xen-devel] [PATCH 1/2] automation: add CentOS 7.x image

2018-07-29 Thread Doug Goldstein
This image will always track the latest CentOS 7.x release. Add this container to containerize for easy access. Signed-off-by: Doug Goldstein --- automation/build/centos/7.dockerfile | 49 +- automation/scripts/containerize | 1 +- 2 files changed, 50

[Xen-devel] [PATCH 2/2] ci: enable builds with CentOS 7.x

2018-07-29 Thread Doug Goldstein
Add the CentOS 7.x images to be used for build testing. Signed-off-by: Doug Goldstein --- .gitlab-ci.yml | 16 1 file changed, 16 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 1b9877b..6328da9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -39,6 +39,22

[Xen-devel] [PATCH 1/4] automation: standardize containerize env names

2018-07-28 Thread Doug Goldstein
Standardized all the environment variable names that the containerize script uses to start with CONTAINER_ Signed-off-by: Doug Goldstein --- automation/build/README.md | 10 +- automation/scripts/containerize | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff

[Xen-devel] [PATCH 4/4] automation: ensure created are not owned as root

2018-07-28 Thread Doug Goldstein
outside of the container so files are not owned by root. Signed-off-by: Doug Goldstein --- automation/scripts/containerize | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index d17f5ff..7d297d7 100755 --- a/automation/scripts

[Xen-devel] [PATCH 3/4] automation: remove dead code from containerize

2018-07-28 Thread Doug Goldstein
This is more dead code. Signed-off-by: Doug Goldstein --- automation/scripts/containerize | 5 - 1 file changed, 5 deletions(-) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 2cb8021..d17f5ff 100755 --- a/automation/scripts/containerize +++ b

[Xen-devel] [PATCH 2/4] automation: drop container name from containerize

2018-07-28 Thread Doug Goldstein
. Signed-off-by: Doug Goldstein --- automation/build/README.md | 5 - automation/scripts/containerize | 7 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index 987533a..bf11317 100644 --- a/automation/build/README.md

Re: [Xen-devel] [PATCH 2/2] automation: build with debian unstable

2018-07-25 Thread Doug Goldstein
On Mon, Jul 23, 2018 at 05:57:35PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu While this is good and provisionally I would say: Acked-by: Doug Goldstein I'd like us to hold off on committing this until other changes land to fix the build issues that are currently happening on Deb

Re: [Xen-devel] [PATCH 1/2] automation: add debian unstable images

2018-07-25 Thread Doug Goldstein
On Mon, Jul 23, 2018 at 05:57:34PM +0100, Wei Liu wrote: > This will get us the latest toolchain available in Debian. > > Signed-off-by: Wei Liu Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.

Re: [Xen-devel] [PATCH] automation: build with 32 bit stretch

2018-07-25 Thread Doug Goldstein
On Mon, Jul 23, 2018 at 09:04:46AM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v6] automation: introduce a script for build test

2018-07-25 Thread Doug Goldstein
ake -j4 maybe some comment in the code like "hey someone reading me this is the default command" Overall I think this is a good addition to the tree. If people feel different than I do about the default command then feel free to commit with my: Reviewed-by: Doug Goldstein -- Doug _

Re: [Xen-devel] [PATCH] xen: correct DEFCONFIG_LIST Kconfig item

2018-07-25 Thread Doug Goldstein
FCONFIG item, not the string "$ARCH_DEFCONFIG". > > > > Makse sense and matches Linux, but I'd still prefer to have Doug's > > consent here. > > Ping? > Apologies. I've checked and the patch is correct. Reviewed-by: Doug Goldstein _

Re: [Xen-devel] [PATCH] automation: introduce a script for build test

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 05:56:51PM +0100, Wei Liu wrote: > Signed-off-by: Ian Jackson > Signed-off-by: Wei Liu > --- > This is a script I wrote previously for build test. Goal here is to bisect a series to find the build failure? We could allow git bisect to do the work and just build and

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 04:04:05AM -0600, Jan Beulich wrote: > >>> On 24.07.18 at 11:43, wrote: > > On Tue, Jul 24, 2018 at 03:34:51AM -0600, Jan Beulich wrote: > >> >>> On 24.07.18 at 11:24, wrote: > >> > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> >> >>> On 23.07.18 at

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 03:32:09PM +0100, George Dunlap wrote: > On 07/24/2018 10:34 AM, Jan Beulich wrote: > On 24.07.18 at 11:24, wrote: > >> On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> On 23.07.18 at 18:40, wrote: > # How does this impact me? > The

Re: [Xen-devel] [PATCH] automation: enable building rombios with clang

2018-07-17 Thread Doug Goldstein
On Tue, Jul 17, 2018 at 09:39:35AM +0100, Wei Liu wrote: > Previously it is disabled because the embedded ipxe can't be built > with clang. Now that ipxe is split out we can use --with-system-ipxe > to work around the issue. > > Signed-off-by: Wei Liu > --- > Depends on the ipxe series just

Re: [Xen-devel] [PATCH] x86: report use of PCID together with reporting XPTI status

2018-07-17 Thread Doug Goldstein
t;with: %s" and do xpti_pcid_enabled ? "PCID" : "" if you do. If not then this seems like a good addition to me and is definitely welcome to folks wanting to know if they're using PCID. Reviewed-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] automation: add SLES 11 SP4 dockerfile

2018-07-17 Thread Doug Goldstein
On Tue, Jul 17, 2018 at 09:03:05PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Awesome work Wei. Thanks for taking the time and effort to get this done. I'll defer to Jan to confirm that this will hopefully be an effective stand in but you've got my Reviewed-by: Doug Goldst

Re: [Xen-devel] [PATCH] automation/build: update stretck-i386 dockerfile

2018-07-12 Thread Doug Goldstein
On Thu, Jul 12, 2018 at 02:33:42PM -0500, Doug Goldstein wrote: > On Thu, Jul 12, 2018 at 05:31:27PM +0100, Wei Liu wrote: > > We don't need to specify /bin/bash in the entry point rune, otherwise > > non-interactive invocation of the container would fail with something > &g

Re: [Xen-devel] [PATCH] automation/build: update stretck-i386 dockerfile

2018-07-12 Thread Doug Goldstein
is up to > date > *** Launching container ... > /usr/bin/git: /usr/bin/git: cannot execute binary file > > While at it, use shorthand "linux32". > > Signed-off-by: Wei Liu > --- Acked-by: Doug Goldstein ___ Xen-devel maili

Re: [Xen-devel] [PATCH] automation/build: build ovmf

2018-07-12 Thread Doug Goldstein
On Wed, Jul 11, 2018 at 02:16:16PM +0100, Wei Liu wrote: > Install nasm and build ovmf with gcc on x86. > > Signed-off-by: Wei Liu > --- Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xe

[Xen-devel] [PATCH] scripts: add helper script to use Docker containers

2018-07-12 Thread Doug Goldstein
within a Debian Stretch container at the top level of the source tree. Signed-off-by: Doug Goldstein --- A few folks have asked about this so I'm CCing folks directly. I'm completely game for changing anything that makes this easier for folks to use. This is primarily geared as a developer/maintainer

Re: [Xen-devel] [PATCH] automation: fix builds with clang

2018-07-10 Thread Doug Goldstein
On Tue, Jul 10, 2018 at 05:58:58PM -0500, Doug Goldstein wrote: Without this patch: https://gitlab.com/xen-project/xen/pipelines/25489605 With this patch: https://gitlab.com/cardoe/xen/pipelines/25512404 ___ Xen-devel mailing list Xen-devel

[Xen-devel] [PATCH] automation: fix builds with clang

2018-07-10 Thread Doug Goldstein
the build of the stubdoms depends on the build of newlib which does not support being built with clang. Signed-off-by: Doug Goldstein --- automation/scripts/build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/automation/scripts/build b/automation/scripts/build index b9e4c1e329

Re: [Xen-devel] [PATCH v2 4/4] automation: build more stuff on x86 with docker

2018-07-09 Thread Doug Goldstein
On Mon, Jul 09, 2018 at 04:32:16PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > Untested > --- Reviewed-by: Doug Goldstein I'll test this once we hammer out if we're pulling in texinfo or not. ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH v2 3/4] automation: introduce stretch-i386.dockerfile

2018-07-09 Thread Doug Goldstein
; +++ b/automation/build/debian/stretch-i386.dockerfile > +texinfo \ If https://lists.xenproject.org/archives/html/xen-devel/2018-07/msg00810.html gets accepted then we need to drop this. Otherwise looks good. Reviewed-by: Doug Goldstein ___

Re: [Xen-devel] [PATCH v2 1/4] automation: install texinfo

2018-07-09 Thread Doug Goldstein
On Mon, Jul 09, 2018 at 04:32:13PM +0100, Wei Liu wrote: > Stubdom's dependency newlib needs it. > > Signed-off-by: Wei Liu Could we consider <20180709170546.4102-1-car...@cardoe.com> instead? https://lists.xenproject.org/archives/html/xen-devel/2018-07/msg00810.html

[Xen-devel] [PATCH] stubdom: disable newlib's need for texinfo

2018-07-09 Thread Doug Goldstein
of something that's thrown away. Instead of adding it as a requirement this patches out the code path in newlib that uses it so that the files are never generated. Signed-off-by: Doug Goldstein --- stubdom/Makefile | 1 + stubdom/newlib-disable-texinfo.patch | 13 + 2

  1   2   3   >