Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"

2025-07-22 Thread Greg KH
On Tue, Jul 22, 2025 at 03:22:18PM +0800, WangYuli wrote: > Hi greg k-h, > > On 2025/7/16 16:08, Greg KH wrote: > > > Signed-off-by: WangYuli > > Is your name all one word like that, or should there be a " " between > > them? > > If I were to follo

Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"

2025-07-16 Thread Greg KH
On Tue, Jul 15, 2025 at 09:44:05PM +0800, WangYuli wrote: > There is a spelling mistake of 'notifer' in the comment which > should be 'notifier'. > > Link: > https://lore.kernel.org/all/b3c019b63c93846f+20250715071245.398846-1-wangy...@uniontech.com/ > Signed-off-by: WangYuli Is your name all o

Re: [PATCH] treewide: Fix typo "notifer"

2025-07-15 Thread Greg KH
On Tue, Jul 15, 2025 at 03:12:45PM +0800, WangYuli wrote: > There are some spelling mistakes of 'notifer' in comments which > should be 'notifier'. > > Fix them and add it to scripts/spelling.txt. > > Signed-off-by: WangYuli > --- > arch/x86/kvm/i8254.c|

Re: [PATCH 5.15.y 1/1] xen/swiotlb: relax alignment requirements

2025-04-07 Thread Greg KH
On Mon, Apr 07, 2025 at 12:02:35AM -0700, Harshvardhan Jha wrote: > [ Upstream commit 099606a7b2d53e99ce31af42894c1fc9d77c6db9] Wrong git id :(

Re: [6.1.y] Regression from b1e6e80a1b42 ("xen/swiotlb: add alignment check for dma buffers") when booting with Xen and mpt3sas_cm0 _scsih_probe failures

2025-03-01 Thread Greg KH
On Fri, Feb 28, 2025 at 01:50:12PM +0530, Harshvardhan Jha wrote: > > On 15/02/25 8:25 PM, Greg KH wrote: > > On Sat, Feb 15, 2025 at 02:39:46PM +0100, Jürgen Groß wrote: > >> On 15.02.25 13:34, Greg KH wrote: > >>> On Sat, Feb 15, 2025 at 12:47:57PM +0100, Jürg

Re: [6.1.y] Regression from b1e6e80a1b42 ("xen/swiotlb: add alignment check for dma buffers") when booting with Xen and mpt3sas_cm0 _scsih_probe failures

2025-02-15 Thread Greg KH
On Sat, Feb 15, 2025 at 02:39:46PM +0100, Jürgen Groß wrote: > On 15.02.25 13:34, Greg KH wrote: > > On Sat, Feb 15, 2025 at 12:47:57PM +0100, Jürgen Groß wrote: > > > On 12.02.25 16:12, Harshit Mogalapalli wrote: > > > > Hi Salvatore, > > > > > > &

Re: [6.1.y] Regression from b1e6e80a1b42 ("xen/swiotlb: add alignment check for dma buffers") when booting with Xen and mpt3sas_cm0 _scsih_probe failures

2025-02-15 Thread Greg KH
On Sat, Feb 15, 2025 at 12:47:57PM +0100, Jürgen Groß wrote: > On 12.02.25 16:12, Harshit Mogalapalli wrote: > > Hi Salvatore, > > > > On 12/02/25 00:56, Salvatore Bonaccorso wrote: > > > Hi Harshit, > > > > > > On Sun, Feb 09, 2025 at 01:45:38AM +0530, Harshit Mogalapalli wrote: > > > > Hi Salva

Re: v5.4.289 failed to boot with error megasas_build_io_fusion 3219 sge_count (-12) is out of range

2025-01-29 Thread Greg KH
On Wed, Jan 29, 2025 at 02:29:48PM +0530, Harshvardhan Jha wrote: > Hi Greg, > > On 29/01/25 2:18 PM, Greg KH wrote: > > On Wed, Jan 29, 2025 at 02:13:34PM +0530, Harshvardhan Jha wrote: > >> Hi there, > >> > >> On 29/01/25 2:05 PM, Greg KH wrote: >

Re: v5.4.289 failed to boot with error megasas_build_io_fusion 3219 sge_count (-12) is out of range

2025-01-29 Thread Greg KH
On Wed, Jan 29, 2025 at 02:13:34PM +0530, Harshvardhan Jha wrote: > Hi there, > > On 29/01/25 2:05 PM, Greg KH wrote: > > On Wed, Jan 29, 2025 at 02:03:51PM +0530, Harshvardhan Jha wrote: > >> Hi All, > >> > >> +stable > >> > >> There

Re: v5.4.289 failed to boot with error megasas_build_io_fusion 3219 sge_count (-12) is out of range

2025-01-29 Thread Greg KH
On Wed, Jan 29, 2025 at 02:03:51PM +0530, Harshvardhan Jha wrote: > Hi All, > > +stable > > There seems to be some formatting issues in my log output. I have > attached it as a file. Confused, what are you wanting us to do here in the stable tree? thanks, greg k-h

Re: [PATCH v2 1/1] lib: Remove dead code

2024-12-20 Thread Greg KH
On Fri, Dec 20, 2024 at 09:44:31AM +0100, Ariel Otilibili-Anieli wrote: > On Friday, December 20, 2024 08:09 CET, Greg KH > wrote: > > > On Thu, Dec 19, 2024 at 11:45:01PM +0100, Ariel Otilibili wrote: > > > This is a follow up from a discussion in Xen: > > >

Re: [PATCH v2 1/1] lib: Remove dead code

2024-12-19 Thread Greg KH
On Thu, Dec 19, 2024 at 11:45:01PM +0100, Ariel Otilibili wrote: > This is a follow up from a discussion in Xen: > > The if-statement tests `res` is non-zero; meaning the case zero is never > reached. > > Link: > https://lore.kernel.org/all/7587b503-b2ca-4476-8dc9-e9683d4ca...@suse.com/ > Fixes

Re: [PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-10 Thread Greg KH
On Tue, Sep 10, 2024 at 02:18:35PM +0200, Arthur Borsboom wrote: > On Tue, 10 Sept 2024 at 10:33, Greg KH wrote: > > > > On Tue, Sep 10, 2024 at 10:13:01AM +0200, Roger Pau Monné wrote: > > > On Tue, Sep 10, 2024 at 09:29:30AM +0200, Thomas Zimmermann wrote: > > >

Re: [PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-10 Thread Greg KH
On Tue, Sep 10, 2024 at 10:13:01AM +0200, Roger Pau Monné wrote: > On Tue, Sep 10, 2024 at 09:29:30AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 10.09.24 um 09:22 schrieb Roger Pau Monné: > > > On Mon, Sep 09, 2024 at 10:09:16PM -0400, Jason Andryuk wrote: > > > > From: Jason Andryuk > > >

Re: CVE-2021-47377: kernel: xen/balloon: use a kernel thread instead a workqueue

2024-05-28 Thread Greg KH
On Mon, May 27, 2024 at 12:58:16PM +0200, Juergen Gross wrote: > Hi, > > I'd like to dispute CVE-2021-47377: the issue fixed by upstream commit > 8480ed9c2bbd56fc86524998e5f2e3e22f5038f6 can in no way be triggered by > an unprivileged user or by a remote attack of the system, as it requires > init

Re: [PATCH net] xen-netfront: Add missing skb_mark_for_recycle

2024-05-08 Thread Greg KH
On Tue, May 07, 2024 at 02:57:08PM +0100, Andrew Cooper wrote: > Hello, > > Please could we request a CVE for "xen-netfront: Add missing > skb_mark_for_recycle" which is 037965402a010898d34f4e35327d22c0a95cd51f > in Linus' tree. > > This is a kernel memory leak trigger-able from unprivileged user

Re: CVE-2024-26908: x86/xen: Add some null pointer checking to smp.c

2024-04-30 Thread Greg KH
On Mon, Apr 29, 2024 at 01:53:44PM +0200, Juergen Gross wrote: > Hi, > > I'd like to dispute CVE-2024-26908: the issue fixed by upstream commit > 3693bb4465e6e32a204a5b86d3ec7e6b9f7e67c2 can in no way be triggered by > an unprivileged user or by a remote attack of the system, as it requires > hotp

Re: [PATCH net] xen-netfront: Add missing skb_mark_for_recycle

2024-04-25 Thread Greg KH
On Thu, Apr 25, 2024 at 02:39:38PM +0100, George Dunlap wrote: > Greg, > > We're issuing an XSA for this; can you issue a CVE? To ask for a cve, please contact c...@kernel.org as per our documentation. Please provide the git id of the commit you wish to have the cve assigned to. thanks, greg k

Re: [PATCH 5.10] xen/events: close evtchn after mapping cleanup

2024-03-04 Thread Greg KH
On Sat, Mar 02, 2024 at 08:03:57AM -0800, Andrew Panyakin wrote: > From: Maximilian Heyne > > Commit fa765c4b4aed2d64266b694520ecb025c862c5a9 upstream > > shutdown_pirq and startup_pirq are not taking the > irq_mapping_update_lock because they can't due to lock inversion. Both > are called with

Re: [PATCH -next] block: remove field 'bd_inode' from block_device

2023-11-25 Thread Greg KH
On Sat, Nov 25, 2023 at 05:39:12PM +0800, Yu Kuai wrote: > From: Yu Kuai > > block_devcie is allocated from bdev_alloc() by bdev_alloc_inode(), and > currently block_device contains a pointer that point to the address of > inode, while such inode is allocated together: > > bdev_alloc > inode =

Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control()

2023-08-08 Thread Greg KH
On Sun, Aug 06, 2023 at 11:15:51AM -0400, Alan Stern wrote: > On Sun, Aug 06, 2023 at 04:27:27PM +0200, Greg KH wrote: > > On Sun, Aug 06, 2023 at 10:11:43PM +0800, Zhang Shurong wrote: > > > 在 2023年7月1日星期六 CST 下午11:51:43,Zhang Shurong 写道: > > > > 在 2

Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control()

2023-08-06 Thread Greg KH
On Sun, Aug 06, 2023 at 10:11:43PM +0800, Zhang Shurong wrote: > 在 2023年7月1日星期六 CST 下午11:51:43,Zhang Shurong 写道: > > 在 2023年6月26日星期一 CST 下午1:52:02,您写道: > > > > > On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > > > > On 25.06.2023 18:42, Zhang Shurong wrote: > > > > > --- a/drivers/u

Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control()

2023-06-25 Thread Greg KH
On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > On 25.06.2023 18:42, Zhang Shurong wrote: > > --- a/drivers/usb/host/xen-hcd.c > > +++ b/drivers/usb/host/xen-hcd.c > > @@ -456,6 +456,8 @@ static int xenhcd_hub_control(struct usb_hcd *hcd, > > __u16 typeReq, __u16 wValue, > >

Re: [PATCH 2/6] macio: Make remove callback of macio driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:40PM +0800, Dawei Li wrote: > Commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This chan

Re: [PATCH 6/6] soundbus: make remove callback of soundbus driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:44PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > Thi

Re: [PATCH 5/6] ac97: make remove callback of ac97 driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:43PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > Thi

Re: [PATCH 4/6] xen: make remove callback of xen driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:42PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. Please

Re: [PATCH 0/6] Make remove() of any bus based driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:38PM +0800, Dawei Li wrote: > For bus-based driver, device removal is implemented as: > device_remove() => bus->remove() => driver->remove() > > Driver core needs no feedback from bus driver about the result of > remove callback. In which case, commit fc7a6209d571 ("b

Re: [PATCH for-stable-5.10.y] xen-blkfront: Cache feature_persistent value before advertisement

2022-09-08 Thread Greg KH
On Tue, Sep 06, 2022 at 04:24:14PM +, SeongJae Park wrote: > commit fe8f65b018effbf473f53af3538d0c1878b8b329 upstream. > > Xen blkfront advertises its support of the persistent grants feature > when it first setting up and when resuming in 'talk_to_blkback()'. > Then, blkback reads the adverti

Re: [PATCH v2 01/10] x86/mtrr: fix MTRR fixup on APs

2022-08-20 Thread Greg KH
On Sat, Aug 20, 2022 at 11:25:24AM +0200, Juergen Gross wrote: > When booting or resuming the system MTRR state is saved on the boot > processor and then this state is loaded into MTRRs of all other cpus. > During update of the MTRRs the MTRR mechanism needs to be disabled by > writing the related

Re: [PATCH 0/3] x86: make pat and mtrr independent from each other

2022-08-14 Thread Greg KH
On Sun, Aug 14, 2022 at 08:08:30AM -0400, Chuck Zmudzinski wrote: > On 8/14/2022 5:50 AM, Greg KH wrote: > > On Sun, Aug 14, 2022 at 05:19:12AM -0400, Chuck Zmudzinski wrote: > > > Well, that did not take long. Juergen responded with a message, > > > which is encryp

Re: [PATCH 0/3] x86: make pat and mtrr independent from each other

2022-08-14 Thread Greg KH
On Sun, Aug 14, 2022 at 05:19:12AM -0400, Chuck Zmudzinski wrote: > Well, that did not take long. Juergen responded with a message, > which is encrypted and not delivered to my mailbox because I do not > have the PGP keys, presumably to make it difficult for me to continue > the discussion and defe

Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR

2022-07-12 Thread Greg KH
On Tue, Jul 12, 2022 at 03:57:45PM -0400, Chuck Zmudzinski wrote: > On 7/12/22 3:26 PM, Greg KH wrote: > > On Tue, Jul 12, 2022 at 03:16:01PM -0400, Chuck Zmudzinski wrote: > > > On 7/12/22 2:36 PM, Greg KH wrote: > > > > On Tue, Jul 12, 2022 at 02:20:37PM

Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports

2022-07-12 Thread Greg KH
On Tue, Jul 12, 2022 at 03:19:39PM -0400, Boris Ostrovsky wrote: > > On 7/12/22 12:38 PM, Greg KH wrote: > > Hi all, > > > > I'm seeing the following build warning: > > arch/x86/kernel/head_64.o: warning: objtool: > > xen_hypercall_mmu_update(): c

Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR

2022-07-12 Thread Greg KH
On Tue, Jul 12, 2022 at 03:16:01PM -0400, Chuck Zmudzinski wrote: > On 7/12/22 2:36 PM, Greg KH wrote: > > On Tue, Jul 12, 2022 at 02:20:37PM -0400, Chuck Zmudzinski wrote: > > > The commit 99c13b8c8896d7bcb92753bf > > > ("x86/mm/pat: Don't rep

Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR

2022-07-12 Thread Greg KH
On Tue, Jul 12, 2022 at 02:20:37PM -0400, Chuck Zmudzinski wrote: > The commit 99c13b8c8896d7bcb92753bf > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > incorrectly failed to account for the case in init_cache_modes() when > CPUs do support PAT and falsely reported PAT to be disab

Build warnings in Xen 5.15.y and 5.10.y with retbleed backports

2022-07-12 Thread Greg KH
Hi all, I'm seeing the following build warning: arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update(): can't find starting instruction in the 5.15.y and 5.10.y retbleed backports. I don't know why just this one hypercall is being called out by objtool, and this warning

Re: gntdev warning fixes

2022-07-08 Thread Greg KH
On Fri, Jul 08, 2022 at 12:37:44PM -0400, Demi Marie Obenour wrote: > The recent gntdev fixes introduced two incorrect WARN_ON()s, which > triggered immediately on my system. Patches for master and all > supported stable versions follow. > > This is not the correct way to submit patches for i

Re: Hopefully correct backports for gntdev deadlock

2022-07-04 Thread Greg KH
On Mon, Jul 04, 2022 at 03:46:12PM +0200, Juergen Gross wrote: > On 01.07.22 02:09, Demi Marie Obenour wrote: > > This backports "xen/gntdev: Avoid blocking in unmap_grant_pages()" to > > the various stable trees, hopefully correctly. > > > > I have reviewed all backports and they seem correct to

Re: [PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-06-30 Thread Greg KH
On Thu, Jun 30, 2022 at 03:16:41PM +0200, Juergen Gross wrote: > On 30.06.22 13:34, Greg KH wrote: > > On Mon, Jun 27, 2022 at 02:10:02PM -0400, Demi Marie Obenour wrote: > > > commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream > > > > > > unmap_grant_p

Re: [PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-06-30 Thread Greg KH
On Mon, Jun 27, 2022 at 02:10:02PM -0400, Demi Marie Obenour wrote: > commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream > > unmap_grant_pages() currently waits for the pages to no longer be used. > In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a > deadlock against i91

Re: [PATCH 0/4] x86: decode Xen/KVM emulate prefixes

2022-05-12 Thread Greg KH
On Thu, May 12, 2022 at 01:56:47PM +, Maximilian Heyne wrote: > This is a backport of a patch series for 5.4.x. > > The patch series allows the x86 decoder to decode the Xen and KVM emulate > prefixes. > > In particular this solves the following issue that appeared when commit > db6c6a0df840

Re: [PATCH] xen/blkfront: fix bug in backported patch

2021-12-27 Thread Greg KH
On Thu, Dec 23, 2021 at 02:40:38PM +0100, Juergen Gross wrote: > On 23.12.21 11:57, Greg KH wrote: > > On Thu, Dec 23, 2021 at 11:53:08AM +0100, Juergen Gross wrote: > > > The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take local > > > copy of a r

Re: [PATCH] xen/blkfront: fix bug in backported patch

2021-12-23 Thread Greg KH
On Thu, Dec 23, 2021 at 11:53:08AM +0100, Juergen Gross wrote: > The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take local > copy of a request from the ring page") to stable 4.4 kernel introduced > a bug when adding the needed blkif_ring_get_request() function, as > info->ring.req_pro

Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description

2021-10-15 Thread Greg KH
On Fri, Oct 15, 2021 at 10:07:35AM +0200, Juergen Gross wrote: > On 13.10.21 14:01, Greg KH wrote: > > On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote: > > > Add the definition of pvUSB protocol used between the pvUSB frontend in > > > a Xen domU and the pv

Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description

2021-10-13 Thread Greg KH
On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote: > Add the definition of pvUSB protocol used between the pvUSB frontend in > a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0). > > This header was originally provided by Fujitsu for Xen based on Linux > 2.6.18. >

Re: [PATCH V4 05/13] hyperv: Add Write/Read MSR registers via ghcb page

2021-08-27 Thread Greg KH
On Fri, Aug 27, 2021 at 01:21:03PM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > Hyperv provides GHCB protocol to write Synthetic Interrupt > Controller MSR registers in Isolation VM with AMD SEV SNP > and these registers are emulated by hypervisor directly. > Hyperv requires to write SINTx MSR

Re: [PATCH V4 04/13] hyperv: Mark vmbus ring buffer visible to host in Isolation VM

2021-08-27 Thread Greg KH
On Fri, Aug 27, 2021 at 01:21:02PM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > Mark vmbus ring buffer visible with set_memory_decrypted() when > establish gpadl handle. > > Signed-off-by: Tianyu Lan > --- > Change since v3: >* Change vmbus_teardown_gpadl() parameter and put gpadl ha

Re: [PATCH] xen/events: fix setting irq affinity

2021-04-15 Thread Greg KH
On Mon, Apr 12, 2021 at 08:28:45AM +0200, Juergen Gross wrote: > The backport of upstream patch 25da4618af240fbec61 ("xen/events: don't > unmask an event channel when an eoi is pending") introduced a > regression for stable kernels 5.10 and older: setting IRQ affinity for > IRQs related to interdom

Re: [PATCH for <= 5.4] xen/privcmd: allow fetching resource sizes

2021-01-29 Thread Greg KH
On Tue, Jan 26, 2021 at 05:22:59PM +, Andrew Cooper wrote: > On 20/01/2021 11:03, Greg KH wrote: > > On Mon, Jan 18, 2021 at 03:04:26PM +0100, Roger Pau Monne wrote: > >> commit ef3a575baf53571dc405ee4028e26f50856898e7 upstream > >> > >> Allow issuing an IO

Re: [PATCH for <= 5.4] xen/privcmd: allow fetching resource sizes

2021-01-20 Thread Greg KH
On Mon, Jan 18, 2021 at 03:04:26PM +0100, Roger Pau Monne wrote: > commit ef3a575baf53571dc405ee4028e26f50856898e7 upstream > > Allow issuing an IOCTL_PRIVCMD_MMAP_RESOURCE ioctl with num = 0 and > addr = 0 in order to fetch the size of a specific resource. > > Add a shortcut to the default map r

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 01:36:22PM +0100, Roger Pau Monné wrote: > Forgot to Cc stable for the Fixes tag. Doing it now. This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 12:51:26PM +0100, Christoph Hellwig wrote: > On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > > @@ -413,6 +413,7 @@ struct dev_links_info { > > > * @dm

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-05 Thread Greg KH
On Wed, Jan 06, 2021 at 11:41:20AM +0800, Claire Chang wrote: > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes in the device tree. > > Signed-off-by: Claire Chang > --- > include/linux/device.h | 4 ++ > include/linux/swiotlb.h | 7 +- >

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 10:23:51AM +0100, Jan Beulich wrote: > On 18.11.2020 10:09, Greg KH wrote: > > On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > >> On 18.11.2020 09:58, Christoph Hellwig wrote: > >>> On Wed, Nov 18, 2020 at 09:56:11AM +0100, J

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 09:47:40AM +0100, Christoph Hellwig wrote: > Hi Jens, > > this series cleans up our main per-device node data structure by merging > the block_device and hd_struct data structures that have the same scope, > but different life times. The main effect (besides removing lots

Re: [PATCH 19/20] bcache: remove a superflous lookup_bdev all

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote: > On 11/18/20 4:47 PM, Christoph Hellwig wrote: > > Don't bother to call lookup_bdev for just a slightly different error > > message without any functional change. > > > > Signed-off-by: Christoph Hellwig ist > > Hi Christoph, > > NACK. Th

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > On 18.11.2020 09:58, Christoph Hellwig wrote: > > On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: > >> since this isn't the first series from you recently spamming > >> xen-devel, may I ask that you don't Cc entire series t

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Greg KH
On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting >

Re: [PATCH] xen: don't reschedule in preemption off sections

2020-08-24 Thread Greg KH
On Thu, Aug 20, 2020 at 08:59:08AM +0200, Juergen Gross wrote: > For support of long running hypercalls xen_maybe_preempt_hcall() is > calling cond_resched() in case a hypercall marked as preemptible has > been interrupted. > > Normally this is no problem, as only hypercalls done via some ioctl()s

Re: [Xen-devel] [PATCH STABLE 4.9] x86, mm, gup: prevent get_page() race with munmap in paravirt guest

2019-08-05 Thread Greg KH
On Fri, Aug 02, 2019 at 06:06:14PM +0200, Vlastimil Babka wrote: > The x86 version of get_user_pages_fast() relies on disabled interrupts to > synchronize gup_pte_range() between gup_get_pte(ptep); and get_page() against > a parallel munmap. The munmap side nulls the pte, then flushes TLBs, then >

Re: [Xen-devel] [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 03:10:55PM +0200, Juergen Gross wrote: > On 03/06/2019 14:02, Ben Hutchings wrote: > > On Mon, 2019-06-03 at 10:00 +0200, Greg KH wrote: > >> On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote: > >>> On 5/30/19 8:16 AM, B

Re: [Xen-devel] [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.

2019-06-03 Thread Greg KH
On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote: > On 5/30/19 8:16 AM, Ben Hutchings wrote: > > I'm looking at CVE-2015-8553 which is fixed by: > > > > commit 7681f31ec9cdacab4fd10570be924f2cef6669ba > > Author: Konrad Rzeszutek Wilk > > Date:   Wed Feb 13 18:21:31 2019 -050

Re: [Xen-devel] Linux 3.18 no longer boots under Xen, Xen CI dropping it

2019-05-29 Thread Greg KH
On Wed, May 29, 2019 at 10:06:00AM -0600, Jan Beulich wrote: > >>> On 29.05.19 at 17:57, wrote: > > Linux 3.18 no longer boots under Xen. > > > > This has been true for over half a year. The Xen project CI has been > > sending automatic mails including bisection reports (see below). > > I emaile

Re: [Xen-devel] [PATCH v4.9 1/1] jiffies: use jiffies64_to_nsecs() to fix 100% steal usage for xen vcpu hotplug

2019-03-12 Thread Greg KH
On Wed, Mar 06, 2019 at 03:35:40PM +0800, Dongli Zhang wrote: > Thanks to Joe Jin's reminding, this patch is applicable to mainline linux > kernel, although there is no issue due to this kind of bug in mainline kernel. > > Therefore, can I first submit this patch to mainline kernel and then backpo

Re: [Xen-devel] [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-24 Thread Greg KH
On Thu, Jan 24, 2019 at 07:55:51AM +1300, Kees Cook wrote: > On Thu, Jan 24, 2019 at 4:44 AM Jani Nikula > wrote: > > > > On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > > > On Wed, 23 Jan 2019, Jani Nikula wrote: > > >> On Wed, 23 Jan 2019, Greg KH wrote:

Re: [Xen-devel] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > Variables declared in a switch statement before any case statements > cannot be initialized, so move all instances out of the switches. > After this, future always-initialized stack variables will work > and not throw warnings like this:

Re: [Xen-devel] Linux 4.19.5 fails to boot as Xen dom0

2019-01-11 Thread Greg KH
On Fri, Jan 11, 2019 at 08:59:52AM +0100, Juergen Gross wrote: > On 22/12/2018 12:14, Juergen Gross wrote: > > On 06/12/2018 12:46, Greg KH wrote: > >> On Thu, Dec 06, 2018 at 12:31:15PM +0100, Juergen Gross wrote: > >>> On 06/12/2018 12:13, Greg KH wrote: > >&g

Re: [Xen-devel] Linux 4.19.5 fails to boot as Xen dom0

2018-12-06 Thread Greg KH
On Thu, Dec 06, 2018 at 12:31:15PM +0100, Juergen Gross wrote: > On 06/12/2018 12:13, Greg KH wrote: > > On Thu, Nov 29, 2018 at 02:35:17PM +0100, Juergen Gross wrote: > >> On 29/11/2018 14:26, Kirill A. Shutemov wrote: > >>> On Thu, Nov 29, 2018 at 09:41:25AM +,

Re: [Xen-devel] Linux 4.19.5 fails to boot as Xen dom0

2018-12-06 Thread Greg KH
On Thu, Nov 29, 2018 at 02:35:17PM +0100, Juergen Gross wrote: > On 29/11/2018 14:26, Kirill A. Shutemov wrote: > > On Thu, Nov 29, 2018 at 09:41:25AM +, Juergen Gross wrote: > >> On 29/11/2018 02:22, Hans van Kranenburg wrote: > >>> Hi, > >>> > >>> As also seen at: > >>> https://bugs.debian.or

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with blkfront_remove()

2018-11-09 Thread Greg KH
On Thu, Nov 08, 2018 at 04:58:28PM -0800, Manjunath Patil wrote: > If a hot-attaching device fails inside domU[ex:negotiate_mq() returns > with ENOMEM] we clear the blkfront_info struct in talk_to_blkback() > > When we try to detach the device, blkfront_remove() tries to access > blkfront_info lea

Re: [Xen-devel] [GIT PULL] xen: fixes for 4.19-rc5

2018-09-23 Thread Greg KH
On Sun, Sep 23, 2018 at 09:55:38AM +0200, Juergen Gross wrote: > Linus/Greg, > > Please git pull the following tag: > > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-4.19d-rc5-tag > > xen: fixes for 4.19-rc5 > > It contains two small fixes for xen drivers. Noe pulled,

Re: [Xen-devel] [PATCH] xen-swiotlb: use actually allocated size on check physical contiguous

2018-09-04 Thread Greg KH
On Tue, Sep 04, 2018 at 11:16:58AM -0700, Joe Jin wrote: > xen_swiotlb_{alloc,free}_coherent() actually allocate/free size by order > but used the required size to check if address is physical contiguous, > if first pages are physical contiguous also passed > range_straddles_page_boundary() check,

Re: [Xen-devel] [PATCH v2] x86/entry/64: Remove %ebx handling from error_entry/exit

2018-08-22 Thread Greg KH
On Tue, Aug 21, 2018 at 06:42:56PM -0700, Andy Lutomirski wrote: > On Thu, Aug 16, 2018 at 9:19 PM, Sarah Newman wrote: > > commit b3681dd548d06deb2e1573890829dff4b15abf46 upstream. > > > > This version applies to v4.9. > > ... > > Looks okay to me. Thanks for the review, and Sarah, thanks for

Re: [Xen-devel] [PATCH] x86/entry/64: Remove %ebx handling from error_entry/exit

2018-08-16 Thread Greg KH
On Fri, Aug 10, 2018 at 12:23:45AM -0700, Sarah Newman wrote: > On 08/09/2018 05:41 AM, David Woodhouse wrote: > > On Wed, 2018-08-08 at 10:35 -0700, Sarah Newman wrote: > >> commit b3681dd548d06deb2e1573890829dff4b15abf46 upstream. > >> > >> This version applies to v4.9. > > > > I think you can k

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-08-07 Thread Greg KH
On Tue, Aug 07, 2018 at 12:08:07PM -0700, Srivatsa S. Bhat wrote: > Also, upstream commit e01e80634ecdde1 (fork: unconditionally clear > stack on fork) applies cleanly on 4.14 stable, so it would be great to > cherry-pick it to 4.14 stable as well. It is already in the 4.14.60 release, did I someh

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-08-07 Thread Greg KH
On Fri, Aug 03, 2018 at 04:20:31PM -0700, Srivatsa S. Bhat wrote: > On 8/2/18 3:22 PM, Kees Cook wrote: > > On Thu, Aug 2, 2018 at 12:22 PM, Srivatsa S. Bhat > > wrote: > >> On 7/26/18 4:09 PM, Kees Cook wrote: > >>> On Tue, Jul 24, 2018 at 3:02 PM, Jiri Kosina wrote: > On Tue, 24 Jul 2018,

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-07-23 Thread Greg KH
On Sat, Jul 14, 2018 at 02:25:43AM -0700, Srivatsa S. Bhat wrote: > Hi Greg, > > This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) > and patches for the Speculative Store Bypass vulnerability to 4.4.y > (they apply cleanly on top of 4.4.140). > > I used 4.9.y as my reference whe

Re: [Xen-devel] [PATCH] x86/entry/64: Remove %ebx handling from error_entry/exit

2018-07-23 Thread Greg KH
On Sun, Jul 22, 2018 at 11:05:09AM -0700, Andy Lutomirski wrote: > error_entry and error_exit communicate the user vs kernel status of > the frame using %ebx. This is unnecessary -- the information is in > regs->cs. Just use regs->cs. > > This makes error_entry simpler and makes error_exit more

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-07-15 Thread Greg KH
On Sat, Jul 14, 2018 at 02:25:43AM -0700, Srivatsa S. Bhat wrote: > Hi Greg, > > This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) > and patches for the Speculative Store Bypass vulnerability to 4.4.y > (they apply cleanly on top of 4.4.140). > > I used 4.9.y as my reference whe

Re: [Xen-devel] [PATCH 0/3] Correct 4.9 stable commit 944e0fc51a89c98

2018-06-02 Thread Greg KH
On Wed, May 30, 2018 at 01:09:55PM +0200, Juergen Gross wrote: > Above commit is a wrong backport, as it is based on a missing > prerequisite patch. Correct that by reverting said commit, include the > missing patch, and do the backport correctly. > > Juergen Gross (3): > x86/amd: revert commit

Re: [Xen-devel] [PATCH] xen: fix pv domain on amd in 4.9 stable branch

2018-05-30 Thread Greg KH
On Wed, May 30, 2018 at 11:33:22AM +0200, Juergen Gross wrote: > On 30/05/18 10:33, Greg KH wrote: > > On Tue, May 29, 2018 at 03:11:36PM +0200, Juergen Gross wrote: > >> Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: don't set > >> X86_BUG_S

Re: [Xen-devel] [PATCH] xen: fix pv domain on amd in 4.9 stable branch

2018-05-30 Thread Greg KH
On Tue, May 29, 2018 at 03:11:36PM +0200, Juergen Gross wrote: > Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: don't set > X86_BUG_SYSRET_SS_ATTRS when running under Xen") breaks Xen pv-domains > on AMD processors, as a prerequisite patch from upstream wasn't added > to 4.9. What is t

Re: [Xen-devel] [PATCH UPSTREAM] xen-swiotlb: fix the check condition for xen_swiotlb_free_coherent

2018-05-17 Thread Greg KH
On Thu, May 17, 2018 at 11:45:57AM -0700, Joe Jin wrote: > When run raidconfig from Dom0 we found that the Xen DMA heap is reduced, > but Dom Heap is increased by the same size. Tracing raidconfig we found > that the related ioctl() in megaraid_sas will call dma_alloc_coherent() > to apply memory.

Re: [Xen-devel] Patch "x86/xen: Add pvh specific rsdp address retrieval function" has been added to the 4.16-stable tree

2018-05-02 Thread Greg KH
On Wed, May 02, 2018 at 11:23:12AM +0200, Juergen Gross wrote: > On 02/05/18 00:33, gre...@linuxfoundation.org wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > x86/xen: Add pvh specific rsdp address retrieval function > > > > to the 4.16-stable tree

Re: [Xen-devel] Patches for stable

2018-04-05 Thread Greg KH
On Thu, Apr 05, 2018 at 09:02:27AM +0200, Juergen Gross wrote: > On 05/04/18 08:33, Greg KH wrote: > > On Wed, Apr 04, 2018 at 06:32:17PM +0200, Juergen Gross wrote: > >> On 04/04/18 17:42, Greg KH wrote: > >>> On Wed, Apr 04, 2018 at 05:12:32PM +0200, Juergen Gross w

Re: [Xen-devel] Patches for stable

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 06:32:17PM +0200, Juergen Gross wrote: > On 04/04/18 17:42, Greg KH wrote: > > On Wed, Apr 04, 2018 at 05:12:32PM +0200, Juergen Gross wrote: > >> On 04/04/18 16:46, Greg KH wrote: > >>> On Wed, Apr 04, 2018 at 04:30:30PM +0200, Juergen Gross w

Re: [Xen-devel] Patches for stable

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 05:12:32PM +0200, Juergen Gross wrote: > On 04/04/18 16:46, Greg KH wrote: > > On Wed, Apr 04, 2018 at 04:30:30PM +0200, Juergen Gross wrote: > >> On 04/04/18 16:27, Greg KH wrote: > >>> On Wed, Apr 04, 2018 at 12:38:43PM +0200, Juergen Gros

Re: [Xen-devel] Patches for stable

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 04:30:30PM +0200, Juergen Gross wrote: > On 04/04/18 16:27, Greg KH wrote: > > On Wed, Apr 04, 2018 at 12:38:43PM +0200, Juergen Gross wrote: > >> Please add the patches: > >> > >> commit 038bac2b02989acf1fc938ced

Re: [Xen-devel] Patches for stable

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 12:38:43PM +0200, Juergen Gross wrote: > Please add the patches: > > commit 038bac2b02989acf1fc938cedcb7944c02672b9f upstream > commit dfc9327ab7c99bc13e12106448615efba833886b upstream > commit b17d9d1df3c33a4f1d2bf397e2257aecf9dc56d4 upstream > > to the 4.15 and 4.16 stab

Re: [Xen-devel] [PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

2018-01-25 Thread Greg KH
On Thu, Jan 25, 2018 at 01:06:26PM +0100, Juergen Gross wrote: > On 25/01/18 12:00, Greg KH wrote: > > On Thu, Jan 25, 2018 at 11:49:35AM +0100, Juergen Gross wrote: > >> On 25/01/18 11:37, Greg KH wrote: > >>> On Thu, Jan 25, 2018 at 11:04:54AM +0100, J

Re: [Xen-devel] [PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

2018-01-25 Thread Greg KH
On Thu, Jan 25, 2018 at 11:49:35AM +0100, Juergen Gross wrote: > On 25/01/18 11:37, Greg KH wrote: > > On Thu, Jan 25, 2018 at 11:04:54AM +0100, Juergen Gross wrote: > >> Add acpi_arch_get_root_pointer() for Xen PVH guests to communicate > >> the address of the RSDP ta

Re: [Xen-devel] [PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

2018-01-25 Thread Greg KH
On Thu, Jan 25, 2018 at 11:04:54AM +0100, Juergen Gross wrote: > Add acpi_arch_get_root_pointer() for Xen PVH guests to communicate > the address of the RSDP table given to the kernel via Xen start info. > > This makes the kernel boot again in PVH mode after on recent Xen the > RSDP was moved to h