Re: [PATCH v4 1/2] acpi: Make TPM version configurable.

2023-05-05 Thread Jennifer Herbert
On 05/05/2023 07:34, Jan Beulich wrote: On 04.05.2023 19:51, Jennifer Herbert wrote: This patch makes the TPM version, for which the ACPI library probes, configurable. If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. I have also added to hvmloader

[PATCH v4 1/2] acpi: Make TPM version configurable.

2023-05-04 Thread Jennifer Herbert
/tpm_verion xenstore key. Signed-off-by: Jennifer Herbert Reviewed-by: Jason Andryuk --- CC: Jan Beulich CC: Andrew Cooper CC: Roger Pau Monné CC: Jason Andryuk v4: * Omit tpm_version 0 case, to fallback to 1.2, previously intended for compatibility for unknown code. * Add checks for xenstore

[PATCH v4 2/2] acpi: Add TPM2 interface definition.

2023-05-04 Thread Jennifer Herbert
This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert Reviewed-by: Jason Andryuk Acked-by: Jan Beulich --- CC: Jan Beulich CC: Andrew Cooper CC: Roger Pau Monné CC: Jason

[PATCH v4 0/2] acpi: Make TPM version configurable.

2023-05-04 Thread Jennifer Herbert
tpm_version field. * Convert copyright header to SPDX * Minor code style fixes. Jennifer Herbert (2): acpi: Make TPM version configurable. acpi: Add TPM2 interface definition. docs/misc/xenstore-paths.pandoc | 10 +++ tools/firmware/hvmloader/util.c | 39 +--- tools/libacpi/Makefile

Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-05-02 Thread Jennifer Herbert
On 02/05/2023 14:41, Jan Beulich wrote: On 25.04.2023 19:47, Jennifer Herbert wrote: --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -121,6 +121,36 @@ struct acpi_20_tcpa { }; #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) +/* + * TPM2 + */ Nit: While I'm willing to accept

Re: [PATCH v3 1/2] acpi: Make TPM version configurable.

2023-05-02 Thread Jennifer Herbert
On 02/05/2023 12:54, Jan Beulich wrote: On 25.04.2023 19:47, Jennifer Herbert wrote: This patch makes the TPM version, for which the ACPI libary probes, configurable. If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. I have also added to hvmloader

Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-04-27 Thread Jennifer Herbert
On 26/04/2023 21:29, Jason Andryuk wrote: On Tue, Apr 25, 2023 at 1:48 PM Jennifer Herbert wrote: This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert --- ... diff --git

Re: [PATCH v3 1/2] acpi: Make TPM version configurable.

2023-04-27 Thread Jennifer Herbert
On 26/04/2023 21:27, Jason Andryuk wrote: Hi, Jennifer, On Tue, Apr 25, 2023 at 1:48 PM Jennifer Herbert wrote: This patch makes the TPM version, for which the ACPI libary probes, configurable. If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. I have

[PATCH v3 1/2] acpi: Make TPM version configurable.

2023-04-25 Thread Jennifer Herbert
/tpm_version xenstore key. Signed-off-by: Jennifer Herbert --- docs/misc/xenstore-paths.pandoc | 9 + tools/firmware/hvmloader/util.c | 19 ++--- tools/libacpi/build.c | 69 +++-- tools/libacpi/libacpi.h | 3 +- 4 files changed, 64 insertions

[PATCH v3 0/2] acpi: Make TPM version configurable.

2023-04-25 Thread Jennifer Herbert
. Jennifer Herbert (2): acpi: Make TPM version configurable. acpi: Add TPM2 interface definition. docs/misc/xenstore-paths.pandoc | 10 +++ tools/firmware/hvmloader/util.c | 28 +++-- tools/libacpi/Makefile | 3 +- tools/libacpi/acpi2_0.h | 32 ++ tools/libacpi

[PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-04-25 Thread Jennifer Herbert
This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert --- docs/misc/xenstore-paths.pandoc | 3 ++- tools/firmware/hvmloader/util.c | 9 tools/libacpi/Makefile

[PATCH v2 2/2] acpi: Add TPM2 interface definition.

2022-12-15 Thread Jennifer Herbert
This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert --- tools/firmware/hvmloader/config.h | 1 + tools/firmware/hvmloader/util.c | 7 ++ tools/libacpi/Makefile

[PATCH v2 1/2] acpi: Make TPM version configurable.

2022-12-15 Thread Jennifer Herbert
/tpm_verion xenstore key. Signed-off-by: Jennifer Herbert --- docs/misc/xenstore-paths.pandoc | 8 tools/firmware/hvmloader/util.c | 13 ++- tools/libacpi/build.c | 68 ++--- tools/libacpi/libacpi.h | 4 +- 4 files changed, 59 insertions(+), 34

[PATCH v2 0/2] acpi: Make TPM version configurable.

2022-12-15 Thread Jennifer Herbert
This patch makes the TPM version, for which the ACPI library probes, configurable. This version incorpates feedback from v1, including splitting it into two patches, tidying up some formatting, removing debug, and moving the log into a more suitable memory area. Jennifer Herbert (2): acpi

RE: [PATCH 2/2] acpi: Add TPM2 interface definition.

2022-10-11 Thread Jennifer Herbert
Hi, Are any further changes needed to upstream this patch series? Cheers, -jenny -Original Message- From: Jennifer Herbert Sent: 15 September 2022 21:40 To: jbeul...@suse.com; Andrew Cooper ; w...@xen.org; Roger Pau Monne Cc: xen-devel@lists.xenproject.org; Jennifer Herbert

[PATCH 1/2] acpi: Make TPM version configurable.

2022-09-15 Thread Jennifer Herbert
/tpm_verion xenstore key. Signed-off-by: Jennifer Herbert --- docs/misc/xenstore-paths.pandoc | 8 tools/firmware/hvmloader/util.c | 13 ++- tools/libacpi/build.c | 68 ++--- tools/libacpi/libacpi.h | 4 +- 4 files changed, 59 insertions(+), 34

[PATCH 2/2] acpi: Add TPM2 interface definition.

2022-09-15 Thread Jennifer Herbert
This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert --- tools/firmware/hvmloader/config.h | 1 + tools/firmware/hvmloader/util.c | 7 ++ tools/libacpi/Makefile

[PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable.

2022-08-30 Thread Jennifer Herbert
added to hvmloader an option to utilise this new config, which can be triggered by setting the platform/tpm_verion xenstore key. Signed-off-by: Jennifer Herbert --- tools/firmware/hvmloader/config.h | 1 + tools/firmware/hvmloader/util.c | 15 +++- tools/libacpi/Makefile| 2

Re: [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e

2019-11-14 Thread Jennifer Herbert
the moment we try to use an SR-IOV VF in a VM. Reported-by: Jennifer Herbert Signed-off-by: Andrew Cooper Tested-by: Jennifer Herbert This fixes the fatal page fault I found, which wasn't seen on 4.11. Cheers, -Jenny ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH] xen/pv: Add PV specific legacy_pic struct to expose legacy IRQs.

2019-03-25 Thread Jennifer Herbert
On 21/03/19 17:49, Jennifer Herbert wrote: On 19/03/19 23:06, Boris Ostrovsky wrote: On 3/19/19 4:02 PM, Jennifer Herbert wrote: The ACPI tables doesn't always contain all IRQs for legacy devices such as RTC. Since no PIC controller is visible for a PV linux guest, under Xen, legacy_pic

Re: [Xen-devel] [PATCH] xen/pv: Add PV specific legacy_pic struct to expose legacy IRQs.

2019-03-21 Thread Jennifer Herbert
On 19/03/19 23:06, Boris Ostrovsky wrote: On 3/19/19 4:02 PM, Jennifer Herbert wrote: The ACPI tables doesn't always contain all IRQs for legacy devices such as RTC. Since no PIC controller is visible for a PV linux guest, under Xen, legacy_pic currently defaults to the null_legacy_pic

[Xen-devel] [PATCH] xen/pv: Add PV specific legacy_pic struct to expose legacy IRQs.

2019-03-19 Thread Jennifer Herbert
pic except that it reports NR_IRQS_LEGACY irqs. Signed-off-by: Jennifer Herbert --- arch/x86/xen/enlighten_pv.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index c54a493..7644bdf 100644 --- a/ar

Re: [Xen-devel] Legacy PIC (x86) support (RTC) in dom0 with Linux 4.12 and newer is broken for some hardware.

2018-12-05 Thread Jennifer Herbert
CC: Juergen Gross On 04/12/18 17:24, Jennifer Herbert wrote: Since Linux 4.12, there has been a commita1e23a42f1bdc00e32fc4869caef12e4e6272f26 “rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs” The commit effectively disabled requesting IRQ 8 for systems without PIC

[Xen-devel] Legacy PIC (x86) support (RTC) in dom0 with Linux 4.12 and newer is broken for some hardware.

2018-12-04 Thread Jennifer Herbert
Since Linux 4.12, there has been a commit a1e23a42f1bdc00e32fc4869caef12e4e6272f26 "rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs" The commit effectively disabled requesting IRQ 8 for systems without PIC controller present (As in the case when used at dom0 under Xen)