Re: [PATCH] autogen.sh: Restore --no-git (avoid git submodule update)

2020-06-03 Thread Pavel Hrdina
me "$0") > test -n "$srcdir" || srcdir=. > > @@ -13,7 +18,11 @@ cd "$srcdir" > exit 1 > } > > -git submodule update --init || exit 1 > +if [ "x$1" = x--no-git ]; then > + shift > +else > + git submodule update --init || exit 1 I changed the TAB into spaces. > +fi > > autoreconf --verbose --force --install || exit 1 Reviewed-by: Pavel Hrdina and pushed. signature.asc Description: PGP signature

Re: [PATCH] autogen.sh: Restore --no-git (avoid git submodule update)

2020-06-03 Thread Pavel Hrdina
On Wed, Jun 03, 2020 at 11:37:08AM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 03, 2020 at 12:31:09PM +0200, Pavel Hrdina wrote: > > On Tue, Jun 02, 2020 at 04:47:45PM +0100, Ian Jackson wrote: > > > Prior to 2621d48f005a "gnulib: delete all gnulib integration

Re: [PATCH] autogen.sh: Restore --no-git (avoid git submodule update)

2020-06-03 Thread Pavel Hrdina
On Tue, Jun 02, 2020 at 04:47:45PM +0100, Ian Jackson wrote: > Prior to 2621d48f005a "gnulib: delete all gnulib integration", > one could pass ./autogen.sh --no-git to prevent the libvirt build > system from running git submodule update. > > This feature is needed by systems like the Xen Project