warnings that
reported by kernel test robot. Add the documentation to fix it.
Fixes: 2e85d32b1c86 ("xen/xenbus: Add 'will_handle' callback support in
xenbus_watch_path()")
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202401121154.fi8jdgu
' parameter when
connect")
Cc: # 5.10.x
Reported-by: Marek Marczykowski-Górecki
Signed-off-by: SeongJae Park
Tested-by: Marek Marczykowski-Górecki
Reviewed-by: Juergen Gross
Link: https://lore.kernel.org/r/20220831165824.94815-4...@kernel.org
Signed-off-by: Juergen Gross
---
This
On Wed, 31 Aug 2022 16:58:21 + SeongJae Park wrote:
> Changes from v1
> (https://lore.kernel.org/xen-devel/20220825161511.94922-1...@kernel.org/)
> - Fix the wrong feature_persistent caching position of blkfront
> - Set blkfront's feature_persistent field setting with simple
that the persistent grants feature becomes always disabled.
This commit fixes the issue by making the blkfront does parmeter caching
just before the advertisement.
Fixes: 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter when
connect")
Cc: # 5.10.x
Reported-by:
commit fixes the misuse of the semantic by making blkfront saves
the parameter value in a separate place and advertises the support based
on only the saved value.
Fixes: 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent
grants")
Cc: # 5.10.x
Suggested-by: Jue
This patchset fixes misuse of the 'feature-persistent' advertisement
semantic (patches 1 and 2), and the wrong timing of the
'feature_persistent' value caching, which made persistent grants feature
always disabled.
SeongJae Park (3):
xen-blkback: Advertise feature-persistent as user r
commit fixes the misuse of the semantic by making blkback saves the
parameter value in a separate place and advertises the support based on
only the saved value.
Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent
grants")
Cc: # 5.10.x
Suggested-by: Jue
Hi Pratyush,
On Wed, 31 Aug 2022 15:50:45 + Pratyush Yadav wrote:
> On 25/08/22 04:15PM, SeongJae Park wrote:
> > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter
> > when connect") made blkback to advertise its support of the persis
Hi Pratyush,
On Wed, 31 Aug 2022 15:47:50 + Pratyush Yadav wrote:
> Hi,
>
> On 25/08/22 04:15PM, SeongJae Park wrote:
> > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter
> > when connect") made blkback to advertise its sup
On Fri, 26 Aug 2022 21:20:39 + SeongJae Park wrote:
> Hi Max,
>
> On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote:
>
> > On Thu, Aug 25, 2022 at 04:15:11PM +0000, SeongJae Park wrote:
> > >
> > > Commit e94c6101e151 ("xen-blkback: Apply
On Fri, 26 Aug 2022 21:20:39 + SeongJae Park wrote:
> Hi Max,
>
> On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote:
>
> > On Thu, Aug 25, 2022 at 04:15:11PM +0000, SeongJae Park wrote:
> > >
> > > Commit e94c6101e151 ("xen-blkback: Apply
Hi Max,
On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote:
> On Thu, Aug 25, 2022 at 04:15:11PM +0000, SeongJae Park wrote:
> >
> > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter
> > when connect") made blkback t
Hi Juergen,
Thank you for the quick and nice reply!
On Thu, 25 Aug 2022 08:20:33 +0200 Juergen Gross wrote:
>
[...]
>
> Could you please send it as two proper patches (one for each driver) with
> the correct "Fixes:" tags?
Sure, just posted:
https://lore.kernel.org/xen-devel/20220825161511.
's support of
the feature.
[1]
https://lore.kernel.org/xen-devel/bd818aba-4857-bc07-dc8a-e9b2f8c5f...@suse.com/
SeongJae Park (2):
xen-blkback: Advertise feature-persistent as user requested
xen-blkfront: Advertise feature-persistent as user requested
drivers/block/xen-blkback/common.h
pport of the feature.
[1]
https://lore.kernel.org/xen-devel/bd818aba-4857-bc07-dc8a-e9b2f8c5f...@suse.com/
Fixes: 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter when
connect")
Cc: # 5.10.x
Reported-by: Marek Marczykowski-Górecki
Suggested-by: Juergen Gross
Signed-
feature.
[1]
https://lore.kernel.org/xen-devel/bd818aba-4857-bc07-dc8a-e9b2f8c5f...@suse.com/
Fixes: e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter when
connect")
Cc: # 5.10.x
Reported-by: Marek Marczykowski-Górecki
Suggested-by: Juergen Gross
Si
+ Roger
On Wed, 24 Aug 2022 17:44:42 + SeongJae Park wrote:
> Hello,
>
> On Wed, 24 Aug 2022 08:02:40 +0200 Juergen Gross wrote:
>
> >
> > [-- Attachment #1.1.1: Type: text/plain, Size: 4312 bytes --]
> >
> > On 24.08.22 02:20, Marek Marczykowski-G
Hello,
On Wed, 24 Aug 2022 08:02:40 +0200 Juergen Gross wrote:
>
> [-- Attachment #1.1.1: Type: text/plain, Size: 4312 bytes --]
>
> On 24.08.22 02:20, Marek Marczykowski-Górecki wrote:
> > FWIW, I hit this issue twice already in this week CI run, while it never
> > happened before. The differ
-mhe...@amazon.de/)
- Avoid the behavioral change
(https://lore.kernel.org/xen-devel/20220121102309.27802-1...@kernel.org/)
- Rebase on latest xen/tip/linux-next
- Re-work by SeongJae Park
- Cc stable@
Maximilian Heyne (1):
xen-blkback: Apply 'feature_persistent' parameter when connect
g...@mail.gmail.com/
Fixes: 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent
grants")
Cc: # 5.10.x
Signed-off-by: SeongJae Park
---
Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +-
drivers/block/xen-blkfront.c| 4 +---
2 fil
y 'connect_ring()' later, this
should be called before 'connect_ring()' and therefore this should be
the right and safe place to do the caching.
Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent
grants")
Cc: # 5.10.x
Signed-off-by: Maximili
ct, so that the previous workflow can work again as expected.
[1]
https://lore.kernel.org/xen-devel/CAJwUmVB6H3iTs-C+U=v-pwJB7-_ZRHPxHzKRJZ22xEPW7z8a=g...@mail.gmail.com/
Reported-by: Andrii Chepurnyi
Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent
grants")
Hi all,
On Fri, 15 Jul 2022 18:12:26 + SeongJae Park wrote:
> Hi all,
>
> On Fri, 15 Jul 2022 17:55:19 + SeongJae Park wrote:
>
> > The first patch of this patchset fixes 'feature_persistent' parameter
> > handling in 'blkback' to respect
Hi all,
On Fri, 15 Jul 2022 17:55:19 + SeongJae Park wrote:
> The first patch of this patchset fixes 'feature_persistent' parameter
> handling in 'blkback' to respect the frontend's persistent grants
> support always. The fix makes a behavioral chang
dates the
document.
Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent
grants")
Cc: # 5.10.x
Signed-off-by: Maximilian Heyne
Signed-off-by: SeongJae Park
---
Documentation/ABI/testing/sysfs-driver-xen-blkback | 2 +-
drivers/block/xen-blkback/xenbus.c
el.org/xen-devel/20220106091013.126076-1-mhe...@amazon.de/)
- Avoid the behavioral change
(https://lore.kernel.org/xen-devel/20220121102309.27802-1...@kernel.org/)
- Rebase on latest xen/tip/linux-next
- Re-work by SeongJae Park
- Cc stable@
Maximilian Heyne (1):
xen, blkback: fix persist
any
confusion due to inconsistent behavior of same-named parameters.
Cc: # 5.10.x
Signed-off-by: SeongJae Park
---
Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +-
drivers/block/xen-blkfront.c| 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git
l.org/xen-devel/20220121102309.27802-1...@kernel.org/
Thanks,
SJ
>
> [1]
> https://lore.kernel.org/xen-devel/20220106091013.126076-1-mhe...@amazon.de/
> [2] https://lore.kernel.org/xen-devel/20220714224410.51147-1...@kernel.org/
>
> Best regards,
> Andrii
>
> On Fri, Jul
y 'connect_ring()' later, this
should be called before 'connect_ring()' and therefore this should be
the right and safe place to do the caching.
Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent
grants")
Cc: # 5.10.x
Signed-o
: SeongJae Park
Signed-off-by: Maximilian Heyne
Acked-by: Roger Pau Monné
---
Changes from v1
(https://lore.kernel.org/xen-devel/20220301144628.2858-1...@kernel.org/)
- Add Acked-by from Roger
Documentation/ABI/testing/sysfs-driver-xen-blkback | 4 ++--
Documentation/ABI/testing/sysfs-driver-xen
: SeongJae Park
Signed-off-by: Maximilian Heyne
---
Documentation/ABI/testing/sysfs-driver-xen-blkback | 4 ++--
Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback
b
On Tue, 11 Jan 2022 13:26:50 +0100 "Roger Pau Monné"
wrote:
> On Tue, Jan 11, 2022 at 11:50:32AM +, Durrant, Paul wrote:
> > On 11/01/2022 11:11, Roger Pau Monné wrote:
> > > On Thu, Jan 06, 2022 at 09:10:13AM +, Maximilian Heyne wrote:
> > > > Given dom0 supports persistent grants but t
From: SeongJae Park
On Thu, 6 Jan 2022 09:10:13 + Maximilian Heyne wrote:
> Given dom0 supports persistent grants but the guest does not.
> Then, when attaching a block device during runtime of the guest, dom0
> will enable persistent grants for this newly attached blo
From: SeongJae Park
On Tue, 24 Aug 2021 23:24:51 -0700 CGEL wrote:
> From: Jing Yangyang
>
> Use BUG_ON instead of a if condition followed by BUG.
>
> Generated by: scripts/coccinelle/misc/bugon.cocci
>
> Reported-by: Zeal Robot
> Signed-off-by: Jing Yangyang
Re
nsient issue.
>
> Signed-off-by: Roger Pau Monné
> ---
> Cc: Konrad Rzeszutek Wilk
> Cc: Jens Axboe
> Cc: Boris Ostrovsky
> Cc: SeongJae Park
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-bl...@vger.kernel.org
> Cc: J. Roeleveld
> Cc: Jürgen Groß
> -
On Wed, 23 Sep 2020 16:09:30 -0400 Konrad Rzeszutek Wilk
wrote:
> On Tue, Sep 22, 2020 at 09:01:25AM +0200, SeongJae Park wrote:
> > From: SeongJae Park
> >
> > Persistent grants feature provides high scalability. On some small
> > systems, however, it could incu
From: SeongJae Park
Persistent grants feature provides high scalability. On some small
systems, however, it could incur data copy overheads[1] and thus it is
required to be disabled. But, there is no option to disable it. For
the reason, this commit adds a module parameter for disabling of
From: SeongJae Park
Commit 14e710fe7897 ("xen-blkfront: rename indirect descriptor
parameter") changed the name of the module parameter for the maximum
amount of segments in indirect requests but missed updating the
document. This commit updates the document.
Signed-off-by: Seo
On Tue, 22 Sep 2020 16:44:25 +0200 "Roger Pau Monné"
wrote:
> On Tue, Sep 22, 2020 at 04:27:39PM +0200, Jürgen Groß wrote:
> > On 22.09.20 16:15, SeongJae Park wrote:
> > > From: SeongJae Park
> > >
> > > Commit 14e710fe7897 ("xen-blkfront: r
From: SeongJae Park
Persistent grants feature provides high scalability. On some small
systems, however, it could incur data copy overheads[1] and thus it is
required to be disabled. But, there is no option to disable it. For
the reason, this commit adds module parameters for disabling of the
On Tue, 22 Sep 2020 14:11:32 +0200 "Jürgen Groß" wrote:
> On 22.09.20 12:52, SeongJae Park wrote:
> > From: SeongJae Park
> >
> > Persistent grants feature provides high scalability. On some small
> > systems, however, it could incur data copy overheads
On Tue, 22 Sep 2020 13:35:30 +0200 "Jürgen Groß" wrote:
> On 22.09.20 13:26, SeongJae Park wrote:
> > On Tue, 22 Sep 2020 13:12:59 +0200 "Roger Pau Monné"
> > wrote:
> >
> >> On Tue, Sep 22, 2020 at 12:52:07PM +0200, SeongJae Park wrote:
On Tue, 22 Sep 2020 13:35:11 +0200 "Roger Pau Monné"
wrote:
> On Tue, Sep 22, 2020 at 01:26:38PM +0200, SeongJae Park wrote:
> > On Tue, 22 Sep 2020 13:12:59 +0200 "Roger Pau Monné"
> > wrote:
> >
> > > On Tue, Sep 22, 2020 at 12:52:07PM
On Tue, 22 Sep 2020 13:12:59 +0200 "Roger Pau Monné"
wrote:
> On Tue, Sep 22, 2020 at 12:52:07PM +0200, SeongJae Park wrote:
> > From: SeongJae Park
> >
> > Persistent grants feature provides high scalability. On some small
> > systems, however, it could
From: SeongJae Park
Persistent grants feature provides high scalability. On some small
systems, however, it could incur data copy overheads[1] and thus it is
required to be disabled. But, there is no option to disable it. For
the reason, this commit adds a module parameter for disabling of
From: SeongJae Park
Commit 14e710fe7897 ("xen-blkfront: rename indirect descriptor
parameter") changed the name of the module parameter for the maximum
amount of segments in indirect requests but missed updating the
document. This commit updates the document.
Signed-off-by: Seo
From: SeongJae Park
Persistent grants feature provides high scalability. On some small
systems, however, it could incur data copy overheads[1] and thus it is
required to be disabled. But, there is no option to disable it. For
the reason, this commit adds module parameters for disabling of the
On Mon, 13 Jan 2020 10:55:07 +0100 "Roger Pau Monné"
wrote:
> On Mon, Jan 13, 2020 at 10:49:52AM +0100, SeongJae Park wrote:
> > Every patch of this patchset got at least one 'Reviewed-by' or 'Acked-by'
> > from
> > appropriate maintainer
Every patch of this patchset got at least one 'Reviewed-by' or 'Acked-by' from
appropriate maintainers by last Wednesday, and after that, got no comment yet.
May I ask some more comments?
Thanks,
SeongJae Park
On Wed, 18 Dec 2019 19:37:13 +0100 SeongJae Park wrote:
>
Hello Roger,
Sorry if I'm disturbing your vacation. If you are already came back to work,
may I ask your opinion about this patch?
On Wed, 18 Dec 2019 19:37:16 +0100 SeongJae Park wrote:
> From: SeongJae Park
>
> Each `blkif` has a free pages pool for the grant mapping. The
From: SeongJae Park
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/xenbus.c | 7
From: SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it
is unnecessary for static variables. This commit removes such prefixes.
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/blkb
commit message for overhead test of the 2nd path
Changes from v8
(https://lore.kernel.org/xen-devel/20191213130211.24011-1-sjp...@amazon.de/)
- Drop 'Reviewed-by: Juergen' from the second patch
(suggested by Roger Pau Monné)
- Update contact of the new module param to SeongJae Park
From: SeongJae Park
Granting pages consumes backend system memory. In systems configured
with insufficient spare memory for those pages, it can cause a memory
pressure situation. However, finding the optimal amount of the spare
memory is challenging for large systems having dynamic resource
From: SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it
is unnecessary for static variables. This commit removes such prefixes.
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/blkb
From: SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of
the pool starts from zero and is increased on demand while processing
the I/O requests. If current I/O requests handling is finished or 100
milliseconds has passed since last I/O requests handling, it
From: SeongJae Park
A driver's 'reclaim_memory' callback can race with 'probe' or 'remove'
because it will be called whenever memory pressure is detected. To
avoid such race, this commit embeds a spinlock in each 'xenbus_device'
and make &#x
On Wed, 18 Dec 2019 16:11:51 +0100 "Jürgen Groß" wrote:
> On 18.12.19 15:40, SeongJae Park wrote:
> > On Wed, 18 Dec 2019 14:30:44 +0100 "Jürgen Groß" wrote:
> >
> >> On 18.12.19 13:42, SeongJae Park wrote:
> >>> On Wed, 18 Dec 2019 13:27
On Wed, 18 Dec 2019 14:30:44 +0100 "Jürgen Groß" wrote:
> On 18.12.19 13:42, SeongJae Park wrote:
> > On Wed, 18 Dec 2019 13:27:37 +0100 "Jürgen Groß" wrote:
> >
> >> On 18.12.19 11:42, SeongJae Park wrote:
> >>> From: SeongJae Park
>
On Wed, 18 Dec 2019 13:27:37 +0100 "Jürgen Groß" wrote:
> On 18.12.19 11:42, SeongJae Park wrote:
> > From: SeongJae Park
> >
> > 'reclaim_memory' callback can race with a driver code as this callback
> > will be called from any memory pressu
From: SeongJae Park
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/xenbus.c | 7
From: SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it
is unnecessary for static variables. This commit removes such prefixes.
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/blkb
From: SeongJae Park
'reclaim_memory' callback can race with a driver code as this callback
will be called from any memory pressure detected context. To deal with
the case, this commit adds a spinlock in the 'xenbus_device'. Whenever
'reclaim_memory' callback is
From: SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of
the pool starts from zero and is increased on demand while processing
the I/O requests. If current I/O requests handling is finished or 100
milliseconds has passed since last I/O requests handling, it
From: SeongJae Park
Granting pages consumes backend system memory. In systems configured
with insufficient spare memory for those pages, it can cause a memory
pressure situation. However, finding the optimal amount of the spare
memory is challenging for large systems having dynamic resource
ested by Roger Pau Monné)
- Update contact of the new module param to SeongJae Park
(suggested by Roger Pau Monné)
- Wordsmith the description of the parameter
(suggested by Roger Pau Monné)
- Fix dumb bugs
(suggested by Roger Pau Monné)
- Move module param definition to xenbus.c
On Tue, 17 Dec 2019 18:10:19 +0100 "Jürgen Groß" wrote:
> On 17.12.19 17:24, SeongJae Park wrote:
> > On Tue, 17 Dec 2019 17:13:42 +0100 "Jürgen Groß" wrote:
> >
> >> On 17.12.19 17:07, SeongJae Park wrote:
> >>> From: SeongJae Park
>
From: SeongJae Park
I though it would be better to review separated patches, but seems it
was my mistake. As Juergen asked, merged them again and post here.
Also, dropped Roger's reviewed-by.
Thanks,
SeongJae Park
--
On Tue, 17 Dec 2019 17:13:42 +0100 "Jürgen Groß" wrote:
> On 17.12.19 17:07, SeongJae Park wrote:
> > From: SeongJae Park
> >
> > 'reclaim_memory' callback can race with a driver code as this callback
> > will be called from any memory pressu
On Tue, 17 Dec 2019 09:30:32 +0100 SeongJae Park wrote:
> On Tue, 17 Dec 2019 09:16:47 +0100 "Jürgen Groß" wrote:
>
> > On 17.12.19 08:59, SeongJae Park wrote:
> > > On Tue, 17 Dec 2019 07:23:12 +0100 "Jürgen Groß" wrote:
> > >
> > >
From: SeongJae Park
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/xenbus.c | 7
From: SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it
is unnecessary for static variables. This commit removes such prefixes.
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/blkb
From: SeongJae Park
The 'reclaim_memory()' callback of blkback could race with
'xen_blkbk_probe()' and 'xen_blkbk_remove()'. In the case, incompletely
linked 'backend_info' and 'blkif' might be exposed to the callback, thus
result in bad resu
From: SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of
the pool starts from zero and is increased on demand while processing
the I/O requests. If current I/O requests handling is finished or 100
milliseconds has passed since last I/O requests handling, it
From: SeongJae Park
'reclaim_memory' callback can race with a driver code as this callback
will be called from any memory pressure detected context. To deal with
the case, this commit adds a spinlock in the 'xenbus_device'. Whenever
'reclaim_memory' callback is
of the 2nd path
Changes from v8
(https://lore.kernel.org/xen-devel/20191213130211.24011-1-sjp...@amazon.de/)
- Drop 'Reviewed-by: Juergen' from the second patch
(suggested by Roger Pau Monné)
- Update contact of the new module param to SeongJae Park
(suggested by Roger Pau Mo
From: SeongJae Park
Granting pages consumes backend system memory. In systems configured
with insufficient spare memory for those pages, it can cause a memory
pressure situation. However, finding the optimal amount of the spare
memory is challenging for large systems having dynamic resource
On Tue, 17 Dec 2019 12:39:15 +0100 "Roger Pau Monné"
wrote:
> On Mon, Dec 16, 2019 at 08:48:03PM +0100, SeongJae Park wrote:
> > On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote:
> >
> > > On 16.12.19 17:15, SeongJae Park wrote:
> > > > On
On Tue, 17 Dec 2019 09:16:47 +0100 "Jürgen Groß" wrote:
> On 17.12.19 08:59, SeongJae Park wrote:
> > On Tue, 17 Dec 2019 07:23:12 +0100 "Jürgen Groß" wrote:
> >
> >> On 16.12.19 20:48, SeongJae Park wrote:
> >>> On on, 16 Dec 2019 17:23:
On Tue, 17 Dec 2019 07:23:12 +0100 "Jürgen Groß" wrote:
> On 16.12.19 20:48, SeongJae Park wrote:
> > On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote:
> >
> >> On 16.12.19 17:15, SeongJae Park wrote:
> >>> On Mon, 16 Dec 2019 15:37:20 +0100 Se
On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote:
> On 16.12.19 17:15, SeongJae Park wrote:
> > On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park wrote:
> >
> >> On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park wrote:
> >>
> >>> From: SeongJae Pa
On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park wrote:
> On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park wrote:
>
> > From: SeongJae Park
> >
[...]
> > --- a/drivers/block/xen-blkback/xenbus.c
> > +++ b/drivers/block/xen-blkback/xenbus.c
> &
On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park wrote:
> From: SeongJae Park
>
> Each `blkif` has a free pages pool for the grant mapping. The size of
> the pool starts from zero and is increased on demand while processing
> the I/O requests. If current I/O requests handling
From: SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of
the pool starts from zero and is increased on demand while processing
the I/O requests. If current I/O requests handling is finished or 100
milliseconds has passed since last I/O requests handling, it
From: SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it
is unnecessary for static variables. This commit removes such prefixes.
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/blkb
From: SeongJae Park
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/xenbus.c | 7
From: SeongJae Park
Granting pages consumes backend system memory. In systems configured
with insufficient spare memory for those pages, it can cause a memory
pressure situation. However, finding the optimal amount of the spare
memory is challenging for large systems having dynamic resource
d by Roger Pau Monné)
- Update contact of the new module param to SeongJae Park
(suggested by Roger Pau Monné)
- Wordsmith the description of the parameter
(suggested by Roger Pau Monné)
- Fix dumb bugs
(suggested by Roger Pau Monné)
- Move module param definition to xenbus.c
On Mon, 16 Dec 2019 10:37:55 +0100 "Roger Pau Monné"
wrote:
> On Fri, Dec 13, 2019 at 03:35:44PM +0000, SeongJae Park wrote:
> > Each `blkif` has a free pages pool for the grant mapping. The size of
> > the pool starts from zero and is increased on demand while proces
not only memory, but general
resources. Nevertheless, this version of the implementation defers such
sophisticated goals as a future work.
Reviewed-by: Juergen Gross
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/xen/xenbus/xenbus_probe_backend.c | 32
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/xenbus.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions
A few of static variables in blkback have 'xen_blkif_' prefix, though it
is unnecessary for static variables. This commit removes such prefixes.
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/blkback.c | 37 +
1 fi
with your workload to find the
optimal squeezing duration for you.
[1] https://aws.amazon.com/ebs/
[2] https://www.kernel.org/doc/html/latest/admin-guide/blockdev/ramdisk.html
Signed-off-by: SeongJae Park
---
.../ABI/testing/sysfs-driver-xen-blkback | 10 +
drivers/block/xen-bl
- Drop 'Reviewed-by: Juergen' from the second patch
(suggested by Roger Pau Monné)
- Update contact of the new module param to SeongJae Park
(suggested by Roger Pau Monné)
- Wordsmith the description of the parameter
(suggested by Roger Pau Monné)
- Fix dumb bugs
(suggest
ck device
> >
> >
> > max_pgs Min Max Median AvgStddev
> > 0 417 423 420419.4 2.5099801
> > 1024 414 425 416417.8 4.4384682
> > No difference prove
A few of static variables in blkback have 'xen_blkif_' prefix, though it
is unnecessary for static variables. This commit removes such prefixes.
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/block/xen-blkback/blkback.c | 37 +
1 fi
`
(suggested by Paul Durrant)
- Specify time unit of the duration in the parameter description,
(suggested by Maximilian Heyne)
- Change default aggressive shrinking duration from 1ms to 10ms
- Merge two patches into one single patch
SeongJae Park (3):
xenbus/backend: Add memory press
with your workload to find the
optimal squeezing duration for you.
[1] https://aws.amazon.com/ebs/
[2] https://www.kernel.org/doc/html/latest/admin-guide/blockdev/ramdisk.html
Reviewed-by: Juergen Gross
Signed-off-by: SeongJae Park
---
.../ABI/testing/sysfs-driver-xen-blkback | 9 +
not only memory, but general
resources. Nevertheless, this version of the implementation defers such
sophisticated goals as a future work.
Reviewed-by: Juergen Gross
Reviewed-by: Roger Pau Monné
Signed-off-by: SeongJae Park
---
drivers/xen/xenbus/xenbus_probe_backend.c | 32
On Fri, Dec 13, 2019 at 10:33 AM Jürgen Groß wrote:
>
> On 13.12.19 10:27, Roger Pau Monné wrote:
> > On Thu, Dec 12, 2019 at 05:06:58PM +0100, SeongJae Park wrote:
> >> On Thu, 12 Dec 2019 16:27:57 +0100 "Roger Pau Monné"
> >> wrote:
> >>
> &
1 - 100 of 134 matches
Mail list logo
