Re: [Xen-devel] [PATCH V6] pci: removed the is_express field since a uniform interface was inserted

2018-02-05 Thread Yoni Bettan
On 01/16/2018 02:34 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only

[Xen-devel] [PATCH V6] pci: removed the is_express field since a uniform interface was inserted

2018-01-16 Thread Yoni Bettan
Apfelbaum <mar...@redhat.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Yoni Bettan <ybet...@redhat.com> --- V5 --> V6 : rebased on Michael S. Tsirkin pci branch as requested. V4 --> V5 : updated the patch to work with a new inserted device hw/xen/xe

Re: [Xen-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-19 Thread Yoni Bettan
On 12/18/2017 05:21 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only

Re: [Xen-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-18 Thread Yoni Bettan
On 12/18/2017 05:21 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only

[Xen-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-18 Thread Yoni Bettan
not affected by the change. The only devices that were affected are those that are hybrid and also had (is_express == 1) - therefor only: - hw/vfio/pci.c - hw/usb/hcd-xhci.c - hw/xen/xen_pt.c For those 3 I made sure that QEMU_PCI_CAP_EXPRESS is on in instance_init() Signed-off-by: Yoni