Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-27 Thread Thomas Gleixner
On Sun, Oct 24 2021 at 21:25, Jason Andryuk wrote: > diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c > index 4b4792940e86..478536bafc39 100644 > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc > *desc, u32 clear,

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-26 Thread Josef Johansson
On 10/25/21 18:46, Josef Johansson wrote: > On 10/25/21 14:27, Jason Andryuk wrote: >> On Sun, Oct 24, 2021 at 9:26 PM Jason Andryuk wrote: >>> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask >>> functions") introduce functions pci_msi_update_mask() and >>>

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread Josef Johansson
On 10/25/21 14:27, Jason Andryuk wrote: > On Sun, Oct 24, 2021 at 9:26 PM Jason Andryuk wrote: >> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask >> functions") introduce functions pci_msi_update_mask() and >> pci_msix_write_vector_ctrl() that is missing checks for >>

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread Roger Pau Monné
On Mon, Oct 25, 2021 at 02:02:38PM +0100, David Woodhouse wrote: > On Mon, 2021-10-25 at 14:58 +0200, Roger Pau Monné wrote: > > On Mon, Oct 25, 2021 at 12:53:31PM +0100, David Woodhouse wrote: > > > On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monné wrote: > > > > It's kind of optional for HVM

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread David Woodhouse
On Mon, 2021-10-25 at 14:58 +0200, Roger Pau Monné wrote: > On Mon, Oct 25, 2021 at 12:53:31PM +0100, David Woodhouse wrote: > > On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monné wrote: > > > It's kind of optional for HVM guests, as it depends on > > > XENFEAT_hvm_pirqs, which sadly gets

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread Roger Pau Monné
On Mon, Oct 25, 2021 at 12:53:31PM +0100, David Woodhouse wrote: > On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monné wrote: > > It's kind of optional for HVM guests, as it depends on > > XENFEAT_hvm_pirqs, which sadly gets unconditionally set for HVM > > guests, thus dropping any benefits from

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread Jason Andryuk
On Mon, Oct 25, 2021 at 3:44 AM David Woodhouse wrote: > > On Sun, 2021-10-24 at 21:25 -0400, Jason Andryuk wrote: > > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask > > functions") introduce functions pci_msi_update_mask() and > > pci_msix_write_vector_ctrl() that is missing

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread Jason Andryuk
On Sun, Oct 24, 2021 at 9:26 PM Jason Andryuk wrote: > > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask > functions") introduce functions pci_msi_update_mask() and > pci_msix_write_vector_ctrl() that is missing checks for > pci_msi_ignore_mask that exists in commit

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread David Woodhouse
On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monné wrote: > It's kind of optional for HVM guests, as it depends on > XENFEAT_hvm_pirqs, which sadly gets unconditionally set for HVM > guests, thus dropping any benefits from having hardware assisted APIC > virtualization or posted interrupts

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread Roger Pau Monné
On Mon, Oct 25, 2021 at 08:44:52AM +0100, David Woodhouse wrote: > On Sun, 2021-10-24 at 21:25 -0400, Jason Andryuk wrote: > > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask > > functions") introduce functions pci_msi_update_mask() and > > pci_msix_write_vector_ctrl() that is

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread David Woodhouse
On Sun, 2021-10-24 at 21:25 -0400, Jason Andryuk wrote: > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask > functions") introduce functions pci_msi_update_mask() and > pci_msix_write_vector_ctrl() that is missing checks for > pci_msi_ignore_mask that exists in commit

[PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-24 Thread Jason Andryuk
commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask functions") introduce functions pci_msi_update_mask() and pci_msix_write_vector_ctrl() that is missing checks for pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use new mask/unmask functions"). The checks are