Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Jan Beulich
On 12.03.2024 15:49, Marek Marczykowski-Górecki wrote: > On Tue, Mar 12, 2024 at 03:37:15PM +0100, Jan Beulich wrote: >> On 12.03.2024 15:24, Marek Marczykowski-Górecki wrote: >>> On Tue, Mar 12, 2024 at 11:53:46AM +0100, Jan Beulich wrote: On 12.03.2024 11:24, Roger Pau Monné wrote: >>

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Marek Marczykowski-Górecki
On Tue, Mar 12, 2024 at 03:37:15PM +0100, Jan Beulich wrote: > On 12.03.2024 15:24, Marek Marczykowski-Górecki wrote: > > On Tue, Mar 12, 2024 at 11:53:46AM +0100, Jan Beulich wrote: > >> On 12.03.2024 11:24, Roger Pau Monné wrote: > --- a/xen/arch/x86/setup.c > +++

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Jan Beulich
On 12.03.2024 15:24, Marek Marczykowski-Górecki wrote: > On Tue, Mar 12, 2024 at 11:53:46AM +0100, Jan Beulich wrote: >> On 12.03.2024 11:24, Roger Pau Monné wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1806,6 +1806,9 @@ void asmlinkage __init noreturn

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Marek Marczykowski-Górecki
On Tue, Mar 12, 2024 at 11:53:46AM +0100, Jan Beulich wrote: > On 12.03.2024 11:24, Roger Pau Monné wrote: > >> --- a/xen/arch/x86/setup.c > >> +++ b/xen/arch/x86/setup.c > >> @@ -1806,6 +1806,9 @@ void asmlinkage __init noreturn __start_xen(unsigned > >> long mbi_p) > >> mmio_ro_ranges =

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Jan Beulich
On 12.03.2024 14:22, Marek Marczykowski-Górecki wrote: > On Tue, Mar 12, 2024 at 02:09:14PM +0100, Marek Marczykowski-Górecki wrote: >> On Tue, Mar 12, 2024 at 01:38:53PM +0100, Jan Beulich wrote: >>> On 12.03.2024 13:02, Marek Marczykowski-Górecki wrote: BTW should e820_change_range_type()

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Marek Marczykowski-Górecki
On Tue, Mar 12, 2024 at 02:09:14PM +0100, Marek Marczykowski-Górecki wrote: > On Tue, Mar 12, 2024 at 01:38:53PM +0100, Jan Beulich wrote: > > On 12.03.2024 13:02, Marek Marczykowski-Górecki wrote: > > > BTW should e820_change_range_type() return 1 in case of mapping already > > > having the right

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Marek Marczykowski-Górecki
On Tue, Mar 12, 2024 at 01:38:53PM +0100, Jan Beulich wrote: > On 12.03.2024 13:02, Marek Marczykowski-Górecki wrote: > > On Tue, Mar 12, 2024 at 11:53:46AM +0100, Jan Beulich wrote: > >> On 12.03.2024 11:24, Roger Pau Monné wrote: > --- a/xen/arch/x86/setup.c > +++

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Jan Beulich
On 12.03.2024 13:02, Marek Marczykowski-Górecki wrote: > On Tue, Mar 12, 2024 at 11:53:46AM +0100, Jan Beulich wrote: >> On 12.03.2024 11:24, Roger Pau Monné wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1806,6 +1806,9 @@ void asmlinkage __init noreturn

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Marek Marczykowski-Górecki
On Tue, Mar 12, 2024 at 11:53:46AM +0100, Jan Beulich wrote: > On 12.03.2024 11:24, Roger Pau Monné wrote: > >> --- a/xen/arch/x86/setup.c > >> +++ b/xen/arch/x86/setup.c > >> @@ -1806,6 +1806,9 @@ void asmlinkage __init noreturn __start_xen(unsigned > >> long mbi_p) > >> mmio_ro_ranges =

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Jan Beulich
On 12.03.2024 11:24, Roger Pau Monné wrote: >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -1806,6 +1806,9 @@ void asmlinkage __init noreturn __start_xen(unsigned >> long mbi_p) >> mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", >>

Re: [PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-12 Thread Roger Pau Monné
On Mon, Mar 11, 2024 at 09:33:11PM +0100, Marek Marczykowski-Górecki wrote: > The IOMMU driver checks if RMRR/IVMD are marked as reserved in memory > map. This should be true for addresses coming from the firmware, but > when extra pages used by Xen itself are included in the mapping, those > are

[PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-11 Thread Marek Marczykowski-Górecki
The IOMMU driver checks if RMRR/IVMD are marked as reserved in memory map. This should be true for addresses coming from the firmware, but when extra pages used by Xen itself are included in the mapping, those are taken from usable RAM used. Mark those pages as reserved too. Not marking the pages