Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-12-06 Thread Per Bilse (3P)
On 28/11/2022 08:21, Jan Beulich wrote: > In addition I think ignoring failure (and, as said by Julien, only because > of no bufioreq being registered) is (kind of implicitly) valid only for > buffered requests. Hence I'm unconvinced of the need of a new boolean > function parameter. Instead I

Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-30 Thread Paul Durrant
On 28/11/2022 12:26, Jan Beulich wrote: On 28.11.2022 12:06, Roger Pau Monné wrote: On Mon, Nov 28, 2022 at 09:21:47AM +0100, Jan Beulich wrote: On 26.11.2022 23:19, Julien Grall wrote: On 25/11/2022 14:15, Per Bilse wrote: This patch modifies ioreq_broadcast() to allow partial success.

Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-28 Thread Jan Beulich
On 28.11.2022 12:06, Roger Pau Monné wrote: > On Mon, Nov 28, 2022 at 09:21:47AM +0100, Jan Beulich wrote: >> On 26.11.2022 23:19, Julien Grall wrote: >>> On 25/11/2022 14:15, Per Bilse wrote: This patch modifies ioreq_broadcast() to allow partial success. >>> >>> The commit message is quite

Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-28 Thread Roger Pau Monné
On Mon, Nov 28, 2022 at 09:21:47AM +0100, Jan Beulich wrote: > On 26.11.2022 23:19, Julien Grall wrote: > > On 25/11/2022 14:15, Per Bilse wrote: > >> A change to XAPI varstored causes > > > > For those unfamiliar with XAPI (like me), can you explain what was the > > change made? One ioreq

Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-28 Thread Per Bilse (3P)
On 28/11/2022 08:21, Jan Beulich wrote: > On 26.11.2022 23:19, Julien Grall wrote: >> >> The commit message is quite vague, so it is hard to know what you are >> trying to solve exactly. AFAIU, there are two reasons for >> ioreq_broadcast to fails: >>1) The IOREQ server didn't register the

Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-28 Thread Jan Beulich
On 26.11.2022 23:19, Julien Grall wrote: > On 25/11/2022 14:15, Per Bilse wrote: >> A change to XAPI varstored causes > > For those unfamiliar with XAPI (like me), can you explain what was the > change made? > >> an unnecessary error message >> to be logged in hypervisor.log whenever an RTC

Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-26 Thread Julien Grall
Hi, On 25/11/2022 14:15, Per Bilse wrote: A change to XAPI varstored causes For those unfamiliar with XAPI (like me), can you explain what was the change made? an unnecessary error message to be logged in hypervisor.log whenever an RTC timeoffset update is broadcast. In extreme cases

[PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-25 Thread Per Bilse
A change to XAPI varstored causes an unnecessary error message to be logged in hypervisor.log whenever an RTC timeoffset update is broadcast. In extreme cases this could flood the log file. This patch modifies ioreq_broadcast() to allow partial success. Signed-off-by: Per Bilse ---