Re: [PATCH] x86/Xen: tidy xen-head.S

2023-02-15 Thread Andrew Cooper
On 15/02/2023 1:36 pm, Jan Beulich wrote: > On 15.02.2023 14:25, Andrew Cooper wrote: >> MOD_START_PFN is PV only.  It's not applicable for HVM/PVH. > It isn't right now, yes. I continue to be uncertain and would > prefer to leave it as is. Its the wrong address space to be applicable to HVM/PVH.

Re: [PATCH] x86/Xen: tidy xen-head.S

2023-02-15 Thread Jan Beulich
On 15.02.2023 14:25, Andrew Cooper wrote: > On 15/02/2023 1:12 pm, Juergen Gross wrote: >> On 15.02.23 13:42, Jan Beulich wrote: >>> On 15.02.2023 13:05, Juergen Gross wrote: On 15.02.23 12:33, Jan Beulich wrote: > -#endif >    #ifdef CONFIG_XEN_PV >    ELFNOTE(Xen, XEN_ELFNOTE

Re: [PATCH] x86/Xen: tidy xen-head.S

2023-02-15 Thread Andrew Cooper
On 15/02/2023 1:12 pm, Juergen Gross wrote: > On 15.02.23 13:42, Jan Beulich wrote: >> On 15.02.2023 13:05, Juergen Gross wrote: >>> On 15.02.23 12:33, Jan Beulich wrote: First of all drop 32-bit leftovers, including the inclusion of the file from head_32.S. >>> >>> I don't see why w

Re: [PATCH] x86/Xen: tidy xen-head.S

2023-02-15 Thread Juergen Gross
On 15.02.23 13:42, Jan Beulich wrote: On 15.02.2023 13:05, Juergen Gross wrote: On 15.02.23 12:33, Jan Beulich wrote: First of all drop 32-bit leftovers, including the inclusion of the file from head_32.S. I don't see why we would want to drop 32-bit HVM and PVH support. HVM doesn't use thi

Re: [PATCH] x86/Xen: tidy xen-head.S

2023-02-15 Thread Jan Beulich
On 15.02.2023 13:05, Juergen Gross wrote: > On 15.02.23 12:33, Jan Beulich wrote: >> First of all drop 32-bit leftovers, including the inclusion of the file >> from head_32.S. > > I don't see why we would want to drop 32-bit HVM and PVH support. HVM doesn't use this, does it? But yes, the PVH asp

Re: [PATCH] x86/Xen: tidy xen-head.S

2023-02-15 Thread Juergen Gross
On 15.02.23 12:33, Jan Beulich wrote: First of all drop 32-bit leftovers, including the inclusion of the file from head_32.S. I don't see why we would want to drop 32-bit HVM and PVH support. Then further move PV-only ELF notes inside the XEN_PV conditional. Finally have the "supported featur

[PATCH] x86/Xen: tidy xen-head.S

2023-02-15 Thread Jan Beulich
First of all drop 32-bit leftovers, including the inclusion of the file from head_32.S. Then further move PV-only ELF notes inside the XEN_PV conditional. Finally have the "supported features" note actually report reality: All three of the features are supported and/or applicable only in certain ca