Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

2020-05-24 Thread Tim Deegan
At 10:04 +0100 on 21 May (1590055468), Andrew Cooper wrote: > When compiling with SHOPT_OUT_OF_SYNC disabled, the build fails with: > > common.c:41:12: error: ‘sh_remove_write_access_from_sl1p’ declared ‘static’ > but never defined [-Werror=unused-function] >static int

Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

2020-05-21 Thread Roger Pau Monné
On Thu, May 21, 2020 at 11:32:04AM +0100, Andrew Cooper wrote: > On 21/05/2020 11:26, Roger Pau Monné wrote: > > On Thu, May 21, 2020 at 10:04:28AM +0100, Andrew Cooper wrote: > >> +static int sh_remove_write_access_from_sl1p(struct domain *d, mfn_t gmfn, > >> +

Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

2020-05-21 Thread Andrew Cooper
On 21/05/2020 11:26, Roger Pau Monné wrote: > On Thu, May 21, 2020 at 10:04:28AM +0100, Andrew Cooper wrote: >> When compiling with SHOPT_OUT_OF_SYNC disabled, the build fails with: >> >> common.c:41:12: error: ‘sh_remove_write_access_from_sl1p’ declared >> ‘static’ but never defined

Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

2020-05-21 Thread Andrew Cooper
On 21/05/2020 11:12, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel On Behalf Of Andrew >> Cooper >> Sent: 21 May 2020 10:04 >> To: Xen-devel >> Cc: Andrew Cooper ; Tim Deegan ; >> Wei Liu ; Jan >> Beulich ; Roger Pau M

Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

2020-05-21 Thread Roger Pau Monné
On Thu, May 21, 2020 at 10:04:28AM +0100, Andrew Cooper wrote: > When compiling with SHOPT_OUT_OF_SYNC disabled, the build fails with: > > common.c:41:12: error: ‘sh_remove_write_access_from_sl1p’ declared ‘static’ > but never defined [-Werror=unused-function] >static int

RE: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

2020-05-21 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of Andrew > Cooper > Sent: 21 May 2020 10:04 > To: Xen-devel > Cc: Andrew Cooper ; Tim Deegan ; Wei > Liu ; Jan > Beulich ; Roger Pau Monné > Subject: [PATCH] x86/shadow: Reposition sh_remove_write_access_from

[PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

2020-05-21 Thread Andrew Cooper
When compiling with SHOPT_OUT_OF_SYNC disabled, the build fails with: common.c:41:12: error: ‘sh_remove_write_access_from_sl1p’ declared ‘static’ but never defined [-Werror=unused-function] static int sh_remove_write_access_from_sl1p(struct domain *d, mfn_t gmfn,