Re: [PATCH] x86: Address MISRA Rule 13.6

2024-04-03 Thread Federico Serafini
On 02/04/24 18:09, Andrew Cooper wrote: On 02/04/2024 5:06 pm, Jan Beulich wrote: On 02.04.2024 17:54, Andrew Cooper wrote: On 02/04/2024 4:46 pm, Jan Beulich wrote: On 02.04.2024 17:43, Andrew Cooper wrote: MISRA Rule 13.6 doesn't like having an expression in a sizeof() which potentially

Re: [PATCH] x86: Address MISRA Rule 13.6

2024-04-02 Thread Federico Serafini
On 02/04/24 17:54, Andrew Cooper wrote: On 02/04/2024 4:46 pm, Jan Beulich wrote: On 02.04.2024 17:43, Andrew Cooper wrote: MISRA Rule 13.6 doesn't like having an expression in a sizeof() which potentially has side effects. Address several violations by pulling the expression out into a local

Re: [PATCH] x86: Address MISRA Rule 13.6

2024-04-02 Thread Andrew Cooper
On 02/04/2024 5:06 pm, Jan Beulich wrote: > On 02.04.2024 17:54, Andrew Cooper wrote: >> On 02/04/2024 4:46 pm, Jan Beulich wrote: >>> On 02.04.2024 17:43, Andrew Cooper wrote: MISRA Rule 13.6 doesn't like having an expression in a sizeof() which potentially has side effects.

Re: [PATCH] x86: Address MISRA Rule 13.6

2024-04-02 Thread Jan Beulich
On 02.04.2024 17:54, Andrew Cooper wrote: > On 02/04/2024 4:46 pm, Jan Beulich wrote: >> On 02.04.2024 17:43, Andrew Cooper wrote: >>> MISRA Rule 13.6 doesn't like having an expression in a sizeof() which >>> potentially has side effects. >>> >>> Address several violations by pulling the

Re: [PATCH] x86: Address MISRA Rule 13.6

2024-04-02 Thread Andrew Cooper
On 02/04/2024 4:46 pm, Jan Beulich wrote: > On 02.04.2024 17:43, Andrew Cooper wrote: >> MISRA Rule 13.6 doesn't like having an expression in a sizeof() which >> potentially has side effects. >> >> Address several violations by pulling the expression out into a local >> variable. >> >> No

Re: [PATCH] x86: Address MISRA Rule 13.6

2024-04-02 Thread Jan Beulich
On 02.04.2024 17:43, Andrew Cooper wrote: > MISRA Rule 13.6 doesn't like having an expression in a sizeof() which > potentially has side effects. > > Address several violations by pulling the expression out into a local > variable. > > No functional change. > > Signed-off-by: Andrew Cooper

[PATCH] x86: Address MISRA Rule 13.6

2024-04-02 Thread Andrew Cooper
MISRA Rule 13.6 doesn't like having an expression in a sizeof() which potentially has side effects. Address several violations by pulling the expression out into a local variable. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Stefano