Re: [PATCH] xen/domain: Fix label position in domain_teardown()

2021-08-27 Thread Andrew Cooper
On 27/08/2021 15:07, Jan Beulich wrote: > On 27.08.2021 16:01, Andrew Cooper wrote: >> As explained in the comments, a progress label wants to be before the >> function >> it refers to for the higher level logic to make sense. As it happens, the >> effects are benign because gnttab_mappings is im

Re: [PATCH] xen/domain: Fix label position in domain_teardown()

2021-08-27 Thread Jan Beulich
On 27.08.2021 16:01, Andrew Cooper wrote: > As explained in the comments, a progress label wants to be before the function > it refers to for the higher level logic to make sense. As it happens, the > effects are benign because gnttab_mappings is immediately adjacent to teardown > in terms of co-r

[PATCH] xen/domain: Fix label position in domain_teardown()

2021-08-27 Thread Andrew Cooper
As explained in the comments, a progress label wants to be before the function it refers to for the higher level logic to make sense. As it happens, the effects are benign because gnttab_mappings is immediately adjacent to teardown in terms of co-routine exit points. There is and will always be a