Re: [PATCH] xen/livepatch: Fix .altinstructions safety checks

2023-04-17 Thread Andrew Cooper
On 17/04/2023 11:01 am, Jan Beulich wrote: > On 15.04.2023 04:22, Andrew Cooper wrote: >> The prior check has && vs || mixups, making it tautologically false and thus >> providing no safety at all. There are boundary errors too. >> >> First start with a comment describing how the .altinstructions

Re: [PATCH] xen/livepatch: Fix .altinstructions safety checks

2023-04-17 Thread Jan Beulich
On 15.04.2023 04:22, Andrew Cooper wrote: > The prior check has && vs || mixups, making it tautologically false and thus > providing no safety at all. There are boundary errors too. > > First start with a comment describing how the .altinstructions and > .altinstr_replacement sections interact, a

[PATCH] xen/livepatch: Fix .altinstructions safety checks

2023-04-14 Thread Andrew Cooper
The prior check has && vs || mixups, making it tautologically false and thus providing no safety at all. There are boundary errors too. First start with a comment describing how the .altinstructions and .altinstr_replacement sections interact, and perform suitable cross-checking. Second, rewrite