Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-02-13 Thread Juergen Gross
On 18.01.23 13:22, David Woodhouse wrote: From: David Woodhouse When we don't use the per-CPU vector callback, we ask Xen to deliver event channel interrupts as INTx on the PCI platform device. As such, it can be shared with INTx on other PCI devices. Set IRQF_SHARED, and make it return

Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-19 Thread Juergen Gross
On 18.01.23 13:22, David Woodhouse wrote: From: David Woodhouse When we don't use the per-CPU vector callback, we ask Xen to deliver event channel interrupts as INTx on the PCI platform device. As such, it can be shared with INTx on other PCI devices. Set IRQF_SHARED, and make it return

Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-18 Thread David Woodhouse
On Wed, 2023-01-18 at 14:39 +, Andrew Cooper wrote: > On 18/01/2023 2:26 pm, David Woodhouse wrote:? > > > There is no actual thing called PVHVM.  That diagram has caused far more > > > damage than good... > > > > > > There's HVM (and by this, I mean the hypervisor's interpretation meaning > >

Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-18 Thread Andrew Cooper
On 18/01/2023 2:26 pm, David Woodhouse wrote: > On Wed, 2023-01-18 at 14:22 +, Andrew Cooper wrote: >> On 18/01/2023 2:06 pm, David Woodhouse wrote: >>> On Wed, 2023-01-18 at 13:53 +, Andrew Cooper wrote: On 18/01/2023 12:22 pm, David Woodhouse wrote: > Signed-off-by: David

Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-18 Thread David Woodhouse
On Wed, 2023-01-18 at 14:22 +, Andrew Cooper wrote: > On 18/01/2023 2:06 pm, David Woodhouse wrote: > > On Wed, 2023-01-18 at 13:53 +, Andrew Cooper wrote: > > > On 18/01/2023 12:22 pm, David Woodhouse wrote: > > > > Signed-off-by: David Woodhouse > > > > --- > > > > What does

Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-18 Thread Andrew Cooper
On 18/01/2023 2:06 pm, David Woodhouse wrote: > On Wed, 2023-01-18 at 13:53 +, Andrew Cooper wrote: >> On 18/01/2023 12:22 pm, David Woodhouse wrote: >>> Signed-off-by: David Woodhouse >>> --- >>> What does xen_evtchn_do_upcall() exist for? Can we delete it? I don't >>> see it being called

Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-18 Thread David Woodhouse
On Wed, 2023-01-18 at 13:53 +, Andrew Cooper wrote: > On 18/01/2023 12:22 pm, David Woodhouse wrote: > > Signed-off-by: David Woodhouse > > --- > > What does xen_evtchn_do_upcall() exist for? Can we delete it? I don't > > see it being called anywhere. > > Seems the caller was dropped by >

Re: [PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-18 Thread Andrew Cooper
On 18/01/2023 12:22 pm, David Woodhouse wrote: > Signed-off-by: David Woodhouse > --- > What does xen_evtchn_do_upcall() exist for? Can we delete it? I don't > see it being called anywhere. Seems the caller was dropped by cb09ea2924cbf1a42da59bd30a59cc1836240bcb, but the CONFIG_PVHVM looks bogus

[PATCH] xen: Allow platform PCI interrupt to be shared

2023-01-18 Thread David Woodhouse
From: David Woodhouse When we don't use the per-CPU vector callback, we ask Xen to deliver event channel interrupts as INTx on the PCI platform device. As such, it can be shared with INTx on other PCI devices. Set IRQF_SHARED, and make it return IRQ_HANDLED or IRQ_NONE according to whether the