Re: [PATCH] xen: Swap order of actions in the FREE*() macros

2024-02-08 Thread Bertrand Marquis
Hi Andrew, > On 2 Feb 2024, at 00:39, Andrew Cooper wrote: > > Wherever possible, it is a good idea to NULL out the visible reference to an > object prior to freeing it. The FREE*() macros already collect together both > parts, making it easy to adjust. > > This has a marginal code generation

Re: [PATCH] xen: Swap order of actions in the FREE*() macros

2024-02-01 Thread Jan Beulich
On 02.02.2024 01:39, Andrew Cooper wrote: > Wherever possible, it is a good idea to NULL out the visible reference to an > object prior to freeing it. The FREE*() macros already collect together both > parts, making it easy to adjust. > > This has a marginal code generation improvement, as some o

[PATCH] xen: Swap order of actions in the FREE*() macros

2024-02-01 Thread Andrew Cooper
Wherever possible, it is a good idea to NULL out the visible reference to an object prior to freeing it. The FREE*() macros already collect together both parts, making it easy to adjust. This has a marginal code generation improvement, as some of the calls to the free() function can be tailcall o