Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 17:35, Anthony PERARD wrote: > > On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daudé wrote: > > CONFIG_XEN is generated by configure and stored in "config-target.h", > > which is (obviously) only include for target-specific objects. > > This is a problem for

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Anthony PERARD
On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daudé wrote: > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and

RE: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Paul Durrant
Durrant ; Peter > Maydell > > Subject: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on > target-agnostic objects > > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200728100925.10454-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Philippe Mathieu-Daudé
CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by following the KVM schema,