Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-30 Thread Roger Pau Monné
On Mon, Jun 29, 2020 at 07:20:35PM +, Anchal Agarwal wrote: > On Fri, Jun 26, 2020 at 11:12:39AM +0200, Roger Pau Monné wrote: > > So the frontend should do: > > > > - Switch to Closed state (and cleanup everything required). > > - Wait for backend to switch to Closed state (must be done > >

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-26 Thread Roger Pau Monné
On Thu, Jun 25, 2020 at 06:36:59PM +, Anchal Agarwal wrote: > On Tue, Jun 23, 2020 at 10:19:03AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 12:43:14AM +, Anchal Agarwal wrote: > On Mon, Jun 22, 2020 at 10:38:46AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-22 Thread Roger Pau Monné
On Fri, Jun 19, 2020 at 11:43:12PM +, Anchal Agarwal wrote: > On Wed, Jun 17, 2020 at 10:35:28AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-17 Thread Roger Pau Monné
On Tue, Jun 16, 2020 at 10:30:03PM +, Anchal Agarwal wrote: > On Tue, Jun 16, 2020 at 09:49:25PM +, Anchal Agarwal wrote: > > On Thu, Jun 04, 2020 at 09:05:48AM +0200, Roger Pau Monné wrote: > > > On Wed, Jun 03, 2020 at 11:33:52PM +, Agarwal, Anchal wrote: > > > > On Tue, May 19,

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-17 Thread Roger Pau Monné
On Tue, Jun 16, 2020 at 09:49:25PM +, Anchal Agarwal wrote: > On Thu, Jun 04, 2020 at 09:05:48AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-04 Thread Roger Pau Monné
Hello, On Wed, Jun 03, 2020 at 11:33:52PM +, Agarwal, Anchal wrote: > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > On Tue, May 19, 2020 at

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-03 Thread Agarwal, Anchal
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Tue, May 19, 2020 at 11:27:50PM +, Anchal Agarwal wrote: > From: Munehisa Kamata > > S4 power

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-28 Thread Roger Pau Monné
On Tue, May 19, 2020 at 11:27:50PM +, Anchal Agarwal wrote: > From: Munehisa Kamata > > S4 power transition states are much different than xen > suspend/resume. Former is visible to the guest and frontend drivers should > be aware of the state transitions and should be able to take

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-23 Thread kbuild test robot
Hi Anchal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-21 Thread Singh, Balbir
> @@ -1057,7 +1063,7 @@ static int xen_translate_vdev(int vdevice, int *minor, > unsigned int *offset) > case XEN_SCSI_DISK5_MAJOR: > case XEN_SCSI_DISK6_MAJOR: > case XEN_SCSI_DISK7_MAJOR: > - *offset = (*minor / PARTS_PER_DISK) + >

[PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-21 Thread Anchal Agarwal
From: Munehisa Kamata S4 power transisiton states are much different than xen suspend/resume. Former is visible to the guest and frontend drivers should be aware of the state transistions and should be able to take appropriate actions when needed. In transition to S4 we need to make sure that at

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-19 Thread kbuild test robot
Hi Anchal, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-19 Thread kbuild test robot
Hi Anchal, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-14 Thread Roger Pau Monné
Please try to avoid top posting. On Wed, Jun 13, 2018 at 10:20:48PM +, Anchal Agarwal wrote: > Hi Roger, > To answer your question, due to the lack of mentioned commit > (commit 12ea729645ac ("xen/blkback: unmap all persistent grants when > frontend gets disconnected") in the older dom0

Re: [Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-13 Thread Anchal Agarwal
Hi Roger, To answer your question, due to the lack of mentioned commit (commit 12ea729645ac ("xen/blkback: unmap all persistent grants when frontend gets disconnected") in the older dom0 kernels(<3.2),resume from hibernation can fail on guest side. In the absence of the commit, Persistant Grants

Re: [Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-13 Thread Roger Pau Monné
On Tue, Jun 12, 2018 at 08:56:13PM +, Anchal Agarwal wrote: > From: Munehisa Kamata > > Add freeze and restore callbacks for PM suspend and hibernation support. > The freeze handler stops a block-layer queue and disconnect the frontend > from the backend while freeing ring_info and

[Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Add freeze and restore callbacks for PM suspend and hibernation support. The freeze handler stops a block-layer queue and disconnect the frontend from the backend while freeing ring_info and associated resources. The restore handler re-allocates ring_info and re-connect to