Re: [PATCH 1/2] x86/entry: Introduce POP_GPRS

2024-03-14 Thread Jan Beulich
On 13.03.2024 15:26, Andrew Cooper wrote: > The macro named RESTORE_ALL has several problems. It adjusts the stack > pointer despite this not being clear to the caller. It also goes against > recommendations in the optimisation guides because of trying to do too many > things at once. (i.e.

[PATCH 1/2] x86/entry: Introduce POP_GPRS

2024-03-13 Thread Andrew Cooper
The macro named RESTORE_ALL has several problems. It adjusts the stack pointer despite this not being clear to the caller. It also goes against recommendations in the optimisation guides because of trying to do too many things at once. (i.e. there's a reason why compilers don't emit code