Re: [PATCH 1/4] golang/xenlight: add NameToDomid and DomidToName util functions

2020-04-23 Thread George Dunlap
> On Apr 22, 2020, at 8:46 PM, Nick Rosbrook wrote: > >> libxl.h defines INVALID_DOMID — do we want to define an exported constant >> with the same name and use that here? (Although part of me wonders if >> DOMID_INVALID would be a better option.) > > Yeah, that makes sense. I'll add that.

Re: [PATCH 1/4] golang/xenlight: add NameToDomid and DomidToName util functions

2020-04-22 Thread Nick Rosbrook
> libxl.h defines INVALID_DOMID — do we want to define an exported constant > with the same name and use that here? (Although part of me wonders if > DOMID_INVALID would be a better option.) Yeah, that makes sense. I'll add that. > > + } > > + > > + return Domid(domid), nil > > +} > >

Re: [PATCH 1/4] golang/xenlight: add NameToDomid and DomidToName util functions

2020-04-22 Thread George Dunlap
> On Apr 12, 2020, at 11:02 PM, Nick Rosbrook wrote: > > Many exported functions in xenlight require a domid as an argument. Make > it easier for package users to use these functions by adding wrappers > for the libxl utility functions libxl_name_to_domid and > libxl_domid_to_name. > >

[PATCH 1/4] golang/xenlight: add NameToDomid and DomidToName util functions

2020-04-12 Thread Nick Rosbrook
Many exported functions in xenlight require a domid as an argument. Make it easier for package users to use these functions by adding wrappers for the libxl utility functions libxl_name_to_domid and libxl_domid_to_name. Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/xenlight.go | 23