Re: [PATCH 24/26] hw/usb/usb-hcd: Use UHCI type definitions

2020-07-04 Thread Paolo Bonzini
On 04/07/20 21:44, BALATON Zoltan wrote: > > No it's OK, no need to list all defines. I just did not notice the macro > argument that's why I was wondering where it comes from. This seems to > be used elsewhere at least here: > > hw/audio/es1370.c:#define a(n) if (val & CTRL_##n) strcat (buf, "

Re: [PATCH 24/26] hw/usb/usb-hcd: Use UHCI type definitions

2020-07-04 Thread Philippe Mathieu-Daudé
On 7/4/20 9:44 PM, BALATON Zoltan wrote: > On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote: >> On 7/4/20 7:17 PM, BALATON Zoltan wrote: >>> On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote: Various machine/board/soc models create UHCI device instances with the generic QDEV API, and

Re: [PATCH 24/26] hw/usb/usb-hcd: Use UHCI type definitions

2020-07-04 Thread BALATON Zoltan
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote: On 7/4/20 7:17 PM, BALATON Zoltan wrote: On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote: Various machine/board/soc models create UHCI device instances with the generic QDEV API, and don't need to access USB internals. Simplify header

Re: [PATCH 24/26] hw/usb/usb-hcd: Use UHCI type definitions

2020-07-04 Thread Philippe Mathieu-Daudé
On 7/4/20 7:17 PM, BALATON Zoltan wrote: > On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote: >> Various machine/board/soc models create UHCI device instances >> with the generic QDEV API, and don't need to access USB internals. >> >> Simplify header inclusions by moving the QOM type names into a

Re: [PATCH 24/26] hw/usb/usb-hcd: Use UHCI type definitions

2020-07-04 Thread BALATON Zoltan
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote: Various machine/board/soc models create UHCI device instances with the generic QDEV API, and don't need to access USB internals. Simplify header inclusions by moving the QOM type names into a simple header, with no need to include other "hw/usb"

[PATCH 24/26] hw/usb/usb-hcd: Use UHCI type definitions

2020-07-04 Thread Philippe Mathieu-Daudé
Various machine/board/soc models create UHCI device instances with the generic QDEV API, and don't need to access USB internals. Simplify header inclusions by moving the QOM type names into a simple header, with no need to include other "hw/usb" headers. Suggested-by: BALATON Zoltan