Re: [PATCH 3/7] multiboot2: Add support for the load type header tag

2024-03-28 Thread Ross Lagerwall
On Fri, Mar 15, 2024 at 7:31 AM Vladimir 'phcoder' Serbinenko wrote: > > Not a full review. Just one blocking problem > >> >> >> } >> + case MULTIBOOT_LOAD_TYPE_PE: >> + grub_fatal ("Unsupported load type: %u\n", mld.load_type); >> + default: >> +/* should be impossible */ >> +

Re: [PATCH 3/7] multiboot2: Add support for the load type header tag

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
Not a full review. Just one blocking problem > > } > + case MULTIBOOT_LOAD_TYPE_PE: > + grub_fatal ("Unsupported load type: %u\n", mld.load_type); > + default: > +/* should be impossible */ > +grub_fatal ("Unknown load type: %u\n", mld.load_type); > Don't use grub_fatal for

[PATCH 3/7] multiboot2: Add support for the load type header tag

2024-03-13 Thread Ross Lagerwall
The binary may expose its type using the load type header tag. Implement it according to the specification. Signed-off-by: Ross Lagerwall --- grub-core/loader/multiboot_mbi2.c | 45 --- include/grub/multiboot2.h | 1 + include/multiboot2.h | 13