Re: [PATCH 9/9] xen/arm64: Remove READ/WRITE_SYSREG32 helper macros

2021-04-27 Thread Julien Grall
On 27/04/2021 08:16, Michal Orzel wrote: Hi Jilien, Hi, On 21.04.2021 21:16, Julien Grall wrote: Hi Michal, On 20/04/2021 08:08, Michal Orzel wrote: AArch64 system registers are 64bit whereas AArch32 ones are 32bit or 64bit. MSR/MRS are expecting 64bit values thus we should get rid of

Re: [PATCH 9/9] xen/arm64: Remove READ/WRITE_SYSREG32 helper macros

2021-04-27 Thread Michal Orzel
Hi Jilien, On 21.04.2021 21:16, Julien Grall wrote: > Hi Michal, > > On 20/04/2021 08:08, Michal Orzel wrote: >> AArch64 system registers are 64bit whereas AArch32 ones >> are 32bit or 64bit. MSR/MRS are expecting 64bit values thus >> we should get rid of helpers READ/WRITE_SYSREG32 >> in favour

Re: [PATCH 9/9] xen/arm64: Remove READ/WRITE_SYSREG32 helper macros

2021-04-21 Thread Julien Grall
Hi Michal, On 20/04/2021 08:08, Michal Orzel wrote: AArch64 system registers are 64bit whereas AArch32 ones are 32bit or 64bit. MSR/MRS are expecting 64bit values thus we should get rid of helpers READ/WRITE_SYSREG32 in favour of using READ/WRITE_SYSREG. We should also use register_t type when

[PATCH 9/9] xen/arm64: Remove READ/WRITE_SYSREG32 helper macros

2021-04-20 Thread Michal Orzel
AArch64 system registers are 64bit whereas AArch32 ones are 32bit or 64bit. MSR/MRS are expecting 64bit values thus we should get rid of helpers READ/WRITE_SYSREG32 in favour of using READ/WRITE_SYSREG. We should also use register_t type when reading sysregs which can correspond to uint64_t or