Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage

2020-06-25 Thread Roger Pau Monné
On Wed, Jun 24, 2020 at 12:10:45PM +0100, Julien Grall wrote: > Hi Roger, > > On 23/06/2020 17:16, Roger Pau Monné wrote: > > On Tue, Jun 23, 2020 at 04:46:29PM +0100, Julien Grall wrote: > > > > > > > > > On 23/06/2020 16:15, Roger Pau Monné wrote: > > > > On Tue, Jun 23, 2020 at 04:08:06PM

Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage

2020-06-24 Thread Julien Grall
Hi Roger, On 23/06/2020 17:16, Roger Pau Monné wrote: On Tue, Jun 23, 2020 at 04:46:29PM +0100, Julien Grall wrote: On 23/06/2020 16:15, Roger Pau Monné wrote: On Tue, Jun 23, 2020 at 04:08:06PM +0100, Julien Grall wrote: Hi Roger, On 23/06/2020 15:50, Roger Pau Monne wrote: diff --git

Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 04:46:29PM +0100, Julien Grall wrote: > > > On 23/06/2020 16:15, Roger Pau Monné wrote: > > On Tue, Jun 23, 2020 at 04:08:06PM +0100, Julien Grall wrote: > > > Hi Roger, > > > > > > On 23/06/2020 15:50, Roger Pau Monne wrote: > > > > diff --git a/xen/include/xen/mm.h

Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage

2020-06-23 Thread Julien Grall
On 23/06/2020 16:15, Roger Pau Monné wrote: On Tue, Jun 23, 2020 at 04:08:06PM +0100, Julien Grall wrote: Hi Roger, On 23/06/2020 15:50, Roger Pau Monne wrote: diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 9b62087be1..f360166f00 100644 --- a/xen/include/xen/mm.h +++

Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 04:08:06PM +0100, Julien Grall wrote: > Hi Roger, > > On 23/06/2020 15:50, Roger Pau Monne wrote: > > diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > > index 9b62087be1..f360166f00 100644 > > --- a/xen/include/xen/mm.h > > +++ b/xen/include/xen/mm.h > > @@

Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage

2020-06-23 Thread Julien Grall
Hi Roger, On 23/06/2020 15:50, Roger Pau Monne wrote: diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 9b62087be1..f360166f00 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -639,7 +639,8 @@ static inline void accumulate_tlbflush(bool *need_tlbflush, } }

[PATCH for-4.14 v2] x86/tlb: fix assisted flush usage

2020-06-23 Thread Roger Pau Monne
Commit e9aca9470ed86 introduced a regression when avoiding sending IPIs for certain flush operations. Xen page fault handler (spurious_page_fault) relies on blocking interrupts in order to prevent handling TLB flush IPIs and thus preventing other CPUs from removing page tables pages. Switching to