Re: [PATCH for-4.15 v3] xen/dmop: Strip __XEN_TOOLS__ header guard from public ABI

2021-03-11 Thread Paul Durrant
On 11/03/2021 13:24, Andrew Cooper wrote: __XEN_TOOLS__ is really there to separate the unstable from stable hypercalls. Exactly as with c/s f40e1c52e4, stable interfaces shouldn't contain this guard. That change actually broke the build with: include/xendevicemodel.h:52:5: error: unknown

[PATCH for-4.15 v3] xen/dmop: Strip __XEN_TOOLS__ header guard from public ABI

2021-03-11 Thread Andrew Cooper
__XEN_TOOLS__ is really there to separate the unstable from stable hypercalls. Exactly as with c/s f40e1c52e4, stable interfaces shouldn't contain this guard. That change actually broke the build with: include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' ioservid_t *id);