Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-16 Thread Oleksii K.
On Tue, 2024-05-14 at 14:52 +0100, Andrew Cooper wrote: > On 14/05/2024 1:36 pm, Leigh Brown wrote: > > Hello, > > > > On 2024-05-14 13:07, Andrew Cooper wrote: > > > On 14/05/2024 9:13 am, Leigh Brown wrote: > > > > Although using integer comparison to compare doubles kind of > > > > works, it's

Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-14 Thread Andrew Cooper
On 14/05/2024 1:36 pm, Leigh Brown wrote: > Hello, > > On 2024-05-14 13:07, Andrew Cooper wrote: >> On 14/05/2024 9:13 am, Leigh Brown wrote: >>> Although using integer comparison to compare doubles kind of >>> works, it's annoying to see domains slightly out of order when >>> sorting by cpu%.

Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-14 Thread Leigh Brown
On 2024-05-14 13:07, Andrew Cooper wrote: On 14/05/2024 9:13 am, Leigh Brown wrote: Although using integer comparison to compare doubles kind of works, it's annoying to see domains slightly out of order when sorting by cpu%. Add a compare_dbl() function and update compare_cpu_pct() to call it.

Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-14 Thread Leigh Brown
Hello, On 2024-05-14 13:07, Andrew Cooper wrote: On 14/05/2024 9:13 am, Leigh Brown wrote: Although using integer comparison to compare doubles kind of works, it's annoying to see domains slightly out of order when sorting by cpu%. Add a compare_dbl() function and update compare_cpu_pct() to

Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-14 Thread Jan Beulich
On 14.05.2024 14:07, Andrew Cooper wrote: > On 14/05/2024 9:13 am, Leigh Brown wrote: >> Although using integer comparison to compare doubles kind of >> works, it's annoying to see domains slightly out of order when >> sorting by cpu%. >> >> Add a compare_dbl() function and update

Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-14 Thread Andrew Cooper
On 14/05/2024 9:13 am, Leigh Brown wrote: > Although using integer comparison to compare doubles kind of > works, it's annoying to see domains slightly out of order when > sorting by cpu%. > > Add a compare_dbl() function and update compare_cpu_pct() to > call it. > > Signed-off-by: Leigh Brown >