Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-10 Thread Jan Beulich
On 10.06.2025 20:02, dm...@proton.me wrote: > On Tue, Jun 10, 2025 at 12:24:57PM +0100, Andrew Cooper wrote: >> Separately, 200 is a silly and arbitrary number.  Furthermore the >> allocation is unconditional, despite the fact that in !VERSBOSE builds, >> domUs can't use this facility.  Also, where

Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-10 Thread dmkhn
On Tue, Jun 10, 2025 at 12:24:57PM +0100, Andrew Cooper wrote: > On 10/06/2025 9:10 am, Jan Beulich wrote: > > On 06.06.2025 21:49, dm...@proton.me wrote: > >> From: Denis Mukhin > >> > >> Group all pbuf-related data structures under domain's console field. > > Fine with me in principle, as I was

Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-10 Thread dmkhn
On Tue, Jun 10, 2025 at 10:10:44AM +0200, Jan Beulich wrote: > On 06.06.2025 21:49, dm...@proton.me wrote: > > From: Denis Mukhin > > > > Group all pbuf-related data structures under domain's console field. > > Fine with me in principle, as I was indeed wondering about the lack of > grouping when

Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-10 Thread Andrew Cooper
On 10/06/2025 9:10 am, Jan Beulich wrote: > On 06.06.2025 21:49, dm...@proton.me wrote: >> From: Denis Mukhin >> >> Group all pbuf-related data structures under domain's console field. > Fine with me in principle, as I was indeed wondering about the lack of > grouping when the sub-struct was intro

Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-10 Thread Jan Beulich
On 07.06.2025 01:06, dm...@proton.me wrote: > On Fri, Jun 06, 2025 at 08:24:44PM +, Teddy Astie wrote: >> Le 06/06/2025 à 21:51, dm...@proton.me a écrit : >>> --- a/xen/drivers/char/console.c >>> +++ b/xen/drivers/char/console.c >>> @@ -769,22 +769,25 @@ static long >>> guest_console_write(XEN

Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-10 Thread Jan Beulich
On 06.06.2025 21:49, dm...@proton.me wrote: > From: Denis Mukhin > > Group all pbuf-related data structures under domain's console field. Fine with me in principle, as I was indeed wondering about the lack of grouping when the sub-struct was introduced, but ... > @@ -654,6 +648,12 @@ struct dom

Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-06 Thread dmkhn
On Fri, Jun 06, 2025 at 08:24:44PM +, Teddy Astie wrote: > Hello, > > Le 06/06/2025 à 21:51, dm...@proton.me a écrit : > > From: Denis Mukhin > > > > Group all pbuf-related data structures under domain's console field. > > > > No functional change. > > > > Signed-off-by: Denis Mukhin > > ---

Re: [PATCH v1] xen/console: group pbuf under console field

2025-06-06 Thread Teddy Astie
Hello, Le 06/06/2025 à 21:51, dm...@proton.me a écrit : > From: Denis Mukhin > > Group all pbuf-related data structures under domain's console field. > > No functional change. > > Signed-off-by: Denis Mukhin > --- > xen/arch/x86/hvm/hvm.c | 14 +++--- > xen/common/domain.c

[PATCH v1] xen/console: group pbuf under console field

2025-06-06 Thread dmkhn
From: Denis Mukhin Group all pbuf-related data structures under domain's console field. No functional change. Signed-off-by: Denis Mukhin --- xen/arch/x86/hvm/hvm.c | 14 +++--- xen/common/domain.c| 8 xen/drivers/char/console.c | 19 +++ xen/incl