Re: [PATCH v2] xen: remove

2023-11-28 Thread Shawn Anastasio
My apologies for the delay on this and thank you for reaching to me for the ping, Oleksii. Acked-by: Shawn Anastasio On 11/27/23 4:26 AM, Oleksii wrote: > Hello Shawn, > > Could you kindly review the patch when you have a moment? > It can help with merging other patch series. > > Thanks in

Re: [PATCH v2] xen: remove

2023-11-27 Thread Oleksii
Hello Shawn, Could you kindly review the patch when you have a moment? It can help with merging other patch series. Thanks in advance. ~ Oleksii On Tue, 2023-10-31 at 16:28 +0200, Oleksii Kurochko wrote: > only declares udelay() function so udelay() > declaration was moved to xen/delay.h. >

Re: [PATCH v2] xen: remove

2023-11-15 Thread Oleksii
On Wed, 2023-11-15 at 11:24 +0100, Jan Beulich wrote: > On 31.10.2023 15:28, Oleksii Kurochko wrote: > > only declares udelay() function so udelay() > > declaration was moved to xen/delay.h. > > > > For x86, __udelay() was renamed to udelay() and removed > > inclusion of in x86 code. > > > >

Re: [PATCH v2] xen: remove

2023-11-15 Thread Jan Beulich
On 31.10.2023 15:28, Oleksii Kurochko wrote: > only declares udelay() function so udelay() > declaration was moved to xen/delay.h. > > For x86, __udelay() was renamed to udelay() and removed > inclusion of in x86 code. > > For ppc, udelay() stub definition was moved to ppc/stubs.c. > >

Re: [PATCH v2] xen: remove

2023-11-10 Thread Oleksii
On Fri, 2023-11-10 at 10:33 +0100, Jan Beulich wrote: > On 10.11.2023 10:30, Oleksii wrote: > > On Tue, 2023-10-31 at 16:28 +0200, Oleksii Kurochko wrote: > > > only declares udelay() function so udelay() > > > declaration was moved to xen/delay.h. > > > > > > For x86, __udelay() was renamed to

Re: [PATCH v2] xen: remove

2023-11-10 Thread Jan Beulich
On 10.11.2023 10:30, Oleksii wrote: > On Tue, 2023-10-31 at 16:28 +0200, Oleksii Kurochko wrote: >> only declares udelay() function so udelay() >> declaration was moved to xen/delay.h. >> >> For x86, __udelay() was renamed to udelay() and removed >> inclusion of in x86 code. >> >> For ppc,

Re: [PATCH v2] xen: remove

2023-11-10 Thread Oleksii
Hi all, On Tue, 2023-10-31 at 16:28 +0200, Oleksii Kurochko wrote: > only declares udelay() function so udelay() > declaration was moved to xen/delay.h. > > For x86, __udelay() was renamed to udelay() and removed > inclusion of in x86 code. > > For ppc, udelay() stub definition was moved to

Re: [PATCH v2] xen: remove

2023-10-31 Thread Julien Grall
On 31/10/2023 14:28, Oleksii Kurochko wrote: only declares udelay() function so udelay() declaration was moved to xen/delay.h. For x86, __udelay() was renamed to udelay() and removed inclusion of in x86 code. For ppc, udelay() stub definition was moved to ppc/stubs.c. Suggested-by: Jan

[PATCH v2] xen: remove

2023-10-31 Thread Oleksii Kurochko
only declares udelay() function so udelay() declaration was moved to xen/delay.h. For x86, __udelay() was renamed to udelay() and removed inclusion of in x86 code. For ppc, udelay() stub definition was moved to ppc/stubs.c. Suggested-by: Jan Beulich Signed-off-by: Oleksii Kurochko

Re: [PATCH v2] xen: Remove trigraphs from comments

2022-12-06 Thread Stefano Stabellini
On Tue, 6 Dec 2022, Michal Orzel wrote: > MISRA C rule 4.2 states that trigraphs (sequences of two question marks > followed by a specified third character [=/'()!<>-]) should not be used. > This applies to both code and comments. Thankfully, we do not use them > in the code, but still there are

[PATCH v2] xen: Remove trigraphs from comments

2022-12-06 Thread Michal Orzel
MISRA C rule 4.2 states that trigraphs (sequences of two question marks followed by a specified third character [=/'()!<>-]) should not be used. This applies to both code and comments. Thankfully, we do not use them in the code, but still there are some comments where they are accidentally used.

Re: [Xen-devel] [PATCH v2] xen: remove on-stack cpumask from stop_machine_run()

2019-05-31 Thread Andrew Cooper
On 31/05/2019 06:06, Jan Beulich wrote: On 31.05.19 at 13:53, wrote: >> The "allbutself" cpumask in stop_machine_run() is not needed. Instead >> of allocating it on the stack it can easily be avoided. >> >> Signed-off-by: Juergen Gross > Reviewed-by: Jan Beulich LGTM.  Acked-by: Andrew

Re: [Xen-devel] [PATCH v2] xen: remove on-stack cpumask from stop_machine_run()

2019-05-31 Thread Jan Beulich
>>> On 31.05.19 at 13:53, wrote: > The "allbutself" cpumask in stop_machine_run() is not needed. Instead > of allocating it on the stack it can easily be avoided. > > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich with one further remark: > --- a/xen/common/stop_machine.c > +++

[Xen-devel] [PATCH v2] xen: remove on-stack cpumask from stop_machine_run()

2019-05-31 Thread Juergen Gross
The "allbutself" cpumask in stop_machine_run() is not needed. Instead of allocating it on the stack it can easily be avoided. Signed-off-by: Juergen Gross --- xen/common/stop_machine.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/xen/common/stop_machine.c