On 13.10.2020 16:08, Roger Pau Monné wrote:
> On Fri, Oct 02, 2020 at 10:48:07AM +0200, Jan Beulich wrote:
>> On 30.09.2020 12:40, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/hvm/vlapic.c
>>> +++ b/xen/arch/x86/hvm/vlapic.c
>>> @@ -459,13 +459,10 @@ void vlapic_EOI_set(struct vlapic *vlapic)
>>>
On Fri, Oct 02, 2020 at 10:48:07AM +0200, Jan Beulich wrote:
> On 30.09.2020 12:40, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/hvm/vlapic.c
> > +++ b/xen/arch/x86/hvm/vlapic.c
> > @@ -459,13 +459,10 @@ void vlapic_EOI_set(struct vlapic *vlapic)
> >
> > void vlapic_handle_EOI(struct vlapic
> > ; Durrant, Paul
> >
> > Subject: RE: [EXTERNAL] [PATCH v2 01/11] x86/hvm: drop vcpu parameter from
> > vlapic EOI callbacks
> >
> > CAUTION: This email originated from outside of the organization. Do not
> > click links or open
> -Original Message-
> From: Jan Beulich
> Sent: 02 October 2020 09:48
> To: Roger Pau Monne ; Wei Liu ; Paul
> Durrant
> Cc: xen-devel@lists.xenproject.org; Andrew Cooper
> ; Durrant, Paul
>
> Subject: RE: [EXTERNAL] [PATCH v2 01/11] x86/hvm: drop vcpu p
On 30.09.2020 12:40, Roger Pau Monne wrote:
> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -459,13 +459,10 @@ void vlapic_EOI_set(struct vlapic *vlapic)
>
> void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector)
> {
> -struct vcpu *v = vlapic_vcpu(vlapic);
> -
> -Original Message-
> From: Roger Pau Monne
> Sent: 30 September 2020 11:41
> To: xen-devel@lists.xenproject.org
> Cc: Roger Pau Monne ; Jan Beulich ;
> Andrew Cooper
> ; Wei Liu ; Paul Durrant
> ; Paul Durrant
>
> Subject: [PATCH v2 01/11] x86/hvm: drop
EOIs are always executed in guest vCPU context, so there's no reason to
pass a vCPU parameter around as can be fetched from current.
While there make the vector parameter of both callbacks unsigned int.
No functional change intended.
Suggested-by: Paul Durrant
Signed-off-by: Roger Pau Monné
