Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus

2020-06-08 Thread Stefano Stabellini
On Mon, 8 Jun 2020, Christoph Hellwig wrote: > On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > The parameter is unused in this patch. > > No functional changes. > > This looks weird. I'm pretty sure you are going to use it later, but > wh

Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus

2020-06-08 Thread Christoph Hellwig
On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote: > From: Stefano Stabellini > > The parameter is unused in this patch. > No functional changes. This looks weird. I'm pretty sure you are going to use it later, but why not just add the argument when it actually is used?

[PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus

2020-06-03 Thread Stefano Stabellini
From: Stefano Stabellini The parameter is unused in this patch. No functional changes. Signed-off-by: Stefano Stabellini Tested-by: Corey Minyard Tested-by: Roman Shaposhnik --- drivers/xen/swiotlb-xen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drive