Re: [PATCH v2 1/4] IOMMU/x86: switch to alternatives-call patching in further instances

2022-01-28 Thread Andrew Cooper
On 28/01/2022 10:36, Jan Beulich wrote: > On 28.01.2022 10:28, Durrant, Paul wrote: >> On 27/01/2022 14:47, Jan Beulich wrote: >>> @@ -1457,24 +1462,24 @@ static int iommu_get_device_group( >>> if ( !is_iommu_enabled(d) || !ops->get_device_group_id ) >>> return 0; >>> >>> -

Re: [PATCH v2 1/4] IOMMU/x86: switch to alternatives-call patching in further instances

2022-01-28 Thread Rahul Singh
Hi Jan, > On 27 Jan 2022, at 2:47 pm, Jan Beulich wrote: > > This is, once again, to limit the number of indirect calls as much as > possible. The only hook invocation which isn't sensible to convert is > setup(). And of course Arm-only use sites are left alone as well. > > Note regarding the

Re: [PATCH v2 1/4] IOMMU/x86: switch to alternatives-call patching in further instances

2022-01-28 Thread Jan Beulich
On 28.01.2022 10:28, Durrant, Paul wrote: > On 27/01/2022 14:47, Jan Beulich wrote: >> @@ -1457,24 +1462,24 @@ static int iommu_get_device_group( >> if ( !is_iommu_enabled(d) || !ops->get_device_group_id ) >> return 0; >> >> -group_id = ops->get_device_group_id(seg, bus,

Re: [PATCH v2 1/4] IOMMU/x86: switch to alternatives-call patching in further instances

2022-01-28 Thread Durrant, Paul
On 27/01/2022 14:47, Jan Beulich wrote: This is, once again, to limit the number of indirect calls as much as possible. The only hook invocation which isn't sensible to convert is setup(). And of course Arm-only use sites are left alone as well. Note regarding the introduction / use of local

[PATCH v2 1/4] IOMMU/x86: switch to alternatives-call patching in further instances

2022-01-27 Thread Jan Beulich
This is, once again, to limit the number of indirect calls as much as possible. The only hook invocation which isn't sensible to convert is setup(). And of course Arm-only use sites are left alone as well. Note regarding the introduction / use of local variables in pci.c: struct pci_dev's