Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-04-03 Thread Jan Beulich
On 03.04.2023 06:21, Marek Marczykowski-Górecki wrote: > On Tue, Mar 28, 2023 at 03:03:17PM +0200, Jan Beulich wrote: >> On 28.03.2023 14:52, Marek Marczykowski-Górecki wrote: >>> I mean, technically I can probably merge those two handlers together, >>> but I don't think it will result in nicer

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-04-02 Thread Marek Marczykowski-Górecki
On Tue, Mar 28, 2023 at 03:03:17PM +0200, Jan Beulich wrote: > On 28.03.2023 14:52, Marek Marczykowski-Górecki wrote: > > On Tue, Mar 28, 2023 at 02:34:23PM +0200, Jan Beulich wrote: > >> On 28.03.2023 14:05, Marek Marczykowski-Górecki wrote: > >>> On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-28 Thread Roger Pau Monné
On Tue, Mar 28, 2023 at 03:03:17PM +0200, Jan Beulich wrote: > On 28.03.2023 14:52, Marek Marczykowski-Górecki wrote: > > On Tue, Mar 28, 2023 at 02:34:23PM +0200, Jan Beulich wrote: > >> On 28.03.2023 14:05, Marek Marczykowski-Górecki wrote: > >>> On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-28 Thread Jan Beulich
On 28.03.2023 14:52, Marek Marczykowski-Górecki wrote: > On Tue, Mar 28, 2023 at 02:34:23PM +0200, Jan Beulich wrote: >> On 28.03.2023 14:05, Marek Marczykowski-Górecki wrote: >>> On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger Pau Monné wrote: On Sat, Mar 25, 2023 at 03:49:23AM +0100, Marek

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-28 Thread Roger Pau Monné
On Tue, Mar 28, 2023 at 02:05:14PM +0200, Marek Marczykowski-Górecki wrote: > On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger Pau Monné wrote: > > On Sat, Mar 25, 2023 at 03:49:23AM +0100, Marek Marczykowski-Górecki wrote: > > > + address >= entry->gtable + entry->table_len ) > > > +

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-28 Thread Marek Marczykowski-Górecki
On Tue, Mar 28, 2023 at 02:34:23PM +0200, Jan Beulich wrote: > On 28.03.2023 14:05, Marek Marczykowski-Górecki wrote: > > On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger Pau Monné wrote: > >> On Sat, Mar 25, 2023 at 03:49:23AM +0100, Marek Marczykowski-Górecki wrote: > >>> +static bool cf_check

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-28 Thread Jan Beulich
On 28.03.2023 14:05, Marek Marczykowski-Górecki wrote: > On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger Pau Monné wrote: >> On Sat, Mar 25, 2023 at 03:49:23AM +0100, Marek Marczykowski-Górecki wrote: >>> +static bool cf_check msixtbl_page_accept( >>> +const struct hvm_io_handler *handler,

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-28 Thread Marek Marczykowski-Górecki
On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger Pau Monné wrote: > On Sat, Mar 25, 2023 at 03:49:23AM +0100, Marek Marczykowski-Górecki wrote: > > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > > on the same page as MSI-X table. Device model (especially one in > >

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-28 Thread Roger Pau Monné
On Sat, Mar 25, 2023 at 03:49:23AM +0100, Marek Marczykowski-Górecki wrote: > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > on the same page as MSI-X table. Device model (especially one in > stubdomain) cannot really handle those, as direct writes to that page is >

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-27 Thread Andrew Cooper
On 25/03/2023 2:49 am, Marek Marczykowski-Górecki wrote: > diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c > index 9c82bf9b4ec2..9293009a4075 100644 > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -438,6 +438,152 @@ static const struct hvm_io_ops

[PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-24 Thread Marek Marczykowski-Górecki
Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers on the same page as MSI-X table. Device model (especially one in stubdomain) cannot really handle those, as direct writes to that page is refused (page is on the mmio_ro_ranges list). Instead, add internal ioreq server that