Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-05-06 Thread Julien Grall
Hi Jan, On 05/05/2020 07:26, Jan Beulich wrote: On 22.04.2020 10:26, Roger Pau Monné wrote: On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: First of all avoid excessive conversions. copy_{from,to}_guest(), for example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}().

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-05-05 Thread Jan Beulich
On 22.04.2020 10:26, Roger Pau Monné wrote: > On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: >> First of all avoid excessive conversions. copy_{from,to}_guest(), for >> example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). >> >> Further >> - do_physdev_op_compat() didn't

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-29 Thread Julien Grall
Hi, On 22/04/2020 10:32, Jan Beulich wrote: On 22.04.2020 10:17, Julien Grall wrote: On 21/04/2020 10:13, Jan Beulich wrote: First of all avoid excessive conversions. copy_{from,to}_guest(), for example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). Further - do_physdev_op_compat()

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-22 Thread Jan Beulich
On 22.04.2020 10:17, Julien Grall wrote: > On 21/04/2020 10:13, Jan Beulich wrote: >> First of all avoid excessive conversions. copy_{from,to}_guest(), for >> example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). >> >> Further >> - do_physdev_op_compat() didn't use the param form for its

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-22 Thread Jan Beulich
On 22.04.2020 10:26, Roger Pau Monné wrote: > On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: >> --- a/xen/drivers/acpi/pmstat.c >> +++ b/xen/drivers/acpi/pmstat.c >> @@ -492,7 +492,7 @@ int do_pm_op(struct xen_sysctl_pm_op *op >> return ret; >> } >> >> -int

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-22 Thread Roger Pau Monné
On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: > First of all avoid excessive conversions. copy_{from,to}_guest(), for > example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). > > Further > - do_physdev_op_compat() didn't use the param form for its parameter, > -

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-22 Thread Julien Grall
Hi, On 22/04/2020 08:56, Roger Pau Monné wrote: On Tue, Apr 21, 2020 at 07:44:55PM +0100, Julien Grall wrote: Hi, On 21/04/2020 18:30, Roger Pau Monné wrote: On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: First of all avoid excessive conversions. copy_{from,to}_guest(), for

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-22 Thread Julien Grall
Hi Jan, On 21/04/2020 10:13, Jan Beulich wrote: First of all avoid excessive conversions. copy_{from,to}_guest(), for example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). Further - do_physdev_op_compat() didn't use the param form for its parameter, - {hap,shadow}_track_dirty_vram()

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-22 Thread Roger Pau Monné
On Tue, Apr 21, 2020 at 07:44:55PM +0100, Julien Grall wrote: > Hi, > > On 21/04/2020 18:30, Roger Pau Monné wrote: > > On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: > > > First of all avoid excessive conversions. copy_{from,to}_guest(), for > > > example, work fine with all of

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-21 Thread Julien Grall
Hi, On 21/04/2020 18:30, Roger Pau Monné wrote: On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: First of all avoid excessive conversions. copy_{from,to}_guest(), for example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). I'm not sure I understand the difference between

Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-21 Thread Roger Pau Monné
On Tue, Apr 21, 2020 at 11:13:23AM +0200, Jan Beulich wrote: > First of all avoid excessive conversions. copy_{from,to}_guest(), for > example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). I'm not sure I understand the difference between those two, as they are both placeholders for

[PATCH v2 4/4] x86: adjustments to guest handle treatment

2020-04-21 Thread Jan Beulich
First of all avoid excessive conversions. copy_{from,to}_guest(), for example, work fine with all of XEN_GUEST_HANDLE{,_64,_PARAM}(). Further - do_physdev_op_compat() didn't use the param form for its parameter, - {hap,shadow}_track_dirty_vram() wrongly used the param form, - compat processor Px