Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-11-02 Thread Oleksandr Andrushchenko
On 02.11.21 12:03, Roger Pau Monné wrote: > On Mon, Nov 01, 2021 at 09:18:17AM +, Oleksandr Andrushchenko wrote: +if ( rc ) +gdprintk(XENLOG_ERR, + "%pp: failed to add BAR handlers for dom%pd: %d\n", + >sbdf, d, rc); +

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-11-02 Thread Roger Pau Monné
On Mon, Nov 01, 2021 at 09:18:17AM +, Oleksandr Andrushchenko wrote: > > >> +if ( rc ) > >> +gdprintk(XENLOG_ERR, > >> + "%pp: failed to add BAR handlers for dom%pd: %d\n", > >> + >sbdf, d, rc); > >> +return rc; > >> +} > >> + > >> +int

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-11-01 Thread Oleksandr Andrushchenko
>> +if ( rc ) >> +gdprintk(XENLOG_ERR, >> + "%pp: failed to add BAR handlers for dom%pd: %d\n", >> + >sbdf, d, rc); >> +return rc; >> +} >> + >> +int vpci_bar_remove_handlers(const struct domain *d, const struct pci_dev >> *pdev) >> +{ >> +/*

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-10-25 Thread Roger Pau Monné
On Thu, Sep 30, 2021 at 10:52:16AM +0300, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Add relevant vpci register handlers when assigning PCI device to a domain > and remove those when de-assigning. This allows having different > handlers for different domains, e.g. hwdom

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-10-15 Thread Jan Beulich
On 13.10.2021 17:38, Roger Pau Monné wrote: > On Thu, Oct 07, 2021 at 09:22:36AM +0200, Jan Beulich wrote: >> On 04.10.2021 07:58, Oleksandr Andrushchenko wrote: >>> >>> >>> On 01.10.21 16:26, Jan Beulich wrote: On 30.09.2021 09:52, Oleksandr Andrushchenko wrote: > @@ -445,14 +456,25 @@

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-10-13 Thread Roger Pau Monné
On Thu, Oct 07, 2021 at 09:22:36AM +0200, Jan Beulich wrote: > On 04.10.2021 07:58, Oleksandr Andrushchenko wrote: > > > > > > On 01.10.21 16:26, Jan Beulich wrote: > >> On 30.09.2021 09:52, Oleksandr Andrushchenko wrote: > >>> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-10-07 Thread Jan Beulich
On 04.10.2021 07:58, Oleksandr Andrushchenko wrote: > > > On 01.10.21 16:26, Jan Beulich wrote: >> On 30.09.2021 09:52, Oleksandr Andrushchenko wrote: >>> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, >>> unsigned int reg, >>> rom->addr = val &

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-10-03 Thread Oleksandr Andrushchenko
On 01.10.21 16:26, Jan Beulich wrote: > On 30.09.2021 09:52, Oleksandr Andrushchenko wrote: >> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, >> unsigned int reg, >> rom->addr = val & PCI_ROM_ADDRESS_MASK; >> } >> >> -static int add_bar_handlers(const

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-10-01 Thread Jan Beulich
On 30.09.2021 09:52, Oleksandr Andrushchenko wrote: > @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, > unsigned int reg, > rom->addr = val & PCI_ROM_ADDRESS_MASK; > } > > -static int add_bar_handlers(const struct pci_dev *pdev) > +static void

[PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-09-30 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Add relevant vpci register handlers when assigning PCI device to a domain and remove those when de-assigning. This allows having different handlers for different domains, e.g. hwdom and other guests. Use stubs for guest domains for now. Signed-off-by: Oleksandr