Re: [PATCH v5 02/10] x86/mm: Avoid hard-coding PAT in get_page_from_l1e()

2022-12-22 Thread Demi Marie Obenour
On Thu, Dec 22, 2022 at 10:51:08AM +0100, Jan Beulich wrote: > On 20.12.2022 09:19, Jan Beulich wrote: > > On 20.12.2022 02:07, Demi Marie Obenour wrote: > >> get_page_from_l1e() relied on Xen's choice of PAT, which is brittle in > >> the face of future PAT changes. Instead, compute the actual

Re: [PATCH v5 02/10] x86/mm: Avoid hard-coding PAT in get_page_from_l1e()

2022-12-22 Thread Jan Beulich
On 20.12.2022 09:19, Jan Beulich wrote: > On 20.12.2022 02:07, Demi Marie Obenour wrote: >> get_page_from_l1e() relied on Xen's choice of PAT, which is brittle in >> the face of future PAT changes. Instead, compute the actual cacheability >> used by the CPU and switch on that, as this will work

Re: [PATCH v5 02/10] x86/mm: Avoid hard-coding PAT in get_page_from_l1e()

2022-12-20 Thread Jan Beulich
On 20.12.2022 02:07, Demi Marie Obenour wrote: > get_page_from_l1e() relied on Xen's choice of PAT, which is brittle in > the face of future PAT changes. Instead, compute the actual cacheability > used by the CPU and switch on that, as this will work no matter what PAT > Xen uses. > > No

[PATCH v5 02/10] x86/mm: Avoid hard-coding PAT in get_page_from_l1e()

2022-12-19 Thread Demi Marie Obenour
get_page_from_l1e() relied on Xen's choice of PAT, which is brittle in the face of future PAT changes. Instead, compute the actual cacheability used by the CPU and switch on that, as this will work no matter what PAT Xen uses. No functional change intended. This code is itself questionable and