Re: [PATCH v5 02/11] xen/arm: avoid repetitive checking in process_shm_node

2023-12-07 Thread Penny Zheng
Hi Michal On 2023/12/6 19:35, Michal Orzel wrote: Hi Penny, On 06/12/2023 10:06, Penny Zheng wrote: Putting overlap and overflow checking in the loop is causing repetitive operation, so this commit extracts both checking outside the loop. Signed-off-by: Penny Zheng In general the patch

Re: [PATCH v5 02/11] xen/arm: avoid repetitive checking in process_shm_node

2023-12-06 Thread Michal Orzel
Hi Penny, On 06/12/2023 10:06, Penny Zheng wrote: > > > Putting overlap and overflow checking in the loop is causing repetitive > operation, so this commit extracts both checking outside the loop. > > Signed-off-by: Penny Zheng In general the patch looks good to me: Reviewed-by: Michal Orzel

[PATCH v5 02/11] xen/arm: avoid repetitive checking in process_shm_node

2023-12-06 Thread Penny Zheng
Putting overlap and overflow checking in the loop is causing repetitive operation, so this commit extracts both checking outside the loop. Signed-off-by: Penny Zheng --- v6: new commit --- xen/arch/arm/static-shmem.c | 39 +++-- 1 file changed, 16 insertions(+),