Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > Add cmdline boot option "pci-passthrough = = " to enable or > disable the PCI passthrough support on ARM. > > Signed-off-by: Rahul Singh > Reviewed-by: Stefano Stabellini > Reviewed-by: Bertrand Marquis Acked-by: Jan Beulich

Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-07 Thread Rahul Singh
Hi Jan, > On 7 Oct 2021, at 9:27 am, Jan Beulich wrote: > > On 06.10.2021 19:40, Rahul Singh wrote: >> @@ -62,8 +63,19 @@ static int __init acpi_pci_init(void) >> } >> #endif >> >> +/* By default pci passthrough is disabled. */ >> +bool __read_mostly pci_passthrough_enabled; > > You properly

Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > @@ -62,8 +63,19 @@ static int __init acpi_pci_init(void) > } > #endif > > +/* By default pci passthrough is disabled. */ > +bool __read_mostly pci_passthrough_enabled; You properly use "bool " here. Why ... > --- a/xen/include/asm-arm/pci.h > +++

[PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-06 Thread Rahul Singh
Add cmdline boot option "pci-passthrough = = " to enable or disable the PCI passthrough support on ARM. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Change in v5: none Change in v4: - Fixe minor comments - Added Reviewed-by: Bertrand Marquis -