Re: [PATCH v5 4/6] x86/gdbstub: Clean up includes

2022-04-21 Thread Jan Beulich
On 20.04.2022 16:13, Andrew Cooper wrote: > common/gdbstub.c wants struct gdb_context but only gets it transitively > through asm/debugger.h. None of */gdbstub.c should include asm/debugger.h so > include xen/gdbstub.h instead. > > Forward declare struct cpu_user_regs in xen/gdbstub.h so it

[PATCH v5 4/6] x86/gdbstub: Clean up includes

2022-04-20 Thread Andrew Cooper
common/gdbstub.c wants struct gdb_context but only gets it transitively through asm/debugger.h. None of */gdbstub.c should include asm/debugger.h so include xen/gdbstub.h instead. Forward declare struct cpu_user_regs in xen/gdbstub.h so it doesn't depend on the include order to compile.