Re: [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process

2020-10-16 Thread Wei Liu
On Thu, Oct 15, 2020 at 03:01:48AM +0200, Marek Marczykowski-Górecki wrote: > On Sun, Oct 11, 2020 at 06:11:39PM -0700, Elliott Mitchell wrote: > > Unexpectedly the environment variable which needs to be passed is > > $LDSHARED and not $LD. Otherwise Python may find the build `ld` instead > > of

Re: [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process

2020-10-14 Thread Elliott Mitchell
On Thu, Oct 15, 2020 at 03:02:59AM +0200, Marek Marczykowski-G??recki wrote: > On Tue, Oct 13, 2020 at 01:26:06PM +, Wei Liu wrote: > > On Sun, Oct 11, 2020 at 06:11:39PM -0700, Elliott Mitchell wrote: > > > Having looked around a bit, I believe this is a Python 2/3 compatibility > > > issue.

Re: [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process

2020-10-14 Thread Marek Marczykowski-Górecki
On Tue, Oct 13, 2020 at 01:26:06PM +, Wei Liu wrote: > On Sun, Oct 11, 2020 at 06:11:39PM -0700, Elliott Mitchell wrote: > > Unexpectedly the environment variable which needs to be passed is > > $LDSHARED and not $LD. Otherwise Python may find the build `ld` instead > > of the host `ld`. > >

Re: [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process

2020-10-14 Thread Marek Marczykowski-Górecki
On Sun, Oct 11, 2020 at 06:11:39PM -0700, Elliott Mitchell wrote: > Unexpectedly the environment variable which needs to be passed is > $LDSHARED and not $LD. Otherwise Python may find the build `ld` instead > of the host `ld`. > > Replace $(LDFLAGS) with $(SHLIB_LDFLAGS) as Python needs shared

Re: [SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process

2020-10-13 Thread Wei Liu
On Sun, Oct 11, 2020 at 06:11:39PM -0700, Elliott Mitchell wrote: > Unexpectedly the environment variable which needs to be passed is > $LDSHARED and not $LD. Otherwise Python may find the build `ld` instead > of the host `ld`. > > Replace $(LDFLAGS) with $(SHLIB_LDFLAGS) as Python needs shared

[SECOND RESEND] [PATCH] tools/python: Pass linker to Python build process

2020-10-11 Thread Elliott Mitchell
Unexpectedly the environment variable which needs to be passed is $LDSHARED and not $LD. Otherwise Python may find the build `ld` instead of the host `ld`. Replace $(LDFLAGS) with $(SHLIB_LDFLAGS) as Python needs shared objects it can load at runtime, not executables. This uses $(CC) instead of