Re: [XEN PATCH 3/9] x86/smp: drop x86_cpu_to_apicid, use cpu_data[cpu].apicid instead

2024-03-12 Thread Jan Beulich
On 12.03.2024 16:29, Krystian Hebel wrote: > On 7.02.2024 17:41, Jan Beulich wrote: >> On 02.02.2024 19:11, Julien Grall wrote: >>> On 14/11/2023 17:50, Krystian Hebel wrote: --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -54,14 +54,13 @@ bool __init

Re: [XEN PATCH 3/9] x86/smp: drop x86_cpu_to_apicid, use cpu_data[cpu].apicid instead

2024-03-12 Thread Krystian Hebel
On 8.02.2024 08:29, Jan Beulich wrote: On 14.11.2023 18:50, Krystian Hebel wrote: Both fields held the same data. Supposedly the same data only. They come from different origins, and you're hiding this quite well by leaving all sites in place where the field is written. Both items are also

Re: [XEN PATCH 3/9] x86/smp: drop x86_cpu_to_apicid, use cpu_data[cpu].apicid instead

2024-03-12 Thread Krystian Hebel
Hi, On 7.02.2024 17:41, Jan Beulich wrote: On 02.02.2024 19:11, Julien Grall wrote: Hi, On 14/11/2023 17:50, Krystian Hebel wrote: Both fields held the same data. Signed-off-by: Krystian Hebel --- xen/arch/x86/boot/x86_64.S | 8 +--- xen/arch/x86/include/asm/asm_defns.h

Re: [XEN PATCH 3/9] x86/smp: drop x86_cpu_to_apicid, use cpu_data[cpu].apicid instead

2024-02-07 Thread Jan Beulich
On 14.11.2023 18:50, Krystian Hebel wrote: > Both fields held the same data. Supposedly the same data only. They come from different origins, and you're hiding this quite well by leaving all sites in place where the field is written. Both items are also used for entirely separate purposes. So you

Re: [XEN PATCH 3/9] x86/smp: drop x86_cpu_to_apicid, use cpu_data[cpu].apicid instead

2024-02-07 Thread Jan Beulich
On 02.02.2024 19:11, Julien Grall wrote: > Hi, > > On 14/11/2023 17:50, Krystian Hebel wrote: >> Both fields held the same data. >> >> Signed-off-by: Krystian Hebel >> --- >> xen/arch/x86/boot/x86_64.S | 8 +--- >> xen/arch/x86/include/asm/asm_defns.h | 2 +- >>

Re: [XEN PATCH 3/9] x86/smp: drop x86_cpu_to_apicid, use cpu_data[cpu].apicid instead

2024-02-02 Thread Julien Grall
Hi, On 14/11/2023 17:50, Krystian Hebel wrote: Both fields held the same data. Signed-off-by: Krystian Hebel --- xen/arch/x86/boot/x86_64.S | 8 +--- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/arch/x86/include/asm/processor.h | 2 ++ xen/arch/x86/include/asm/smp.h

[XEN PATCH 3/9] x86/smp: drop x86_cpu_to_apicid, use cpu_data[cpu].apicid instead

2023-11-14 Thread Krystian Hebel
Both fields held the same data. Signed-off-by: Krystian Hebel --- xen/arch/x86/boot/x86_64.S | 8 +--- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/arch/x86/include/asm/processor.h | 2 ++ xen/arch/x86/include/asm/smp.h | 4 xen/arch/x86/numa.c