Re: [XEN PATCH 5/9] x86/smp: call x2apic_ap_setup() earlier

2024-03-13 Thread Jan Beulich
On 12.03.2024 17:02, Krystian Hebel wrote: > > On 7.02.2024 18:02, Jan Beulich wrote: >> On 14.11.2023 18:50, Krystian Hebel wrote: >>> It used to be called from smp_callin(), however BUG_ON() was invoked on >>> multiple occasions before that. It may end up calling machine_restart() >>> which

Re: [XEN PATCH 5/9] x86/smp: call x2apic_ap_setup() earlier

2024-03-12 Thread Krystian Hebel
On 7.02.2024 18:02, Jan Beulich wrote: On 14.11.2023 18:50, Krystian Hebel wrote: It used to be called from smp_callin(), however BUG_ON() was invoked on multiple occasions before that. It may end up calling machine_restart() which tries to get APIC ID for CPU running this code. If BSP

Re: [XEN PATCH 5/9] x86/smp: call x2apic_ap_setup() earlier

2024-02-07 Thread Jan Beulich
On 14.11.2023 18:50, Krystian Hebel wrote: > It used to be called from smp_callin(), however BUG_ON() was invoked on > multiple occasions before that. It may end up calling machine_restart() > which tries to get APIC ID for CPU running this code. If BSP detected > that x2APIC is enabled,

[XEN PATCH 5/9] x86/smp: call x2apic_ap_setup() earlier

2023-11-14 Thread Krystian Hebel
It used to be called from smp_callin(), however BUG_ON() was invoked on multiple occasions before that. It may end up calling machine_restart() which tries to get APIC ID for CPU running this code. If BSP detected that x2APIC is enabled, get_apic_id() will try to use it for all CPUs. Enabling