Re: [XEN PATCH 6/9] x86/shutdown: protect against recurrent machine_restart()

2024-03-13 Thread Jan Beulich
On 12.03.2024 17:05, Krystian Hebel wrote: > > On 8.02.2024 12:30, Jan Beulich wrote: >> On 14.11.2023 18:50, Krystian Hebel wrote: >>> If multiple CPUs called machine_restart() before actual restart took >>> place, but after boot CPU declared itself not online, >> Can you help me please in

Re: [XEN PATCH 6/9] x86/shutdown: protect against recurrent machine_restart()

2024-03-12 Thread Krystian Hebel
On 8.02.2024 12:30, Jan Beulich wrote: On 14.11.2023 18:50, Krystian Hebel wrote: If multiple CPUs called machine_restart() before actual restart took place, but after boot CPU declared itself not online, Can you help me please in identifying where this operation is? I can see two places

Re: [XEN PATCH 6/9] x86/shutdown: protect against recurrent machine_restart()

2024-02-08 Thread Jan Beulich
On 14.11.2023 18:50, Krystian Hebel wrote: > If multiple CPUs called machine_restart() before actual restart took > place, but after boot CPU declared itself not online, Can you help me please in identifying where this operation is? I can see two places where a CPU is removed from cpu_online_map,

[XEN PATCH 6/9] x86/shutdown: protect against recurrent machine_restart()

2023-11-14 Thread Krystian Hebel
If multiple CPUs called machine_restart() before actual restart took place, but after boot CPU declared itself not online, ASSERT in on_selected_cpus() will fail. Few calls later execution would end up in machine_restart() again, with another frame on call stack for new exception. To protect