On 19.10.2023 10:04, Nicola Vetrini wrote:
>
>>> - vmx_asm_vmexit_handler
>>>
>
> Isn't this just a declaration:
>
> void nocall vmx_asm_vmexit_handler(void);
>
> while the function to be deviated is this:
>
> void vmx_vmexit_handler(struct cpu_user_regs *regs)
>
> Am I correct?
Looks like y
- vmx_asm_vmexit_handler
Isn't this just a declaration:
void nocall vmx_asm_vmexit_handler(void);
while the function to be deviated is this:
void vmx_vmexit_handler(struct cpu_user_regs *regs)
Am I correct?
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
On 19.10.2023 02:07, Stefano Stabellini wrote:
> On Tue, 17 Oct 2023, Jan Beulich wrote:
>>> Jan, for this specific patch, I don't think we have the scan including
>>> Intel vmx files yet. Nicola please correct me if I am wrong. So Nicola
>>> wouldn't be able to easily expand this patch to also cov
On Tue, 17 Oct 2023, Jan Beulich wrote:
> > Jan, for this specific patch, I don't think we have the scan including
> > Intel vmx files yet. Nicola please correct me if I am wrong. So Nicola
> > wouldn't be able to easily expand this patch to also cover Intel vmx
> > violations of this rule because
Now, concrete action items. Nicola, I think we should look into having
a
larger-than-usual ECLAIR scan every week which includes all of Intel
files and in general as much as possible of the codebase.
This can be arranged. I'll keep you posted about this.
--
Nicola Vetrini, BSc
Software Eng
On 17.10.2023 00:34, Stefano Stabellini wrote:
> On Mon, 16 Oct 2023, Jan Beulich wrote:
>> On 09.10.2023 08:54, Nicola Vetrini wrote:
>>> As stated in rules.rst, functions used only in asm code
>>> are allowed to have no prior declaration visible when being
>>> defined, hence these functions are d
On Mon, 16 Oct 2023, Jan Beulich wrote:
> On 09.10.2023 08:54, Nicola Vetrini wrote:
> > As stated in rules.rst, functions used only in asm code
> > are allowed to have no prior declaration visible when being
> > defined, hence these functions are deviated.
> > This also fixes violations of MISRA C
On 09.10.2023 08:54, Nicola Vetrini wrote:
> As stated in rules.rst, functions used only in asm code
> are allowed to have no prior declaration visible when being
> defined, hence these functions are deviated.
> This also fixes violations of MISRA C:2012 Rule 8.4.
>
> Signed-off-by: Nicola Vetrini
As stated in rules.rst, functions used only in asm code
are allowed to have no prior declaration visible when being
defined, hence these functions are deviated.
This also fixes violations of MISRA C:2012 Rule 8.4.
Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
---
xen/arch/x86/hv