Re: [XTF 2/4] lib: always append CR after LF in vsnprintf()

2020-04-20 Thread Wieczorkiewicz, Pawel
> On 20. Apr 2020, at 21:26, Andrew Cooper wrote: > > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 16/04/2020 12:36, Wieczorkiewicz, Pawel wrote: >>> Unf

Re: [XTF 2/4] lib: always append CR after LF in vsnprintf()

2020-04-20 Thread Andrew Cooper
On 20/04/2020 20:26, Andrew Cooper wrote: --- common/libc/vsnprintf.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/common/libc/vsnprintf.c b/common/libc/vsnprintf.c index a49fd30..3202137 100644 --- a/common/libc/vsnprintf.c +++ b/common/libc

Re: [XTF 2/4] lib: always append CR after LF in vsnprintf()

2020-04-20 Thread Andrew Cooper
On 16/04/2020 12:36, Wieczorkiewicz, Pawel wrote: >> Unfortunately, this comes with collateral damage. >> >> # ./xtf-runner hvm64 example >> Executing 'xl create -p tests/example/test-hvm64-example.cfg' >> Executing 'xl console test-hvm64-example' >> Executing 'xl unpause test-hvm64-example' >> ---

Re: [XTF 2/4] lib: always append CR after LF in vsnprintf()

2020-04-16 Thread Wieczorkiewicz, Pawel
> On 16. Apr 2020, at 12:18, Andrew Cooper wrote: > > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 16/04/2020 10:41, Pawel Wieczorkiewicz wrote: >> The

Re: [XTF 2/4] lib: always append CR after LF in vsnprintf()

2020-04-16 Thread Andrew Cooper
On 16/04/2020 10:41, Pawel Wieczorkiewicz wrote: > The explicit LFCR sequence guarantees proper line by line formatting > in the output. > The '\n' character alone on some terminals is not automatically > converted to LFCR. > > Signed-off-by: Pawel Wieczorkiewicz Up until now, all console destina

[XTF 2/4] lib: always append CR after LF in vsnprintf()

2020-04-16 Thread Pawel Wieczorkiewicz
The explicit LFCR sequence guarantees proper line by line formatting in the output. The '\n' character alone on some terminals is not automatically converted to LFCR. Signed-off-by: Pawel Wieczorkiewicz --- common/libc/vsnprintf.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/c