Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-26 Thread Jim Fehlig
On 3/25/20 1:11 AM, Jan Beulich wrote: On 24.03.2020 19:39, Julien Grall wrote: On 24/03/2020 16:13, Jan Beulich wrote: On 24.03.2020 16:21, Hongyan Xia wrote: From: Hongyan Xia In contrast, after dropping that commit, parallel domain destructions will just fail to take the domctl lock,

Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-26 Thread Hongyan Xia
On Wed, 2020-03-25 at 08:11 +0100, Jan Beulich wrote: > On 24.03.2020 19:39, Julien Grall wrote: > > On 24/03/2020 16:13, Jan Beulich wrote: > > > On 24.03.2020 16:21, Hongyan Xia wrote: > > > > From: Hongyan Xia > > > > In contrast, > > > > after dropping that commit, parallel domain

Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-25 Thread Jan Beulich
On 24.03.2020 19:39, Julien Grall wrote: > On 24/03/2020 16:13, Jan Beulich wrote: >> On 24.03.2020 16:21, Hongyan Xia wrote: >>> From: Hongyan Xia >>> In contrast, >>> after dropping that commit, parallel domain destructions will just fail >>> to take the domctl lock, creating a hypercall

Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-24 Thread Julien Grall
On 24/03/2020 15:21, Hongyan Xia wrote: From: Hongyan Xia Unfortunately, even though that commit dropped the domctl lock and allowed other domctl to continue, it created severe lock contention within domain destructions themselves. Multiple domain destructions in parallel now spin for the

Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-24 Thread Julien Grall
On 24/03/2020 16:13, Jan Beulich wrote: On 24.03.2020 16:21, Hongyan Xia wrote: From: Hongyan Xia In contrast, after dropping that commit, parallel domain destructions will just fail to take the domctl lock, creating a hypercall continuation and backing off immediately, allowing the thread

Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-24 Thread Jan Beulich
On 24.03.2020 16:21, Hongyan Xia wrote: > From: Hongyan Xia > > Unfortunately, even though that commit dropped the domctl lock and > allowed other domctl to continue, it created severe lock contention > within domain destructions themselves. Multiple domain destructions in > parallel now spin

[Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-24 Thread Hongyan Xia
From: Hongyan Xia Unfortunately, even though that commit dropped the domctl lock and allowed other domctl to continue, it created severe lock contention within domain destructions themselves. Multiple domain destructions in parallel now spin for the global heap lock when freeing memory and could