Re: [Xen-devel] [PATCH] arm/gic: Make sense of assertions

2019-10-15 Thread Andrii Anisov
Hello, On 15.10.19 14:08, Julien Grall wrote: To be honest, those ASSERTIONs are pointless. I'd prefer to drop them. -- Sincerely, Andrii Anisov. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinf

Re: [Xen-devel] [PATCH] arm/gic: Make sense of assertions

2019-10-15 Thread Julien Grall
Hi, On 10/15/19 11:01 AM, Andrii Anisov wrote: From: Andrii Anisov ARM Compiler complains about assertion conditions being always true, because sgi is of enum type what has all its values under 16. In order to preserve those asserts, specify the available SGI number right in the enum and use i

[Xen-devel] [PATCH] arm/gic: Make sense of assertions

2019-10-15 Thread Andrii Anisov
From: Andrii Anisov ARM Compiler complains about assertion conditions being always true, because sgi is of enum type what has all its values under 16. In order to preserve those asserts, specify the available SGI number right in the enum and use it for the assertions. This also eliminates nasty h