Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-23 Thread Julien Grall
Hi Jan, On 23/07/2019 10:12, Jan Beulich wrote: On 23.07.2019 10:48, Andrii Anisov wrote: Julien, Jan, Andrew, The problem addressed by [1] causes random ARM64 boot fails dependent on hypervisor code changes. Yet more generic solution was requested by Andrew and supported by Julien [2]. How

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-23 Thread Andrii Anisov
Hello Jan, On 23.07.19 12:12, Jan Beulich wrote: Beyond that I continue to be of the opinion that it should be all-or-nothing: Any pointer pointing anywhere at or inside the region should be accepted, or just the one pointing precisely at the start. It's reasonable enough and I agree with that

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-23 Thread Jan Beulich
On 23.07.2019 10:48, Andrii Anisov wrote: > Julien, Jan, Andrew, > > The problem addressed by [1] causes random ARM64 boot fails dependent on > hypervisor code changes. > Yet more generic solution was requested by Andrew and supported by Julien [2]. > > How to proceed with this particular patch?

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-23 Thread Andrii Anisov
Julien, Jan, Andrew, The problem addressed by [1] causes random ARM64 boot fails dependent on hypervisor code changes. Yet more generic solution was requested by Andrew and supported by Julien [2]. How to proceed with this particular patch? As I understand, Jan doubts we should move page alignm

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-22 Thread Julien Grall
Hi, On 22/07/2019 13:11, Jan Beulich wrote: On 22.07.2019 14:02, Julien Grall wrote: On 22/07/2019 11:23, Jan Beulich wrote: On 22.07.2019 11:30, Andrii Anisov wrote: On 19.07.19 12:37, Jan Beulich wrote: On 18.07.2019 19:11, Andrii Anisov wrote: Let vunmap align passed virtual address by

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-22 Thread Jan Beulich
On 22.07.2019 14:02, Julien Grall wrote: > On 22/07/2019 11:23, Jan Beulich wrote: >> On 22.07.2019 11:30, Andrii Anisov wrote: >>> >>> >>> On 19.07.19 12:37, Jan Beulich wrote: On 18.07.2019 19:11, Andrii Anisov wrote: > Let vunmap align passed virtual address by PAGE_SIZE. Desp

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-22 Thread Julien Grall
On 22/07/2019 11:23, Jan Beulich wrote: On 22.07.2019 11:30, Andrii Anisov wrote: On 19.07.19 12:37, Jan Beulich wrote: On 18.07.2019 19:11, Andrii Anisov wrote: Let vunmap align passed virtual address by PAGE_SIZE. Despite seeing Andrew's R-b you've already got I'd like to point out that

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-22 Thread Jan Beulich
On 22.07.2019 11:30, Andrii Anisov wrote: > > > On 19.07.19 12:37, Jan Beulich wrote: >> On 18.07.2019 19:11, Andrii Anisov wrote: >>> Let vunmap align passed virtual address by PAGE_SIZE. >> >> Despite seeing Andrew's R-b you've already got I'd like to point out >> that this increases the risk o

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-22 Thread Andrii Anisov
On 19.07.19 12:37, Jan Beulich wrote: On 18.07.2019 19:11, Andrii Anisov wrote: Let vunmap align passed virtual address by PAGE_SIZE. Despite seeing Andrew's R-b you've already got I'd like to point out that this increases the risk of some code passing the wrong pointer into here. {,un}map_d

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-22 Thread Andrii Anisov
On 19.07.19 12:51, Julien Grall wrote: Currently vunmap() is called from  from xen/arch/arm/cpuerrata.c with an s/  from// address potentially not page aligned. Instead of fixing that in ARM code, s/ARM/Arm/ we let vunmap() making alignment by itself and stripping other existing vunmap()

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-19 Thread Julien Grall
On 18/07/2019 18:33, Andrii Anisov wrote: Hello Andrew, On 18.07.19 20:16, Andrew Cooper wrote: If you can come up with a suitable piece of text, I can fix up on commit. Following text might have a better reference to the current problem: Currently vunmap() is called from  from xen/arch/ar

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-19 Thread Jan Beulich
On 18.07.2019 19:11, Andrii Anisov wrote: > Let vunmap align passed virtual address by PAGE_SIZE. Despite seeing Andrew's R-b you've already got I'd like to point out that this increases the risk of some code passing the wrong pointer into here. {,un}map_domain_page() act on single pages only, so

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-18 Thread Andrii Anisov
Hello Andrew, On 18.07.19 20:16, Andrew Cooper wrote: If you can come up with a suitable piece of text, I can fix up on commit. Following text might have a better reference to the current problem: Currently vunmap() is called from from xen/arch/arm/cpuerrata.c with an address potentially not

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-18 Thread Andrew Cooper
On 18/07/2019 18:11, Andrii Anisov wrote: > From: Andrii Anisov > > Let vunmap align passed virtual address by PAGE_SIZE. You probably want to describe where this goes wrong currently on ARM here. If you can come up with a suitable piece of text, I can fix up on commit. > This also makes it con

[Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-18 Thread Andrii Anisov
From: Andrii Anisov Let vunmap align passed virtual address by PAGE_SIZE. This also makes it consistent with how {,un}map_domain_page() currently works. With the main change, also: - strip all existing vunmap() calls from prior masking - replace opencoded PAGE_MASK macro in vm_index() Signed-