Re: [Xen-devel] [PATCH] x86/compat: fix compilation errors with clang 6

2018-01-23 Thread Roger Pau Monné
On Tue, Jan 23, 2018 at 06:34:44AM -0700, Jan Beulich wrote: > >>> On 23.01.18 at 13:38, wrote: > > Fix this by using pragma push/pop in order to store the current pragma > > value in the compiler stack and later restoring it. > > For Linux this is fine all the way back to

Re: [Xen-devel] [PATCH] x86/compat: fix compilation errors with clang 6

2018-01-23 Thread Jan Beulich
>>> On 23.01.18 at 13:38, wrote: > Fix this by using pragma push/pop in order to store the current pragma > value in the compiler stack and later restoring it. For Linux this is fine all the way back to gcc 4.1 afaict, but what about other OSes using gcc? In 4.1, only

[Xen-devel] [PATCH] x86/compat: fix compilation errors with clang 6

2018-01-23 Thread Roger Pau Monne
The following errors are generated when compiling Xen with clang 6: In file included from x86_64/asm-offsets.c:9: In file included from /root/src/xen/xen/include/xen/sched.h:8: In file included from /root/src/xen/xen/include/xen/shared.h:6: In file included from